From: Haitao Huang <haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: jarkko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
dave.hansen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sgx-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org,
hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org,
sohil.mehta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Cc: zhiquan1.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
seanjc-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
zhanb-0li6OtcxBFHby3iVrkZq2A@public.gmane.org,
anakrish-0li6OtcxBFHby3iVrkZq2A@public.gmane.org,
mikko.ylinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
yangjie-0li6OtcxBFHby3iVrkZq2A@public.gmane.org
Subject: [PATCH v4 10/18] x86/sgx: Add EPC page flags to identify owner types
Date: Tue, 12 Sep 2023 21:06:27 -0700 [thread overview]
Message-ID: <20230913040635.28815-11-haitao.huang@linux.intel.com> (raw)
In-Reply-To: <20230913040635.28815-1-haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
From: Sean Christopherson <sean.j.christopherson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Two types of owners of struct sgx_epc_page, 'sgx_encl' for VA pages and
'sgx_encl_page' can be stored in the previously introduced union field.
OOM support for cgroups requires that the owner needs to be identified
when selecting pages from the unreclaimable list. Address this by adding
flags for the owner type.
Signed-off-by: Sean Christopherson <sean.j.christopherson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Signed-off-by: Kristen Carlson Accardi <kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Signed-off-by: Haitao Huang <haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: Sean Christopherson <seanjc-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
---
V4:
- Updates for patch reordering.
- Rename SGX_EPC_OWNER_ENCL_PAGE to SGX_EPC_OWNER_PAGE. (Jarkko)
- Commit message changes. (Jarkko)
---
arch/x86/kernel/cpu/sgx/encl.c | 13 +++++++------
arch/x86/kernel/cpu/sgx/ioctl.c | 6 ++++--
arch/x86/kernel/cpu/sgx/sgx.h | 6 ++++++
3 files changed, 17 insertions(+), 8 deletions(-)
diff --git a/arch/x86/kernel/cpu/sgx/encl.c b/arch/x86/kernel/cpu/sgx/encl.c
index 1aee0ad00e66..91f83a5e543d 100644
--- a/arch/x86/kernel/cpu/sgx/encl.c
+++ b/arch/x86/kernel/cpu/sgx/encl.c
@@ -248,6 +248,7 @@ static struct sgx_epc_page *sgx_encl_load_secs(struct sgx_encl *encl)
epc_page = sgx_encl_eldu(&encl->secs, NULL);
if (!IS_ERR(epc_page))
sgx_record_epc_page(epc_page,
+ SGX_EPC_OWNER_PAGE |
SGX_EPC_PAGE_UNRECLAIMABLE);
}
@@ -276,8 +277,8 @@ static struct sgx_encl_page *__sgx_encl_load_page(struct sgx_encl *encl,
return ERR_CAST(epc_page);
encl->secs_child_cnt++;
- sgx_record_epc_page(epc_page,
- SGX_EPC_PAGE_RECLAIMABLE);
+ sgx_record_epc_page(epc_page, SGX_EPC_OWNER_PAGE |
+ SGX_EPC_PAGE_RECLAIMABLE);
return entry;
}
@@ -403,8 +404,8 @@ static vm_fault_t sgx_encl_eaug_page(struct vm_area_struct *vma,
encl_page->type = SGX_PAGE_TYPE_REG;
encl->secs_child_cnt++;
- sgx_record_epc_page(epc_page,
- SGX_EPC_PAGE_RECLAIMABLE);
+ sgx_record_epc_page(epc_page, SGX_EPC_OWNER_PAGE |
+ SGX_EPC_PAGE_RECLAIMABLE);
phys_addr = sgx_get_epc_phys_addr(epc_page);
/*
@@ -1263,8 +1264,8 @@ struct sgx_epc_page *sgx_alloc_va_page(struct sgx_encl *encl, bool reclaim)
sgx_encl_free_epc_page(epc_page);
return ERR_PTR(-EFAULT);
}
- sgx_record_epc_page(epc_page,
- SGX_EPC_PAGE_UNRECLAIMABLE);
+ sgx_record_epc_page(epc_page, SGX_EPC_OWNER_ENCL |
+ SGX_EPC_PAGE_UNRECLAIMABLE);
return epc_page;
}
diff --git a/arch/x86/kernel/cpu/sgx/ioctl.c b/arch/x86/kernel/cpu/sgx/ioctl.c
index 3ab8c050e665..95ec20a6992f 100644
--- a/arch/x86/kernel/cpu/sgx/ioctl.c
+++ b/arch/x86/kernel/cpu/sgx/ioctl.c
@@ -114,6 +114,7 @@ static int sgx_encl_create(struct sgx_encl *encl, struct sgx_secs *secs)
encl->attributes_mask = SGX_ATTR_UNPRIV_MASK;
sgx_record_epc_page(encl->secs.epc_page,
+ SGX_EPC_OWNER_PAGE |
SGX_EPC_PAGE_UNRECLAIMABLE);
/* Set only after completion, as encl->lock has not been taken. */
@@ -325,8 +326,8 @@ static int sgx_encl_add_page(struct sgx_encl *encl, unsigned long src,
goto err_out;
}
- sgx_record_epc_page(epc_page,
- SGX_EPC_PAGE_RECLAIMABLE);
+ sgx_record_epc_page(epc_page, SGX_EPC_OWNER_PAGE |
+ SGX_EPC_PAGE_RECLAIMABLE);
mutex_unlock(&encl->lock);
mmap_read_unlock(current->mm);
return ret;
@@ -981,6 +982,7 @@ static long sgx_enclave_modify_types(struct sgx_encl *encl,
mutex_lock(&encl->lock);
sgx_record_epc_page(entry->epc_page,
+ SGX_EPC_OWNER_PAGE |
SGX_EPC_PAGE_RECLAIMABLE);
}
diff --git a/arch/x86/kernel/cpu/sgx/sgx.h b/arch/x86/kernel/cpu/sgx/sgx.h
index c75ddc7168fa..e06b4aadb6a1 100644
--- a/arch/x86/kernel/cpu/sgx/sgx.h
+++ b/arch/x86/kernel/cpu/sgx/sgx.h
@@ -64,6 +64,12 @@ enum sgx_epc_page_state {
#define SGX_EPC_PAGE_STATE_MASK GENMASK(2, 0)
+/* flag for pages owned by a sgx_encl_page */
+#define SGX_EPC_OWNER_PAGE BIT(3)
+
+/* flag for pages owned by a sgx_encl struct */
+#define SGX_EPC_OWNER_ENCL BIT(4)
+
struct sgx_epc_page {
unsigned int section;
u16 flags;
--
2.25.1
next prev parent reply other threads:[~2023-09-13 4:06 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 4:06 [PATCH v4 00/18] Add Cgroup support for SGX EPC memory Haitao Huang
[not found] ` <20230913040635.28815-1-haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2023-09-13 4:06 ` [PATCH v4 01/18] cgroup/misc: Add per resource callbacks for CSS events Haitao Huang
[not found] ` <20230913040635.28815-2-haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2023-09-13 9:39 ` Jarkko Sakkinen
2023-09-16 4:11 ` Haitao Huang
[not found] ` <op.2bci9anpwjvjmi-yDQzE4XY+yVaPPhiJ6yCxLKMmGWinSIL2HeeBUIffwg@public.gmane.org>
2023-09-25 16:57 ` Jarkko Sakkinen
2023-09-25 16:57 ` Jarkko Sakkinen
2023-09-15 17:55 ` Tejun Heo
[not found] ` <ZQSaoXBg-X4cwFdX-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2023-09-15 17:58 ` Tejun Heo
2023-09-16 1:27 ` Haitao Huang
2023-09-13 4:06 ` [PATCH v4 02/18] cgroup/misc: Add SGX EPC resource type and export APIs for SGX driver Haitao Huang
[not found] ` <20230913040635.28815-3-haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2023-09-13 9:43 ` Jarkko Sakkinen
2023-09-13 4:06 ` [PATCH v4 03/18] x86/sgx: Add sgx_epc_lru_lists to encapsulate LRU lists Haitao Huang
[not found] ` <20230913040635.28815-4-haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2023-09-13 9:46 ` Jarkko Sakkinen
2023-09-14 10:31 ` Huang, Kai
[not found] ` <851f9b3043732c17cd8f86a77ccee0b7c6caa22f.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2023-09-14 16:13 ` Dave Hansen
2023-09-14 21:58 ` Huang, Kai
2023-09-15 16:28 ` Haitao Huang
2023-09-13 4:06 ` [PATCH v4 04/18] x86/sgx: Use sgx_epc_lru_lists for existing active page list Haitao Huang
[not found] ` <20230913040635.28815-5-haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2023-09-13 15:00 ` Jarkko Sakkinen
2023-09-13 4:06 ` [PATCH v4 05/18] x86/sgx: Store reclaimable EPC pages in sgx_epc_lru_lists Haitao Huang
[not found] ` <20230913040635.28815-6-haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2023-09-13 15:14 ` Jarkko Sakkinen
2023-09-13 4:06 ` [PATCH v4 06/18] x86/sgx: Introduce EPC page states Haitao Huang
[not found] ` <20230913040635.28815-7-haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2023-09-13 15:15 ` Jarkko Sakkinen
2023-09-13 4:06 ` [PATCH v4 07/18] x86/sgx: Introduce RECLAIM_IN_PROGRESS state Haitao Huang
2023-09-13 4:06 ` [PATCH v4 08/18] x86/sgx: Use a list to track to-be-reclaimed pages Haitao Huang
[not found] ` <20230913040635.28815-9-haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2023-09-13 15:30 ` Jarkko Sakkinen
2023-09-13 4:06 ` [PATCH v4 09/18] x86/sgx: Store struct sgx_encl when allocating new VA pages Haitao Huang
[not found] ` <20230913040635.28815-10-haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2023-09-13 15:31 ` Jarkko Sakkinen
2023-09-13 4:06 ` Haitao Huang [this message]
2023-09-13 4:06 ` [PATCH v4 11/18] x86/sgx: store unreclaimable pages in LRU lists Haitao Huang
[not found] ` <20230913040635.28815-12-haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2023-09-13 15:33 ` Jarkko Sakkinen
2023-09-13 4:06 ` [PATCH v4 12/18] x86/sgx: Add EPC OOM path to forcefully reclaim EPC Haitao Huang
[not found] ` <20230913040635.28815-13-haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2023-09-13 15:34 ` Jarkko Sakkinen
2023-09-16 4:19 ` Haitao Huang
2023-09-13 4:06 ` [PATCH v4 13/18] x86/sgx: Expose sgx_reclaim_pages() for use by EPC cgroup Haitao Huang
2023-09-13 15:36 ` Jarkko Sakkinen
2023-09-13 4:06 ` [PATCH v4 14/18] x86/sgx: Add helper to grab pages from an arbitrary EPC LRU Haitao Huang
2023-09-13 4:06 ` [PATCH v4 15/18] x86/sgx: Prepare for multiple LRUs Haitao Huang
[not found] ` <20230913040635.28815-16-haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2023-09-13 15:42 ` Jarkko Sakkinen
2023-09-16 4:18 ` Haitao Huang
2023-09-13 4:06 ` [PATCH v4 16/18] x86/sgx: Limit process EPC usage with misc cgroup controller Haitao Huang
2023-09-13 15:48 ` Jarkko Sakkinen
2023-09-13 4:06 ` [PATCH v4 17/18] Docs/x86/sgx: Add description for cgroup support Haitao Huang
2023-09-13 4:06 ` [PATCH v4 18/18] selftests/sgx: Add scripts for epc cgroup testing Haitao Huang
2023-09-15 18:26 ` [PATCH v4 00/18] Add Cgroup support for SGX EPC memory Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230913040635.28815-11-haitao.huang@linux.intel.com \
--to=haitao.huang-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=anakrish-0li6OtcxBFHby3iVrkZq2A@public.gmane.org \
--cc=bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dave.hansen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=jarkko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sgx-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mikko.ylinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=seanjc-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=sohil.mehta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=yangjie-0li6OtcxBFHby3iVrkZq2A@public.gmane.org \
--cc=zhanb-0li6OtcxBFHby3iVrkZq2A@public.gmane.org \
--cc=zhiquan1.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox