From: Haitao Huang <haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: jarkko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
dave.hansen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sgx-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org,
hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org,
sohil.mehta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Cc: zhiquan1.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
seanjc-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
zhanb-0li6OtcxBFHby3iVrkZq2A@public.gmane.org,
anakrish-0li6OtcxBFHby3iVrkZq2A@public.gmane.org,
mikko.ylinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
yangjie-0li6OtcxBFHby3iVrkZq2A@public.gmane.org
Subject: [PATCH v4 01/18] cgroup/misc: Add per resource callbacks for CSS events
Date: Tue, 12 Sep 2023 21:06:18 -0700 [thread overview]
Message-ID: <20230913040635.28815-2-haitao.huang@linux.intel.com> (raw)
In-Reply-To: <20230913040635.28815-1-haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
From: Kristen Carlson Accardi <kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Consumers of the misc cgroup controller might need to perform separate
actions for Cgroups Subsystem State(CSS) events: cgroup alloc and free.
In addition, writes to the max value may also need separate action. Add
the ability to allow downstream users to setup callbacks for these
operations, and call the corresponding per-resource-type callback when
appropriate.
This code will be utilized by the SGX driver in a future patch.
Signed-off-by: Kristen Carlson Accardi <kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Signed-off-by: Haitao Huang <haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
V4:
- Moved this to the front of the series.
- Applies on cgroup/for-6.6 with the overflow fix for misc.
V3:
- Removed the released() callback
---
include/linux/misc_cgroup.h | 5 +++++
kernel/cgroup/misc.c | 32 +++++++++++++++++++++++++++++---
2 files changed, 34 insertions(+), 3 deletions(-)
diff --git a/include/linux/misc_cgroup.h b/include/linux/misc_cgroup.h
index e799b1f8d05b..e1bcd176c2de 100644
--- a/include/linux/misc_cgroup.h
+++ b/include/linux/misc_cgroup.h
@@ -37,6 +37,11 @@ struct misc_res {
u64 max;
atomic64_t usage;
atomic64_t events;
+
+ /* per resource callback ops */
+ int (*misc_cg_alloc)(struct misc_cg *cg);
+ void (*misc_cg_free)(struct misc_cg *cg);
+ void (*misc_cg_max_write)(struct misc_cg *cg);
};
/**
diff --git a/kernel/cgroup/misc.c b/kernel/cgroup/misc.c
index 79a3717a5803..e0092170d0dd 100644
--- a/kernel/cgroup/misc.c
+++ b/kernel/cgroup/misc.c
@@ -276,10 +276,13 @@ static ssize_t misc_cg_max_write(struct kernfs_open_file *of, char *buf,
cg = css_misc(of_css(of));
- if (READ_ONCE(misc_res_capacity[type]))
+ if (READ_ONCE(misc_res_capacity[type])) {
WRITE_ONCE(cg->res[type].max, max);
- else
+ if (cg->res[type].misc_cg_max_write)
+ cg->res[type].misc_cg_max_write(cg);
+ } else {
ret = -EINVAL;
+ }
return ret ? ret : nbytes;
}
@@ -383,23 +386,39 @@ static struct cftype misc_cg_files[] = {
static struct cgroup_subsys_state *
misc_cg_alloc(struct cgroup_subsys_state *parent_css)
{
+ struct misc_cg *parent_cg;
enum misc_res_type i;
struct misc_cg *cg;
+ int ret;
if (!parent_css) {
cg = &root_cg;
+ parent_cg = &root_cg;
} else {
cg = kzalloc(sizeof(*cg), GFP_KERNEL);
if (!cg)
return ERR_PTR(-ENOMEM);
+ parent_cg = css_misc(parent_css);
}
for (i = 0; i < MISC_CG_RES_TYPES; i++) {
WRITE_ONCE(cg->res[i].max, MAX_NUM);
atomic64_set(&cg->res[i].usage, 0);
+ if (parent_cg->res[i].misc_cg_alloc) {
+ ret = parent_cg->res[i].misc_cg_alloc(cg);
+ if (ret)
+ goto alloc_err;
+ }
}
return &cg->css;
+
+alloc_err:
+ for (i = 0; i < MISC_CG_RES_TYPES; i++)
+ if (parent_cg->res[i].misc_cg_free)
+ cg->res[i].misc_cg_free(cg);
+ kfree(cg);
+ return ERR_PTR(ret);
}
/**
@@ -410,7 +429,14 @@ misc_cg_alloc(struct cgroup_subsys_state *parent_css)
*/
static void misc_cg_free(struct cgroup_subsys_state *css)
{
- kfree(css_misc(css));
+ struct misc_cg *cg = css_misc(css);
+ enum misc_res_type i;
+
+ for (i = 0; i < MISC_CG_RES_TYPES; i++)
+ if (cg->res[i].misc_cg_free)
+ cg->res[i].misc_cg_free(cg);
+
+ kfree(cg);
}
/* Cgroup controller callbacks */
--
2.25.1
next prev parent reply other threads:[~2023-09-13 4:06 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 4:06 [PATCH v4 00/18] Add Cgroup support for SGX EPC memory Haitao Huang
[not found] ` <20230913040635.28815-1-haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2023-09-13 4:06 ` Haitao Huang [this message]
[not found] ` <20230913040635.28815-2-haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2023-09-13 9:39 ` [PATCH v4 01/18] cgroup/misc: Add per resource callbacks for CSS events Jarkko Sakkinen
2023-09-16 4:11 ` Haitao Huang
[not found] ` <op.2bci9anpwjvjmi-yDQzE4XY+yVaPPhiJ6yCxLKMmGWinSIL2HeeBUIffwg@public.gmane.org>
2023-09-25 16:57 ` Jarkko Sakkinen
2023-09-25 16:57 ` Jarkko Sakkinen
2023-09-15 17:55 ` Tejun Heo
[not found] ` <ZQSaoXBg-X4cwFdX-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2023-09-15 17:58 ` Tejun Heo
2023-09-16 1:27 ` Haitao Huang
2023-09-13 4:06 ` [PATCH v4 02/18] cgroup/misc: Add SGX EPC resource type and export APIs for SGX driver Haitao Huang
[not found] ` <20230913040635.28815-3-haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2023-09-13 9:43 ` Jarkko Sakkinen
2023-09-13 4:06 ` [PATCH v4 03/18] x86/sgx: Add sgx_epc_lru_lists to encapsulate LRU lists Haitao Huang
[not found] ` <20230913040635.28815-4-haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2023-09-13 9:46 ` Jarkko Sakkinen
2023-09-14 10:31 ` Huang, Kai
[not found] ` <851f9b3043732c17cd8f86a77ccee0b7c6caa22f.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2023-09-14 16:13 ` Dave Hansen
2023-09-14 21:58 ` Huang, Kai
2023-09-15 16:28 ` Haitao Huang
2023-09-13 4:06 ` [PATCH v4 04/18] x86/sgx: Use sgx_epc_lru_lists for existing active page list Haitao Huang
[not found] ` <20230913040635.28815-5-haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2023-09-13 15:00 ` Jarkko Sakkinen
2023-09-13 4:06 ` [PATCH v4 05/18] x86/sgx: Store reclaimable EPC pages in sgx_epc_lru_lists Haitao Huang
[not found] ` <20230913040635.28815-6-haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2023-09-13 15:14 ` Jarkko Sakkinen
2023-09-13 4:06 ` [PATCH v4 06/18] x86/sgx: Introduce EPC page states Haitao Huang
[not found] ` <20230913040635.28815-7-haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2023-09-13 15:15 ` Jarkko Sakkinen
2023-09-13 4:06 ` [PATCH v4 07/18] x86/sgx: Introduce RECLAIM_IN_PROGRESS state Haitao Huang
2023-09-13 4:06 ` [PATCH v4 08/18] x86/sgx: Use a list to track to-be-reclaimed pages Haitao Huang
[not found] ` <20230913040635.28815-9-haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2023-09-13 15:30 ` Jarkko Sakkinen
2023-09-13 4:06 ` [PATCH v4 09/18] x86/sgx: Store struct sgx_encl when allocating new VA pages Haitao Huang
[not found] ` <20230913040635.28815-10-haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2023-09-13 15:31 ` Jarkko Sakkinen
2023-09-13 4:06 ` [PATCH v4 10/18] x86/sgx: Add EPC page flags to identify owner types Haitao Huang
2023-09-13 4:06 ` [PATCH v4 11/18] x86/sgx: store unreclaimable pages in LRU lists Haitao Huang
[not found] ` <20230913040635.28815-12-haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2023-09-13 15:33 ` Jarkko Sakkinen
2023-09-13 4:06 ` [PATCH v4 12/18] x86/sgx: Add EPC OOM path to forcefully reclaim EPC Haitao Huang
[not found] ` <20230913040635.28815-13-haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2023-09-13 15:34 ` Jarkko Sakkinen
2023-09-16 4:19 ` Haitao Huang
2023-09-13 4:06 ` [PATCH v4 13/18] x86/sgx: Expose sgx_reclaim_pages() for use by EPC cgroup Haitao Huang
2023-09-13 15:36 ` Jarkko Sakkinen
2023-09-13 4:06 ` [PATCH v4 14/18] x86/sgx: Add helper to grab pages from an arbitrary EPC LRU Haitao Huang
2023-09-13 4:06 ` [PATCH v4 15/18] x86/sgx: Prepare for multiple LRUs Haitao Huang
[not found] ` <20230913040635.28815-16-haitao.huang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2023-09-13 15:42 ` Jarkko Sakkinen
2023-09-16 4:18 ` Haitao Huang
2023-09-13 4:06 ` [PATCH v4 16/18] x86/sgx: Limit process EPC usage with misc cgroup controller Haitao Huang
2023-09-13 15:48 ` Jarkko Sakkinen
2023-09-13 4:06 ` [PATCH v4 17/18] Docs/x86/sgx: Add description for cgroup support Haitao Huang
2023-09-13 4:06 ` [PATCH v4 18/18] selftests/sgx: Add scripts for epc cgroup testing Haitao Huang
2023-09-15 18:26 ` [PATCH v4 00/18] Add Cgroup support for SGX EPC memory Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230913040635.28815-2-haitao.huang@linux.intel.com \
--to=haitao.huang-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=anakrish-0li6OtcxBFHby3iVrkZq2A@public.gmane.org \
--cc=bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dave.hansen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=jarkko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sgx-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mikko.ylinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=seanjc-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=sohil.mehta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=yangjie-0li6OtcxBFHby3iVrkZq2A@public.gmane.org \
--cc=zhanb-0li6OtcxBFHby3iVrkZq2A@public.gmane.org \
--cc=zhiquan1.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox