Linux cgroups development
 help / color / mirror / Atom feed
* [PATCH 2/5] Documentation: admin-guide: fix trailing whitespace in cgroup-v2.rst
@ 2026-07-18 14:40 Yahya Toubali
  0 siblings, 0 replies; 7+ messages in thread
From: Yahya Toubali @ 2026-07-18 14:40 UTC (permalink / raw)
  To: Tejun Heo, Johannes Weiner, Michal Koutný, Jonathan Corbet,
	Shuah Khan, open list:CONTROL GROUP (CGROUP),
	open list:DOCUMENTATION, open list
  Cc: Yahya Toubali

Remove trailing spaces on lines 1335 and 2197.
---
 Documentation/admin-guide/cgroup-v2.rst | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
index 14b8c571c0d1..f15a613fed6a 100644
--- a/Documentation/admin-guide/cgroup-v2.rst
+++ b/Documentation/admin-guide/cgroup-v2.rst
@@ -1,4 +1,5 @@
 .. _cgroup-v2:
+.. SPDX-License-Identifier: GPL-2.0
 
 ================
 Control Group v2
@@ -1332,7 +1333,7 @@ PAGE_SIZE multiple when read back.
 	cgroup is within its effective low boundary, the cgroup's
 	memory won't be reclaimed unless there is no reclaimable
 	memory available in unprotected cgroups.
-	Above the effective low	boundary (or 
+	Above the effective low	boundary (or
 	effective min boundary if it is higher), pages are reclaimed
 	proportionally to the overage, reducing reclaim pressure for
 	smaller overages.
@@ -2194,7 +2195,7 @@ of the two is enforced.
 
 cgroup writeback requires explicit support from the underlying
 filesystem.  Currently, cgroup writeback is implemented on ext2, ext4,
-btrfs, f2fs, and xfs.  On other filesystems, all writeback IOs are 
+btrfs, f2fs, and xfs.  On other filesystems, all writeback IOs are
 attributed to the root cgroup.
 
 There are inherent differences in memory and writeback management
-- 
2.55.0



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/5] Documentation: admin-guide: fix trailing whitespace in cgroup-v2.rst
       [not found] <20260718151913.1892547-1-yahya@yahyatoubali.me>
@ 2026-07-18 15:19 ` Yahya Toubali
  2026-07-18 16:14   ` Weijie Yuan
  0 siblings, 1 reply; 7+ messages in thread
From: Yahya Toubali @ 2026-07-18 15:19 UTC (permalink / raw)
  To: Tejun Heo, Johannes Weiner, Michal Koutný, Jonathan Corbet,
	Shuah Khan, open list:CONTROL GROUP (CGROUP),
	open list:DOCUMENTATION, open list
  Cc: Yahya Toubali

Remove trailing spaces on lines 1335 and 2197.

Signed-off-by: Yahya Toubali <yahya@yahyatoubali.me>
---
 Documentation/admin-guide/cgroup-v2.rst | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
index 14b8c571c0d1..f15a613fed6a 100644
--- a/Documentation/admin-guide/cgroup-v2.rst
+++ b/Documentation/admin-guide/cgroup-v2.rst
@@ -1,4 +1,5 @@
 .. _cgroup-v2:
+.. SPDX-License-Identifier: GPL-2.0
 
 ================
 Control Group v2
@@ -1332,7 +1333,7 @@ PAGE_SIZE multiple when read back.
 	cgroup is within its effective low boundary, the cgroup's
 	memory won't be reclaimed unless there is no reclaimable
 	memory available in unprotected cgroups.
-	Above the effective low	boundary (or 
+	Above the effective low	boundary (or
 	effective min boundary if it is higher), pages are reclaimed
 	proportionally to the overage, reducing reclaim pressure for
 	smaller overages.
@@ -2194,7 +2195,7 @@ of the two is enforced.
 
 cgroup writeback requires explicit support from the underlying
 filesystem.  Currently, cgroup writeback is implemented on ext2, ext4,
-btrfs, f2fs, and xfs.  On other filesystems, all writeback IOs are 
+btrfs, f2fs, and xfs.  On other filesystems, all writeback IOs are
 attributed to the root cgroup.
 
 There are inherent differences in memory and writeback management
-- 
2.55.0



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/5] Documentation: admin-guide: fix trailing whitespace in cgroup-v2.rst
  2026-07-18 15:19 ` [PATCH 2/5] Documentation: admin-guide: fix trailing whitespace in cgroup-v2.rst Yahya Toubali
@ 2026-07-18 16:14   ` Weijie Yuan
  2026-07-18 16:16     ` Randy Dunlap
  2026-07-18 16:56     ` [PATCH v3] " Yahya Toubali
  0 siblings, 2 replies; 7+ messages in thread
From: Weijie Yuan @ 2026-07-18 16:14 UTC (permalink / raw)
  To: Yahya Toubali
  Cc: Tejun Heo, Johannes Weiner, Michal Koutný, Jonathan Corbet,
	Shuah Khan, open list:CONTROL GROUP (CGROUP),
	open list:DOCUMENTATION, open list

On Sat, Jul 18, 2026 at 04:19:08PM +0100, Yahya Toubali wrote:
> Remove trailing spaces on lines 1335 and 2197.
> 
> Signed-off-by: Yahya Toubali <yahya@yahyatoubali.me>

Hmmm, for a file that might be modified, I wonder if it makes sense to
include fixed line numbers in the commit message. i.e. When the line
number changes, your commit message will become meaningless.

I'd love to hear others' comments.

Thanks.

> ---
>  Documentation/admin-guide/cgroup-v2.rst | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 14b8c571c0d1..f15a613fed6a 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1,4 +1,5 @@
>  .. _cgroup-v2:
> +.. SPDX-License-Identifier: GPL-2.0
>  
>  ================
>  Control Group v2
> @@ -1332,7 +1333,7 @@ PAGE_SIZE multiple when read back.
>  	cgroup is within its effective low boundary, the cgroup's
>  	memory won't be reclaimed unless there is no reclaimable
>  	memory available in unprotected cgroups.
> -	Above the effective low	boundary (or 
> +	Above the effective low	boundary (or
>  	effective min boundary if it is higher), pages are reclaimed
>  	proportionally to the overage, reducing reclaim pressure for
>  	smaller overages.
> @@ -2194,7 +2195,7 @@ of the two is enforced.
>  
>  cgroup writeback requires explicit support from the underlying
>  filesystem.  Currently, cgroup writeback is implemented on ext2, ext4,
> -btrfs, f2fs, and xfs.  On other filesystems, all writeback IOs are 
> +btrfs, f2fs, and xfs.  On other filesystems, all writeback IOs are
>  attributed to the root cgroup.
>  
>  There are inherent differences in memory and writeback management

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/5] Documentation: admin-guide: fix trailing whitespace in cgroup-v2.rst
  2026-07-18 16:14   ` Weijie Yuan
@ 2026-07-18 16:16     ` Randy Dunlap
  2026-07-18 16:32       ` Weijie Yuan
  2026-07-18 16:56     ` [PATCH v3] " Yahya Toubali
  1 sibling, 1 reply; 7+ messages in thread
From: Randy Dunlap @ 2026-07-18 16:16 UTC (permalink / raw)
  To: Weijie Yuan, Yahya Toubali
  Cc: Tejun Heo, Johannes Weiner, Michal Koutný, Jonathan Corbet,
	Shuah Khan, open list:CONTROL GROUP (CGROUP),
	open list:DOCUMENTATION, open list



On 7/18/26 9:14 AM, Weijie Yuan wrote:
> On Sat, Jul 18, 2026 at 04:19:08PM +0100, Yahya Toubali wrote:
>> Remove trailing spaces on lines 1335 and 2197.
>>
>> Signed-off-by: Yahya Toubali <yahya@yahyatoubali.me>
> 
> Hmmm, for a file that might be modified, I wonder if it makes sense to
> include fixed line numbers in the commit message. i.e. When the line
> number changes, your commit message will become meaningless.
> 
> I'd love to hear others' comments.

I wouldn't include the line numbers...

>> ---
>>  Documentation/admin-guide/cgroup-v2.rst | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
>> index 14b8c571c0d1..f15a613fed6a 100644
>> --- a/Documentation/admin-guide/cgroup-v2.rst
>> +++ b/Documentation/admin-guide/cgroup-v2.rst
>> @@ -1,4 +1,5 @@
>>  .. _cgroup-v2:
>> +.. SPDX-License-Identifier: GPL-2.0
>>  
>>  ================
>>  Control Group v2
>> @@ -1332,7 +1333,7 @@ PAGE_SIZE multiple when read back.
>>  	cgroup is within its effective low boundary, the cgroup's
>>  	memory won't be reclaimed unless there is no reclaimable
>>  	memory available in unprotected cgroups.
>> -	Above the effective low	boundary (or 
>> +	Above the effective low	boundary (or
>>  	effective min boundary if it is higher), pages are reclaimed
>>  	proportionally to the overage, reducing reclaim pressure for
>>  	smaller overages.
>> @@ -2194,7 +2195,7 @@ of the two is enforced.
>>  
>>  cgroup writeback requires explicit support from the underlying
>>  filesystem.  Currently, cgroup writeback is implemented on ext2, ext4,
>> -btrfs, f2fs, and xfs.  On other filesystems, all writeback IOs are 
>> +btrfs, f2fs, and xfs.  On other filesystems, all writeback IOs are
>>  attributed to the root cgroup.
>>  
>>  There are inherent differences in memory and writeback management
> 

-- 
~Randy


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/5] Documentation: admin-guide: fix trailing whitespace in cgroup-v2.rst
  2026-07-18 16:16     ` Randy Dunlap
@ 2026-07-18 16:32       ` Weijie Yuan
  0 siblings, 0 replies; 7+ messages in thread
From: Weijie Yuan @ 2026-07-18 16:32 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: Yahya Toubali, Tejun Heo, Johannes Weiner, Michal Koutný,
	Jonathan Corbet, Shuah Khan, open list:CONTROL GROUP (CGROUP),
	open list:DOCUMENTATION, open list

On Sat, Jul 18, 2026 at 09:16:29AM -0700, Randy Dunlap wrote:
> 
> 
> On 7/18/26 9:14 AM, Weijie Yuan wrote:
> > On Sat, Jul 18, 2026 at 04:19:08PM +0100, Yahya Toubali wrote:
> >> Remove trailing spaces on lines 1335 and 2197.
> >>
> >> Signed-off-by: Yahya Toubali <yahya@yahyatoubali.me>
> > 
> > Hmmm, for a file that might be modified, I wonder if it makes sense to
> > include fixed line numbers in the commit message. i.e. When the line
> > number changes, your commit message will become meaningless.
> > 
> > I'd love to hear others' comments.
> 
> I wouldn't include the line numbers...

Alright, it seems that Yahya needs to refine his commit message.

Thanks.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v3] Documentation: admin-guide: fix trailing whitespace in cgroup-v2.rst
  2026-07-18 16:14   ` Weijie Yuan
  2026-07-18 16:16     ` Randy Dunlap
@ 2026-07-18 16:56     ` Yahya Toubali
  2026-07-18 17:24       ` Randy Dunlap
  1 sibling, 1 reply; 7+ messages in thread
From: Yahya Toubali @ 2026-07-18 16:56 UTC (permalink / raw)
  To: Tejun Heo, Johannes Weiner, Michal Koutný, Jonathan Corbet,
	Shuah Khan, open list:CONTROL GROUP (CGROUP),
	open list:DOCUMENTATION, open list
  Cc: Weijie Yuan, Randy Dunlap, Yahya Toubali

Remove trailing whitespace flagged by checkpatch.pl in the cgroup
memory and writeback sections.

Signed-off-by: Yahya Toubali <yahya@yahyatoubali.me>
---
 Documentation/admin-guide/cgroup-v2.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
index 14b8c571c0d1..481658cfef40 100644
--- a/Documentation/admin-guide/cgroup-v2.rst
+++ b/Documentation/admin-guide/cgroup-v2.rst
@@ -1332,7 +1332,7 @@ PAGE_SIZE multiple when read back.
 	cgroup is within its effective low boundary, the cgroup's
 	memory won't be reclaimed unless there is no reclaimable
 	memory available in unprotected cgroups.
-	Above the effective low	boundary (or 
+	Above the effective low	boundary (or
 	effective min boundary if it is higher), pages are reclaimed
 	proportionally to the overage, reducing reclaim pressure for
 	smaller overages.
@@ -2194,7 +2194,7 @@ of the two is enforced.
 
 cgroup writeback requires explicit support from the underlying
 filesystem.  Currently, cgroup writeback is implemented on ext2, ext4,
-btrfs, f2fs, and xfs.  On other filesystems, all writeback IOs are 
+btrfs, f2fs, and xfs.  On other filesystems, all writeback IOs are
 attributed to the root cgroup.
 
 There are inherent differences in memory and writeback management

base-commit: 1229e2e57a5c2980ccd457b9b53ea0eed5a22ab3
prerequisite-patch-id: c8aee5eb39e3cd6f2b2f28c82163565665288d2a
-- 
2.55.0



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH v3] Documentation: admin-guide: fix trailing whitespace in cgroup-v2.rst
  2026-07-18 16:56     ` [PATCH v3] " Yahya Toubali
@ 2026-07-18 17:24       ` Randy Dunlap
  0 siblings, 0 replies; 7+ messages in thread
From: Randy Dunlap @ 2026-07-18 17:24 UTC (permalink / raw)
  To: Yahya Toubali, Tejun Heo, Johannes Weiner, Michal Koutný,
	Jonathan Corbet, Shuah Khan, open list:CONTROL GROUP (CGROUP),
	open list:DOCUMENTATION, open list
  Cc: Weijie Yuan



On 7/18/26 9:56 AM, Yahya Toubali wrote:
> Remove trailing whitespace flagged by checkpatch.pl in the cgroup
> memory and writeback sections.
> 
> Signed-off-by: Yahya Toubali <yahya@yahyatoubali.me>
> ---
>  Documentation/admin-guide/cgroup-v2.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 14b8c571c0d1..481658cfef40 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1332,7 +1332,7 @@ PAGE_SIZE multiple when read back.
>  	cgroup is within its effective low boundary, the cgroup's
>  	memory won't be reclaimed unless there is no reclaimable
>  	memory available in unprotected cgroups.
> -	Above the effective low	boundary (or 
> +	Above the effective low	boundary (or
>  	effective min boundary if it is higher), pages are reclaimed
>  	proportionally to the overage, reducing reclaim pressure for
>  	smaller overages.
> @@ -2194,7 +2194,7 @@ of the two is enforced.
>  
>  cgroup writeback requires explicit support from the underlying
>  filesystem.  Currently, cgroup writeback is implemented on ext2, ext4,
> -btrfs, f2fs, and xfs.  On other filesystems, all writeback IOs are 
> +btrfs, f2fs, and xfs.  On other filesystems, all writeback IOs are
>  attributed to the root cgroup.
>  
>  There are inherent differences in memory and writeback management
> 
> base-commit: 1229e2e57a5c2980ccd457b9b53ea0eed5a22ab3
> prerequisite-patch-id: c8aee5eb39e3cd6f2b2f28c82163565665288d2a

From Documentation/process/submitting-patches.rst: (paraphrased)

Don't reply to v2 of a patch with v3 of that patch. We prefer that new/fresh
patches begin their own email thread.

thanks.
-- 
~Randy


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-07-18 17:24 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20260718151913.1892547-1-yahya@yahyatoubali.me>
2026-07-18 15:19 ` [PATCH 2/5] Documentation: admin-guide: fix trailing whitespace in cgroup-v2.rst Yahya Toubali
2026-07-18 16:14   ` Weijie Yuan
2026-07-18 16:16     ` Randy Dunlap
2026-07-18 16:32       ` Weijie Yuan
2026-07-18 16:56     ` [PATCH v3] " Yahya Toubali
2026-07-18 17:24       ` Randy Dunlap
2026-07-18 14:40 [PATCH 2/5] " Yahya Toubali

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox