[PATCH 2/5] Documentation: admin-guide: fix trailing whitespace in cgroup-v2.rst

[PATCH 2/5] Documentation: admin-guide: fix trailing whitespace in cgroup-v2.rst

[Yahya Toubali]

Remove trailing spaces on lines 1335 and 2197.
---
 Documentation/admin-guide/cgroup-v2.rst | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
index 14b8c571c0d1..f15a613fed6a 100644
--- a/Documentation/admin-guide/cgroup-v2.rst
+++ b/Documentation/admin-guide/cgroup-v2.rst
@@ -1,4 +1,5 @@
 .. _cgroup-v2:
+.. SPDX-License-Identifier: GPL-2.0
 
 ================
 Control Group v2
@@ -1332,7 +1333,7 @@ PAGE_SIZE multiple when read back.
 	cgroup is within its effective low boundary, the cgroup's
 	memory won't be reclaimed unless there is no reclaimable
 	memory available in unprotected cgroups.
-	Above the effective low	boundary (or 
+	Above the effective low	boundary (or
 	effective min boundary if it is higher), pages are reclaimed
 	proportionally to the overage, reducing reclaim pressure for
 	smaller overages.
@@ -2194,7 +2195,7 @@ of the two is enforced.
 
 cgroup writeback requires explicit support from the underlying
 filesystem.  Currently, cgroup writeback is implemented on ext2, ext4,
-btrfs, f2fs, and xfs.  On other filesystems, all writeback IOs are 
+btrfs, f2fs, and xfs.  On other filesystems, all writeback IOs are
 attributed to the root cgroup.
 
 There are inherent differences in memory and writeback management
-- 
2.55.0

[PATCH 2/5] Documentation: admin-guide: fix trailing whitespace in cgroup-v2.rst

[Yahya Toubali]

Remove trailing spaces on lines 1335 and 2197.

Signed-off-by: Yahya Toubali <yahya@yahyatoubali.me>
---
 Documentation/admin-guide/cgroup-v2.rst | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
index 14b8c571c0d1..f15a613fed6a 100644
--- a/Documentation/admin-guide/cgroup-v2.rst
+++ b/Documentation/admin-guide/cgroup-v2.rst
@@ -1,4 +1,5 @@
 .. _cgroup-v2:
+.. SPDX-License-Identifier: GPL-2.0
 
 ================
 Control Group v2
@@ -1332,7 +1333,7 @@ PAGE_SIZE multiple when read back.
 	cgroup is within its effective low boundary, the cgroup's
 	memory won't be reclaimed unless there is no reclaimable
 	memory available in unprotected cgroups.
-	Above the effective low	boundary (or 
+	Above the effective low	boundary (or
 	effective min boundary if it is higher), pages are reclaimed
 	proportionally to the overage, reducing reclaim pressure for
 	smaller overages.
@@ -2194,7 +2195,7 @@ of the two is enforced.
 
 cgroup writeback requires explicit support from the underlying
 filesystem.  Currently, cgroup writeback is implemented on ext2, ext4,
-btrfs, f2fs, and xfs.  On other filesystems, all writeback IOs are 
+btrfs, f2fs, and xfs.  On other filesystems, all writeback IOs are
 attributed to the root cgroup.
 
 There are inherent differences in memory and writeback management
-- 
2.55.0

Re: [PATCH 2/5] Documentation: admin-guide: fix trailing whitespace in cgroup-v2.rst

[Weijie Yuan]

On Sat, Jul 18, 2026 at 04:19:08PM +0100, Yahya Toubali wrote:
> Remove trailing spaces on lines 1335 and 2197.
> 
> Signed-off-by: Yahya Toubali <yahya@yahyatoubali.me>

Hmmm, for a file that might be modified, I wonder if it makes sense to
include fixed line numbers in the commit message. i.e. When the line
number changes, your commit message will become meaningless.

I'd love to hear others' comments.

Thanks.

> ---
>  Documentation/admin-guide/cgroup-v2.rst | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 14b8c571c0d1..f15a613fed6a 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1,4 +1,5 @@
>  .. _cgroup-v2:
> +.. SPDX-License-Identifier: GPL-2.0
>  
>  ================
>  Control Group v2
> @@ -1332,7 +1333,7 @@ PAGE_SIZE multiple when read back.
>  	cgroup is within its effective low boundary, the cgroup's
>  	memory won't be reclaimed unless there is no reclaimable
>  	memory available in unprotected cgroups.
> -	Above the effective low	boundary (or 
> +	Above the effective low	boundary (or
>  	effective min boundary if it is higher), pages are reclaimed
>  	proportionally to the overage, reducing reclaim pressure for
>  	smaller overages.
> @@ -2194,7 +2195,7 @@ of the two is enforced.
>  
>  cgroup writeback requires explicit support from the underlying
>  filesystem.  Currently, cgroup writeback is implemented on ext2, ext4,
> -btrfs, f2fs, and xfs.  On other filesystems, all writeback IOs are 
> +btrfs, f2fs, and xfs.  On other filesystems, all writeback IOs are
>  attributed to the root cgroup.
>  
>  There are inherent differences in memory and writeback management

Re: [PATCH 2/5] Documentation: admin-guide: fix trailing whitespace in cgroup-v2.rst

[Randy Dunlap]

On 7/18/26 9:14 AM, Weijie Yuan wrote:
> On Sat, Jul 18, 2026 at 04:19:08PM +0100, Yahya Toubali wrote:
>> Remove trailing spaces on lines 1335 and 2197.
>>
>> Signed-off-by: Yahya Toubali <yahya@yahyatoubali.me>
> 
> Hmmm, for a file that might be modified, I wonder if it makes sense to
> include fixed line numbers in the commit message. i.e. When the line
> number changes, your commit message will become meaningless.
> 
> I'd love to hear others' comments.

I wouldn't include the line numbers...

>> ---
>>  Documentation/admin-guide/cgroup-v2.rst | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
>> index 14b8c571c0d1..f15a613fed6a 100644
>> --- a/Documentation/admin-guide/cgroup-v2.rst
>> +++ b/Documentation/admin-guide/cgroup-v2.rst
>> @@ -1,4 +1,5 @@
>>  .. _cgroup-v2:
>> +.. SPDX-License-Identifier: GPL-2.0
>>  
>>  ================
>>  Control Group v2
>> @@ -1332,7 +1333,7 @@ PAGE_SIZE multiple when read back.
>>  	cgroup is within its effective low boundary, the cgroup's
>>  	memory won't be reclaimed unless there is no reclaimable
>>  	memory available in unprotected cgroups.
>> -	Above the effective low	boundary (or 
>> +	Above the effective low	boundary (or
>>  	effective min boundary if it is higher), pages are reclaimed
>>  	proportionally to the overage, reducing reclaim pressure for
>>  	smaller overages.
>> @@ -2194,7 +2195,7 @@ of the two is enforced.
>>  
>>  cgroup writeback requires explicit support from the underlying
>>  filesystem.  Currently, cgroup writeback is implemented on ext2, ext4,
>> -btrfs, f2fs, and xfs.  On other filesystems, all writeback IOs are 
>> +btrfs, f2fs, and xfs.  On other filesystems, all writeback IOs are
>>  attributed to the root cgroup.
>>  
>>  There are inherent differences in memory and writeback management
> 

-- 
~Randy

Re: [PATCH 2/5] Documentation: admin-guide: fix trailing whitespace in cgroup-v2.rst

[Weijie Yuan]

On Sat, Jul 18, 2026 at 09:16:29AM -0700, Randy Dunlap wrote:
> 
> 
> On 7/18/26 9:14 AM, Weijie Yuan wrote:
> > On Sat, Jul 18, 2026 at 04:19:08PM +0100, Yahya Toubali wrote:
> >> Remove trailing spaces on lines 1335 and 2197.
> >>
> >> Signed-off-by: Yahya Toubali <yahya@yahyatoubali.me>
> > 
> > Hmmm, for a file that might be modified, I wonder if it makes sense to
> > include fixed line numbers in the commit message. i.e. When the line
> > number changes, your commit message will become meaningless.
> > 
> > I'd love to hear others' comments.
> 
> I wouldn't include the line numbers...

Alright, it seems that Yahya needs to refine his commit message.

Thanks.

[PATCH v3] Documentation: admin-guide: fix trailing whitespace in cgroup-v2.rst

[Yahya Toubali]

Remove trailing whitespace flagged by checkpatch.pl in the cgroup
memory and writeback sections.

Signed-off-by: Yahya Toubali <yahya@yahyatoubali.me>
---
 Documentation/admin-guide/cgroup-v2.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
index 14b8c571c0d1..481658cfef40 100644
--- a/Documentation/admin-guide/cgroup-v2.rst
+++ b/Documentation/admin-guide/cgroup-v2.rst
@@ -1332,7 +1332,7 @@ PAGE_SIZE multiple when read back.
 	cgroup is within its effective low boundary, the cgroup's
 	memory won't be reclaimed unless there is no reclaimable
 	memory available in unprotected cgroups.
-	Above the effective low	boundary (or 
+	Above the effective low	boundary (or
 	effective min boundary if it is higher), pages are reclaimed
 	proportionally to the overage, reducing reclaim pressure for
 	smaller overages.
@@ -2194,7 +2194,7 @@ of the two is enforced.
 
 cgroup writeback requires explicit support from the underlying
 filesystem.  Currently, cgroup writeback is implemented on ext2, ext4,
-btrfs, f2fs, and xfs.  On other filesystems, all writeback IOs are 
+btrfs, f2fs, and xfs.  On other filesystems, all writeback IOs are
 attributed to the root cgroup.
 
 There are inherent differences in memory and writeback management

base-commit: 1229e2e57a5c2980ccd457b9b53ea0eed5a22ab3
prerequisite-patch-id: c8aee5eb39e3cd6f2b2f28c82163565665288d2a
-- 
2.55.0

Re: [PATCH v3] Documentation: admin-guide: fix trailing whitespace in cgroup-v2.rst

[Randy Dunlap]

On 7/18/26 9:56 AM, Yahya Toubali wrote:
> Remove trailing whitespace flagged by checkpatch.pl in the cgroup
> memory and writeback sections.
> 
> Signed-off-by: Yahya Toubali <yahya@yahyatoubali.me>
> ---
>  Documentation/admin-guide/cgroup-v2.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 14b8c571c0d1..481658cfef40 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1332,7 +1332,7 @@ PAGE_SIZE multiple when read back.
>  	cgroup is within its effective low boundary, the cgroup's
>  	memory won't be reclaimed unless there is no reclaimable
>  	memory available in unprotected cgroups.
> -	Above the effective low	boundary (or 
> +	Above the effective low	boundary (or
>  	effective min boundary if it is higher), pages are reclaimed
>  	proportionally to the overage, reducing reclaim pressure for
>  	smaller overages.
> @@ -2194,7 +2194,7 @@ of the two is enforced.
>  
>  cgroup writeback requires explicit support from the underlying
>  filesystem.  Currently, cgroup writeback is implemented on ext2, ext4,
> -btrfs, f2fs, and xfs.  On other filesystems, all writeback IOs are 
> +btrfs, f2fs, and xfs.  On other filesystems, all writeback IOs are
>  attributed to the root cgroup.
>  
>  There are inherent differences in memory and writeback management
> 
> base-commit: 1229e2e57a5c2980ccd457b9b53ea0eed5a22ab3
> prerequisite-patch-id: c8aee5eb39e3cd6f2b2f28c82163565665288d2a

From Documentation/process/submitting-patches.rst: (paraphrased)

Don't reply to v2 of a patch with v3 of that patch. We prefer that new/fresh
patches begin their own email thread.

thanks.
-- 
~Randy

Re: [PATCH 2/5] Documentation: admin-guide: fix trailing whitespace in cgroup-v2.rst

[Jonathan Corbet]

Weijie Yuan <wy@wyuan.org> writes:

> On Sat, Jul 18, 2026 at 04:19:08PM +0100, Yahya Toubali wrote:
>> Remove trailing spaces on lines 1335 and 2197.
>> 
>> Signed-off-by: Yahya Toubali <yahya@yahyatoubali.me>
>
> Hmmm, for a file that might be modified, I wonder if it makes sense to
> include fixed line numbers in the commit message. i.e. When the line
> number changes, your commit message will become meaningless.
>
> I'd love to hear others' comments.

Honestly, I question the value of churning the files for a couple of
trailing blanks in the first place.  There are *so many* ways in which
our documentation can be improved, and this doesn't approach any of
them.

Thanks,

jon

Re: [PATCH 2/5] Documentation: admin-guide: fix trailing whitespace in cgroup-v2.rst

[Weijie Yuan]

On Sun, Jul 19, 2026 at 10:44:52AM -0600, Jonathan Corbet wrote:
> Weijie Yuan <wy@wyuan.org> writes:
> 
> > On Sat, Jul 18, 2026 at 04:19:08PM +0100, Yahya Toubali wrote:
> >> Remove trailing spaces on lines 1335 and 2197.
> >> 
> >> Signed-off-by: Yahya Toubali <yahya@yahyatoubali.me>
> >
> > Hmmm, for a file that might be modified, I wonder if it makes sense to
> > include fixed line numbers in the commit message. i.e. When the line
> > number changes, your commit message will become meaningless.
> >
> > I'd love to hear others' comments.
> 
> Honestly, I question the value of churning the files for a couple of
> trailing blanks in the first place.  There are *so many* ways in which
> our documentation can be improved, and this doesn't approach any of
> them.

Yeah, exactly. I even spent some time comparing letter by letter to
figure out exactly where the changes were made, because I didn't
initially read the commit message. ;-)

But I recalled Greg KH's classic email as I've checked this is Yahya's
first contribution known on the list.

  https://lwn.net/Articles/658231/

So I was like, okay, first time, let's understand and be inclusive. And
apparently he (or any other pronouns if you prefer) was trying to figure
out how to send his patches out correctly. (I noticed that before this,
his first version of the patches did not even form a series.)

So hopefully Yahya could get familiar with the process soon and start to
make more useful contributions as Jon expected.

But as for whether to accept this or not, I'm afraid I have no answers
or suggestions. (Naturally, there is no authority either.) While
objectively speaking, this patch is indeed rather embarrassing. It's up
to you Jon ;-)

Thanks,
Weijie