Re: [PATCH] platform/chrome: chromeos_acpi: print hex string for ACPI_TYPE_BUFFER

[Tzung-Bi Shih <tzungbi@kernel.org>]

On Wed, Jul 26, 2023 at 03:31:27PM +0800, Tzung-Bi Shih wrote:
> `element->buffer.pointer` should be binary blob.  `%s` doesn't work perfect
> for them.
> 
> Print hex string for ACPI_TYPE_BUFFER.
> 
> Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>

Curious about does this patch make sense to folks on the mailing list?

> ---
>  drivers/platform/chrome/chromeos_acpi.c | 20 +++++++++++++++++++-
>  1 file changed, 19 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/chrome/chromeos_acpi.c b/drivers/platform/chrome/chromeos_acpi.c
> index 50d8a4d4352d..a60d344c54e4 100644
> --- a/drivers/platform/chrome/chromeos_acpi.c
> +++ b/drivers/platform/chrome/chromeos_acpi.c
> @@ -90,7 +90,25 @@ static int chromeos_acpi_handle_package(struct device *dev, union acpi_object *o
>  	case ACPI_TYPE_STRING:
>  		return sysfs_emit(buf, "%s\n", element->string.pointer);
>  	case ACPI_TYPE_BUFFER:
> -		return sysfs_emit(buf, "%s\n", element->buffer.pointer);
> +		{
> +			int i, n;
> +			const int char_per_line = 16;
> +
> +			for (i = 0, n = 0; i < element->buffer.length; ++i) {
> +				n += sysfs_emit_at(buf, n, " %2.2x", element->buffer.pointer[i]);
> +
> +				if (((i + 1) % char_per_line) == 0)
> +					n += sysfs_emit_at(buf, n, "\n");
> +			}
> +			n += sysfs_emit_at(buf, n, "\n");
> +
> +			if (n == PAGE_SIZE - 1) {
> +				dev_info(dev, "truncating sysfs content for %s\n", name);
> +				sysfs_emit_at(buf, n - 3, "..\n");
> +			}
> +
> +			return n;
> +		}
>  	default:
>  		dev_err(dev, "element type %d not supported\n", element->type);
>  		return -EINVAL;
> -- 
> 2.41.0.487.g6d72f3e995-goog
>