Re: [PATCH] platform/chrome: chromeos_acpi: print hex string for ACPI_TYPE_BUFFER

[Brian Norris <briannorris@chromium.org>]

On Wed, Aug 02, 2023 at 06:06:30PM +0800, Tzung-Bi Shih wrote:
> On Tue, Aug 01, 2023 at 02:53:31PM -0700, Brian Norris wrote:
> > NB: the docs (Documentation/ABI/testing/sysfs-driver-chromeos-acpi)
> > suggest that some attributes (like VDAT) are indeed binary, and so we
> > should probably maintain or fix that.
> 
> No.  Unless we also want to change userland program in [2].

I mean, I think you need to do one of those two -- either keep this
(maintain) as "binary", or update (fix) the doc to describe the hex dump
instead.

i.e., I think this piece of
Documentation/ABI/testing/sysfs-driver-chromeos-acpi is now wrong:

What:           /sys/bus/platform/devices/GGL0001:*/VDAT
Date:           May 2022
KernelVersion:  5.19
Description:
                Returns the verified boot data block shared between the
                firmware verification step and the kernel verification step
                (binary).

But, the userland program already doesn't know how to handle the
upstream driver. So it'd be possible to change both at the same time.

Anyway, hex-encoded is fine with me too; we just need to get the docs to
match.

Regards,
Brian