Re: [PATCH] platform/chrome: chromeos_acpi: print hex string for ACPI_TYPE_BUFFER

[Tzung-Bi Shih <tzungbi@kernel.org>]

On Tue, Aug 01, 2023 at 02:53:31PM -0700, Brian Norris wrote:
> Are there any ABI concerns here? As in, did this perhaps work for some
> use cases that will be broken now by this change in format? If not, it
> would be nice to note your thought process on that. [1]

There is an existing use case from userland program[2].  It works with
downstream chromeos_acpi driver but not the upstream one.

[2]: https://crrev.com/48a12071a43813e5bf0694f99e4024468ea900b6/host/arch/x86/lib/crossystem_arch.c#232

> Also, is it possible to use some standard formatting, like
> hex_dump_to_buffer()?

Ack, fix in v2[3].

[3]: https://patchwork.kernel.org/project/chrome-platform/patch/20230802095736.3079963-1-tzungbi@kernel.org/

> Or, would it make more sense to make these into binary attributes
> (struct bin_attribute)?
> 
> NB: the docs (Documentation/ABI/testing/sysfs-driver-chromeos-acpi)
> suggest that some attributes (like VDAT) are indeed binary, and so we
> should probably maintain or fix that.

No.  Unless we also want to change userland program in [2].

> [1] My guess: no real user space actually uses this driver yet, since
> ChromiumOS still has its own downstream variant on its active kernels?

Correct, AFAIK, there has no use cases for the upstream chromeos_acpi driver
yet.