From: Ulrich Hecht <uli@fpond.eu>
To: Pavel Machek <pavel@nabladev.com>
Cc: "cip-dev@lists.cip-project.org" <cip-dev@lists.cip-project.org>,
"nobuhiro.iwamatsu.x90@mail.toshiba"
<nobuhiro.iwamatsu.x90@mail.toshiba>
Subject: Re: Request for review for 4.19-st21, 4.19-cip137
Date: Tue, 3 Nov 2026 10:22:02 +0100 (CET) [thread overview]
Message-ID: <1099989158.146013.1793697722731@webmail.strato.de> (raw)
In-Reply-To: <auh1sRkdmg3AWRbt@duo.ucw.cz>
> On 11/02/2026 12:36 PM CET Pavel Machek <pavel@nabladev.com> wrote:
> These look ok to me:
>
> Reviewed-by: Pavel Machek <pavel@nabladev.com>
Thanks. Here's a last-minute addition:
09c9317a392321 ipv4: free inet_opt and ireq_opt after an RCU grace period
> > a91fd56ecf47a4 gpio: zynq: fix runtime PM leak on request error path
>
> So this is common pattern and quite a common mistake. As it only
> happens in error paths, we may want to simply ignore this one.
ATM the triage rule "fixes a minor resource leak, for instance during initialization or deinitialization of a device" is listed under "backported at the maintainer's discretion" (which in practice means it goes in unless it looks like a regression risk to me). I guess I can move that to "must not be backported".
CU
Uli
next prev parent reply other threads:[~2026-11-03 9:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 20:23 Request for review for 4.19-st21, 4.19-cip137 Ulrich Hecht
2026-11-02 11:36 ` Pavel Machek
2026-11-03 9:22 ` Ulrich Hecht [this message]
2026-11-05 19:07 ` Pavel Machek
2026-11-06 10:03 ` Pavel Machek
2026-11-09 16:49 ` [cip-dev] " Ulrich Hecht
2026-11-10 21:27 ` Pavel Machek
2026-11-12 10:53 ` Ulrich Hecht
2026-11-11 21:15 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1099989158.146013.1793697722731@webmail.strato.de \
--to=uli@fpond.eu \
--cc=cip-dev@lists.cip-project.org \
--cc=nobuhiro.iwamatsu.x90@mail.toshiba \
--cc=pavel@nabladev.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox