Re: Request for review for 4.19-st21, 4.19-cip137

[Pavel Machek <pavel@nabladev.com>]

[-- Attachment #1: Type: text/plain, Size: 1578 bytes --]

Hi!

> 
> Here are the adapted backports for the upcoming 4.19 kernel release. There's a total of 95; 1 written by me, 2 by Qwen-3.8-27B and 92 by Qwen-3.8-Flash-Next. (The latter are labeled with "Assisted-by: SLTR:qwen-3.8" and "Assisted-by: SLTR:qwen-3.8-flash-next", respectively.)
> 
> As always they can be found in https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linux-4.19.y-st-rc
>

These look ok to me:

Reviewed-by: Pavel Machek <pavel@nabladev.com>

a this is not easy to validate > 0f9dd2fd36dc88 ipv4: validate checksum_start before completing checksum
a > 1aef1ed67bf592 netfilter: ip6t_rt: fix zero-address non-strict match out-of-bounds read
a > 1772d2f27fe10f net: openvswitch: conntrack: avoid modifying shared unconfirmed ct entry
a > 994be280b21cd2 net/sched: reject IDR error pointers when deleting actions
a > 2548133fd1bde9 drm/nouveau: Fix gem reference leak in validate_init()
a > 893066ca3560ef drm/nouveau: fix double-free in nvif_vmm_dtor
> a91fd56ecf47a4 gpio: zynq: fix runtime PM leak on request error path

So this is common pattern and quite a common mistake. As it only
happens in error paths, we may want to simply ignore this one.

If we wanted this fixed, we should probably introduce
pm_runtime_resume_and_get(). We already have two users of the
non-existing function in the tree, so two compile errors waiting to happen.

drivers/irqchip/irq-gic-pm.c:   ret = pm_runtime_resume_and_get(dev);
sound/ac97/bus.c:       ret = pm_runtime_resume_and_get(dev);

Best regards,
								Pavel

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]