Re: Request for review for 4.19-st21, 4.19-cip137

[Pavel Machek <pavel@nabladev.com>]

[-- Attachment #1: Type: text/plain, Size: 2471 bytes --]

Hi!

> Here are the adapted backports for the upcoming 4.19 kernel release. There's a total of 95; 1 written by me, 2 by Qwen-3.8-27B and 92 by Qwen-3.8-Flash-Next. (The latter are labeled with "Assisted-by: SLTR:qwen-3.8" and "Assisted-by: SLTR:qwen-3.8-flash-next", respectively.)
> 
> As always they can be found in https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linux-4.19.y-st-rc
>

Some patches are ok, Reviewed-by: Pavel Machek
<pavel@nabladev.com>. There are some comments below.

e37dae2a4576c5, for example. That was an obvious two-liner, but it is
quite significant locking redone after backport. I'm afraid this
should get specific testing.

cbf63e3778be51 is example of different problem. That rmmod path is
likely seriously broken in 4.19-st20. That's why it got redesign in
mainline. It is still broken in 4.19-st21, that barrier won't fix it
with nf_flow_table_module_exit() missing. Nobody should unload modules
in production, and this risks regressions.

b9027a1c10a535 got minor comment.

Best regards,
								Pavel


a > b78ecf68a5560d ipv6: sr: enforce exact attribute length for SEG6_ATTR_DST
a > 28db7b5b3dfc9c ipv6: do not let ipv6_find_hdr() return an offset past the packet end
a > 59c0dbc48ea5e9 af_packet: fix integer overflow in prb_calc_retire_blk_tmo()
> 7582eb829827dd drm/virtio: fix object leak in virtio_gpu_resource_create_ioctl()
> 5fc852076e0f08 drm/virtio: fix object leak when drm_gem_handle_create() fails
a > a27a4884b8c4af ipvs: revalidate ihl before icmp_send
a > 88588102ee3ad2 bpf: Fix out-of-bounds read of rtt_min in sock_ops
!! it probably does not matter, but we should do release consistently
before or after pm. I guess before. > b9027a1c10a535 i2c: at91: release DMA channels on remove and probe error
a just a robustness against CAP_NET_ADMIN > 3975c809ff001e net/sched: hhf: cap hh_flows_limit at change time
!! dunno, two liner becomes quite complex > e37dae2a4576c5 net: lock the socket in sock_gettstamp()
a> e1333865998044 tcp: do not let tcp_rmem be set below 4096
> ffc922c95d046b drm: Fix drm_pending_vblank_event leak in error path for out_fence_ptr
!! are you sure this is applicable? > cbf63e3778be51 netfilter: flowtable: hold reference on ct until flow is released
a > 2f3223465d9893 dma-coherent: report a failed reserved memory assignment
a > cbb22c9ad14604 iomap: iomap: fix memory corruption when recording errors during writeback

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]