Re: [PATCH 6.12.y-cip 5/8] memory: renesas-rpc-if: Add suspend/resume support

[Pavel Machek <pavel@nabladev.com>]

[-- Attachment #1: Type: text/plain, Size: 1515 bytes --]

Hi!

> From: Biju Das <biju.das.jz@bp.renesas.com>

> On RZ/G3E using PSCI, s2ram powers down the SoC. Add suspend/resume
> callbacks to control spi/spix2 clocks.

...
> +++ b/drivers/memory/renesas-rpc-if.c
> @@ -1024,19 +1026,15 @@ static int rpcif_probe(struct platform_device *pdev)
>  	 * flash write failure. So, enable these clocks during probe() and
>  	 * disable it in remove().
>  	 */
> -	if (rpc->info->type == XSPI_RZ_G3E) {
> -		struct clk *spi_clk;
> -
> -		spi_clk = devm_clk_get_enabled(dev, "spix2");
> -		if (IS_ERR(spi_clk))
> -			return dev_err_probe(dev, PTR_ERR(spi_clk),
> -					     "cannot get enabled spix2 clk\n");
> -
> -		spi_clk = devm_clk_get_enabled(dev, "spi");
> -		if (IS_ERR(spi_clk))
> -			return dev_err_probe(dev, PTR_ERR(spi_clk),
> -					     "cannot get enabled spi clk\n");
> -	}
> +	rpc->spix2_clk = devm_clk_get_optional_enabled(dev, "spix2");
> +	if (IS_ERR(rpc->spix2_clk))
> +		return dev_err_probe(dev, PTR_ERR(rpc->spix2_clk),
> +				     "cannot get enabled spix2 clk\n");
> +
> +	rpc->spi_clk = devm_clk_get_optional_enabled(dev, "spi");
> +	if (IS_ERR(rpc->spi_clk))
> +		return dev_err_probe(dev, PTR_ERR(rpc->spi_clk),
> +				     "cannot get enabled spi clk\n");
>  
>  	vdev = platform_device_alloc(name, PLATFORM_DEVID_AUTO);
>  	if (!vdev)

This change is not exmplained in the changelog, and it does not look
related to suspend. I guess it is too late to do anything with it now.

Best regards,
								Pavel

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]