* [PATCH 6.1.y-cip 01/11] irqchip/renesas-rzv2h: Fix error path in rzv2h_icu_probe_common()
2026-09-02 9:23 [PATCH 6.1.y-cip 00/11] Add ICU error and software interrupt support for RZ/V2H and RZ/V2N Ovidiu Panait
@ 2026-09-02 9:23 ` Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 02/11] irqchip/renesas-rzv2h: Use local node pointer Ovidiu Panait
` (11 subsequent siblings)
12 siblings, 0 replies; 16+ messages in thread
From: Ovidiu Panait @ 2026-09-02 9:23 UTC (permalink / raw)
To: cip-dev, pavel, nobuhiro.iwamatsu.x90
From: Biju Das <biju.das.jz@bp.renesas.com>
commit 897cf98926429c8671a9009442883c2f62deae96 upstream.
Replace pm_runtime_put() with pm_runtime_put_sync() when
irq_domain_create_hierarchy() fails to ensure the device suspends
synchronously before devres cleanup disables runtime PM via
pm_runtime_disable().
Fixes: 5ec8cabc3b86 ("irqchip/renesas-rzv2h: Use devm_pm_runtime_enable()")
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Link: https://patch.msgid.link/20260323124917.41602-1-biju.das.jz@bp.renesas.com
[OP: fixed minor context difference]
Signed-off-by: Ovidiu Panait <ovidiu.panait.rb@renesas.com>
---
drivers/irqchip/irq-renesas-rzv2h.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-renesas-rzv2h.c b/drivers/irqchip/irq-renesas-rzv2h.c
index dfbe563a3b25..0a852b6c3f44 100644
--- a/drivers/irqchip/irq-renesas-rzv2h.c
+++ b/drivers/irqchip/irq-renesas-rzv2h.c
@@ -630,7 +630,7 @@ static int rzv2h_icu_init_common(struct device_node *node, struct device_node *p
return 0;
pm_put:
- pm_runtime_put(&pdev->dev);
+ pm_runtime_put_sync(&pdev->dev);
pm_disable:
pm_runtime_disable(&pdev->dev);
reset_control_assert(resetn);
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 6.1.y-cip 02/11] irqchip/renesas-rzv2h: Use local node pointer
2026-09-02 9:23 [PATCH 6.1.y-cip 00/11] Add ICU error and software interrupt support for RZ/V2H and RZ/V2N Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 01/11] irqchip/renesas-rzv2h: Fix error path in rzv2h_icu_probe_common() Ovidiu Panait
@ 2026-09-02 9:23 ` Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 03/11] irqchip/renesas-rzv2h: Use local device pointer in ICU probe Ovidiu Panait
` (10 subsequent siblings)
12 siblings, 0 replies; 16+ messages in thread
From: Ovidiu Panait @ 2026-09-02 9:23 UTC (permalink / raw)
To: cip-dev, pavel, nobuhiro.iwamatsu.x90
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
commit 9fcd9ffe94da4a34a451e4cc0e3e007b4ed7f114 upstream.
Avoid dereferencing pdev->dev.of_node again in rzv2h_icu_probe_common().
Reuse the already available local node pointer when mapping the ICU
register space.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Link: https://patch.msgid.link/20260304113317.129339-2-prabhakar.mahadev-lad.rj@bp.renesas.com
Signed-off-by: Ovidiu Panait <ovidiu.panait.rb@renesas.com>
---
drivers/irqchip/irq-renesas-rzv2h.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-renesas-rzv2h.c b/drivers/irqchip/irq-renesas-rzv2h.c
index 0a852b6c3f44..e599ac398237 100644
--- a/drivers/irqchip/irq-renesas-rzv2h.c
+++ b/drivers/irqchip/irq-renesas-rzv2h.c
@@ -582,7 +582,7 @@ static int rzv2h_icu_init_common(struct device_node *node, struct device_node *p
platform_set_drvdata(pdev, rzv2h_icu_data);
- rzv2h_icu_data->base = devm_of_iomap(&pdev->dev, pdev->dev.of_node, 0, NULL);
+ rzv2h_icu_data->base = devm_of_iomap(&pdev->dev, node, 0, NULL);
if (IS_ERR(rzv2h_icu_data->base))
return PTR_ERR(rzv2h_icu_data->base);
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 6.1.y-cip 03/11] irqchip/renesas-rzv2h: Use local device pointer in ICU probe
2026-09-02 9:23 [PATCH 6.1.y-cip 00/11] Add ICU error and software interrupt support for RZ/V2H and RZ/V2N Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 01/11] irqchip/renesas-rzv2h: Fix error path in rzv2h_icu_probe_common() Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 02/11] irqchip/renesas-rzv2h: Use local node pointer Ovidiu Panait
@ 2026-09-02 9:23 ` Ovidiu Panait
2026-09-02 16:57 ` Pavel Machek
2026-09-02 9:23 ` [PATCH 6.1.y-cip 04/11] irqchip/renesas-rzv2h: Switch to using dev_err_probe() Ovidiu Panait
` (9 subsequent siblings)
12 siblings, 1 reply; 16+ messages in thread
From: Ovidiu Panait @ 2026-09-02 9:23 UTC (permalink / raw)
To: cip-dev, pavel, nobuhiro.iwamatsu.x90
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
commit bbe78cb1399b4ba6b6d14943fb9dadefe9c17b5b upstream.
Use a local struct device pointer in rzv2h_icu_probe_common() to avoid
repeated dereferencing of pdev->dev.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Link: https://patch.msgid.link/20260304113317.129339-3-prabhakar.mahadev-lad.rj@bp.renesas.com
[OP:
- applied changes in rzv2h_icu_init_common(), as upstream commit
1e3e330c0707 ("irqchip: Pass platform device to platform drivers") is
not present in 6.1 CIP
- dropped the dev_fwnode() hunk, as commit affdc0d1bdfa ("irqchip: Switch
to irq_domain_create_*()") is not present either
- adjusted for differences in error handling in 6.1 CIP]
Signed-off-by: Ovidiu Panait <ovidiu.panait.rb@renesas.com>
---
drivers/irqchip/irq-renesas-rzv2h.c | 32 +++++++++++++++--------------
1 file changed, 17 insertions(+), 15 deletions(-)
diff --git a/drivers/irqchip/irq-renesas-rzv2h.c b/drivers/irqchip/irq-renesas-rzv2h.c
index e599ac398237..f0a3cd07bb6c 100644
--- a/drivers/irqchip/irq-renesas-rzv2h.c
+++ b/drivers/irqchip/irq-renesas-rzv2h.c
@@ -559,53 +559,55 @@ static int rzv2h_icu_init_common(struct device_node *node, struct device_node *p
struct irq_domain *irq_domain, *parent_domain;
struct platform_device *pdev;
struct reset_control *resetn;
+ struct device *dev;
int ret;
pdev = of_find_device_by_node(node);
if (!pdev)
return -ENODEV;
- ret = devm_add_action_or_reset(&pdev->dev, rzv2h_icu_put_device,
- &pdev->dev);
+ dev = &pdev->dev;
+
+ ret = devm_add_action_or_reset(dev, rzv2h_icu_put_device, dev);
if (ret < 0)
return ret;
parent_domain = irq_find_host(parent);
if (!parent_domain) {
- dev_err(&pdev->dev, "cannot find parent domain\n");
+ dev_err(dev, "cannot find parent domain\n");
return -ENODEV;
}
- rzv2h_icu_data = devm_kzalloc(&pdev->dev, sizeof(*rzv2h_icu_data), GFP_KERNEL);
+ rzv2h_icu_data = devm_kzalloc(dev, sizeof(*rzv2h_icu_data), GFP_KERNEL);
if (!rzv2h_icu_data)
return -ENOMEM;
platform_set_drvdata(pdev, rzv2h_icu_data);
- rzv2h_icu_data->base = devm_of_iomap(&pdev->dev, node, 0, NULL);
+ rzv2h_icu_data->base = devm_of_iomap(dev, node, 0, NULL);
if (IS_ERR(rzv2h_icu_data->base))
return PTR_ERR(rzv2h_icu_data->base);
ret = rzv2h_icu_parse_interrupts(rzv2h_icu_data, node);
if (ret) {
- dev_err(&pdev->dev, "cannot parse interrupts: %d\n", ret);
+ dev_err(dev, "cannot parse interrupts: %d\n", ret);
return ret;
}
- resetn = devm_reset_control_get_exclusive(&pdev->dev, NULL);
+ resetn = devm_reset_control_get_exclusive(dev, NULL);
if (IS_ERR(resetn))
return PTR_ERR(resetn);
ret = reset_control_deassert(resetn);
if (ret) {
- dev_err(&pdev->dev, "failed to deassert resetn pin, %d\n", ret);
+ dev_err(dev, "failed to deassert resetn pin, %d\n", ret);
return ret;
}
- pm_runtime_enable(&pdev->dev);
- ret = pm_runtime_resume_and_get(&pdev->dev);
+ pm_runtime_enable(dev);
+ ret = pm_runtime_resume_and_get(dev);
if (ret < 0) {
- dev_err(&pdev->dev, "pm_runtime_resume_and_get failed: %d\n", ret);
+ dev_err(dev, "pm_runtime_resume_and_get failed: %d\n", ret);
goto pm_disable;
}
@@ -614,7 +616,7 @@ static int rzv2h_icu_init_common(struct device_node *node, struct device_node *p
irq_domain = irq_domain_add_hierarchy(parent_domain, 0, ICU_NUM_IRQ, node,
&rzv2h_icu_domain_ops, rzv2h_icu_data);
if (!irq_domain) {
- dev_err(&pdev->dev, "failed to add irq domain\n");
+ dev_err(dev, "failed to add irq domain\n");
ret = -ENOMEM;
goto pm_put;
}
@@ -625,14 +627,14 @@ static int rzv2h_icu_init_common(struct device_node *node, struct device_node *p
/*
* coccicheck complains about a missing put_device call before returning, but it's a false
- * positive. We still need &pdev->dev after successfully returning from this function.
+ * positive. We still need dev after successfully returning from this function.
*/
return 0;
pm_put:
- pm_runtime_put_sync(&pdev->dev);
+ pm_runtime_put_sync(dev);
pm_disable:
- pm_runtime_disable(&pdev->dev);
+ pm_runtime_disable(dev);
reset_control_assert(resetn);
return ret;
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 6.1.y-cip 03/11] irqchip/renesas-rzv2h: Use local device pointer in ICU probe
2026-09-02 9:23 ` [PATCH 6.1.y-cip 03/11] irqchip/renesas-rzv2h: Use local device pointer in ICU probe Ovidiu Panait
@ 2026-09-02 16:57 ` Pavel Machek
0 siblings, 0 replies; 16+ messages in thread
From: Pavel Machek @ 2026-09-02 16:57 UTC (permalink / raw)
To: Ovidiu Panait; +Cc: cip-dev, pavel, nobuhiro.iwamatsu.x90
[-- Attachment #1: Type: text/plain, Size: 964 bytes --]
Hi!
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> commit bbe78cb1399b4ba6b6d14943fb9dadefe9c17b5b upstream.
>
> Use a local struct device pointer in rzv2h_icu_probe_common() to avoid
> repeated dereferencing of pdev->dev.
>
> --- a/drivers/irqchip/irq-renesas-rzv2h.c
> +++ b/drivers/irqchip/irq-renesas-rzv2h.c
> @@ -625,14 +627,14 @@ static int rzv2h_icu_init_common(struct device_node *node, struct device_node *p
>
> /*
> * coccicheck complains about a missing put_device call before returning, but it's a false
> - * positive. We still need &pdev->dev after successfully returning from this function.
> + * positive. We still need dev after successfully returning from this function.
> */
> return 0;
I believe the search and replace went too far here. For reader,
original comment was more useful. But maybe it should say in english
what device we actually need.
Best regards,
Pavel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 6.1.y-cip 04/11] irqchip/renesas-rzv2h: Switch to using dev_err_probe()
2026-09-02 9:23 [PATCH 6.1.y-cip 00/11] Add ICU error and software interrupt support for RZ/V2H and RZ/V2N Ovidiu Panait
` (2 preceding siblings ...)
2026-09-02 9:23 ` [PATCH 6.1.y-cip 03/11] irqchip/renesas-rzv2h: Use local device pointer in ICU probe Ovidiu Panait
@ 2026-09-02 9:23 ` Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 05/11] irqchip/renesas-rzv2h: Clarify IRQ range definitions and tighten TINT validation Ovidiu Panait
` (8 subsequent siblings)
12 siblings, 0 replies; 16+ messages in thread
From: Ovidiu Panait @ 2026-09-02 9:23 UTC (permalink / raw)
To: cip-dev, pavel, nobuhiro.iwamatsu.x90
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
commit c34368b0404b8fd610b4f589481a1339bab76e0f upstream.
Make use of dev_err_probe() to simplify rzv2h_icu_probe_common().
Keep dev_err() for -ENOMEM paths, as dev_err_probe() does not print for
allocation failures, ensuring they remain visible in logs.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Link: https://patch.msgid.link/20260304113317.129339-4-prabhakar.mahadev-lad.rj@bp.renesas.com
[OP: adjusted for the different error paths in 6.1, which lacks upstream
commits ad773ebc6e41 ("irqchip/renesas-rzv2h: Use
devm_reset_control_get_exclusive_deasserted()") and 5ec8cabc3b86
("irqchip/renesas-rzv2h: Use devm_pm_runtime_enable()")]
Signed-off-by: Ovidiu Panait <ovidiu.panait.rb@renesas.com>
---
drivers/irqchip/irq-renesas-rzv2h.c | 20 +++++++-------------
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/drivers/irqchip/irq-renesas-rzv2h.c b/drivers/irqchip/irq-renesas-rzv2h.c
index f0a3cd07bb6c..3898ec70462a 100644
--- a/drivers/irqchip/irq-renesas-rzv2h.c
+++ b/drivers/irqchip/irq-renesas-rzv2h.c
@@ -573,10 +573,8 @@ static int rzv2h_icu_init_common(struct device_node *node, struct device_node *p
return ret;
parent_domain = irq_find_host(parent);
- if (!parent_domain) {
- dev_err(dev, "cannot find parent domain\n");
- return -ENODEV;
- }
+ if (!parent_domain)
+ return dev_err_probe(dev, -ENODEV, "cannot find parent domain\n");
rzv2h_icu_data = devm_kzalloc(dev, sizeof(*rzv2h_icu_data), GFP_KERNEL);
if (!rzv2h_icu_data)
@@ -589,25 +587,21 @@ static int rzv2h_icu_init_common(struct device_node *node, struct device_node *p
return PTR_ERR(rzv2h_icu_data->base);
ret = rzv2h_icu_parse_interrupts(rzv2h_icu_data, node);
- if (ret) {
- dev_err(dev, "cannot parse interrupts: %d\n", ret);
- return ret;
- }
+ if (ret)
+ return dev_err_probe(dev, ret, "cannot parse interrupts\n");
resetn = devm_reset_control_get_exclusive(dev, NULL);
if (IS_ERR(resetn))
return PTR_ERR(resetn);
ret = reset_control_deassert(resetn);
- if (ret) {
- dev_err(dev, "failed to deassert resetn pin, %d\n", ret);
- return ret;
- }
+ if (ret)
+ return dev_err_probe(dev, ret, "failed to deassert resetn pin\n");
pm_runtime_enable(dev);
ret = pm_runtime_resume_and_get(dev);
if (ret < 0) {
- dev_err(dev, "pm_runtime_resume_and_get failed: %d\n", ret);
+ dev_err_probe(dev, ret, "pm_runtime_resume_and_get failed\n");
goto pm_disable;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 6.1.y-cip 05/11] irqchip/renesas-rzv2h: Clarify IRQ range definitions and tighten TINT validation
2026-09-02 9:23 [PATCH 6.1.y-cip 00/11] Add ICU error and software interrupt support for RZ/V2H and RZ/V2N Ovidiu Panait
` (3 preceding siblings ...)
2026-09-02 9:23 ` [PATCH 6.1.y-cip 04/11] irqchip/renesas-rzv2h: Switch to using dev_err_probe() Ovidiu Panait
@ 2026-09-02 9:23 ` Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 06/11] irqchip/renesas-rzv2h: Replace single irq_chip with per-region irq_chip instances Ovidiu Panait
` (7 subsequent siblings)
12 siblings, 0 replies; 16+ messages in thread
From: Ovidiu Panait @ 2026-09-02 9:23 UTC (permalink / raw)
To: cip-dev, pavel, nobuhiro.iwamatsu.x90
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
commit 9dc4335758c983045ab38871e2411fa1ae7e438d upstream.
Introduce ICU_IRQ_LAST and ICU_TINT_LAST macros to make range boundaries
explicit and reduce the chance of off-by-one errors.
Extract the TINT information up front in rzv2h_icu_alloc() and validate
the resulting hardware IRQ against the full TINT range
[ICU_TINT_START, ICU_TINT_LAST].
[ tglx: Convert the hard to parse inverse conditions to use a simple helper
macro hwirq_within() which is easy to read, less error prone and
avoids a lot of typing ]
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Link: https://patch.msgid.link/20260304113317.129339-5-prabhakar.mahadev-lad.rj@bp.renesas.com
Signed-off-by: Ovidiu Panait <ovidiu.panait.rb@renesas.com>
---
drivers/irqchip/irq-renesas-rzv2h.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/irqchip/irq-renesas-rzv2h.c b/drivers/irqchip/irq-renesas-rzv2h.c
index 3898ec70462a..b6ca865d9e9b 100644
--- a/drivers/irqchip/irq-renesas-rzv2h.c
+++ b/drivers/irqchip/irq-renesas-rzv2h.c
@@ -25,9 +25,11 @@
/* DT "interrupts" indexes */
#define ICU_IRQ_START 1
#define ICU_IRQ_COUNT 16
-#define ICU_TINT_START (ICU_IRQ_START + ICU_IRQ_COUNT)
+#define ICU_IRQ_LAST (ICU_IRQ_START + ICU_IRQ_COUNT - 1)
+#define ICU_TINT_START (ICU_IRQ_LAST + 1)
#define ICU_TINT_COUNT 32
-#define ICU_NUM_IRQ (ICU_TINT_START + ICU_TINT_COUNT)
+#define ICU_TINT_LAST (ICU_TINT_START + ICU_TINT_COUNT - 1)
+#define ICU_NUM_IRQ (ICU_TINT_LAST + 1)
/* Registers */
#define ICU_NSCNT 0x00
@@ -487,6 +489,8 @@ static const struct irq_chip rzv2h_icu_chip = {
IRQCHIP_SKIP_SET_WAKE,
};
+#define hwirq_within(hwirq, which) ((hwirq) >= which##_START && (hwirq) <= which##_LAST)
+
static int rzv2h_icu_alloc(struct irq_domain *domain, unsigned int virq, unsigned int nr_irqs,
void *arg)
{
@@ -506,11 +510,11 @@ static int rzv2h_icu_alloc(struct irq_domain *domain, unsigned int virq, unsigne
* hwirq is embedded in bits 0-15.
* TINT is embedded in bits 16-31.
*/
- if (hwirq >= ICU_TINT_START) {
- tint = ICU_TINT_EXTRACT_GPIOINT(hwirq);
+ tint = ICU_TINT_EXTRACT_GPIOINT(hwirq);
+ if (tint || hwirq_within(hwirq, ICU_TINT)) {
hwirq = ICU_TINT_EXTRACT_HWIRQ(hwirq);
- if (hwirq < ICU_TINT_START)
+ if (!hwirq_within(hwirq, ICU_TINT))
return -EINVAL;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 6.1.y-cip 06/11] irqchip/renesas-rzv2h: Replace single irq_chip with per-region irq_chip instances
2026-09-02 9:23 [PATCH 6.1.y-cip 00/11] Add ICU error and software interrupt support for RZ/V2H and RZ/V2N Ovidiu Panait
` (4 preceding siblings ...)
2026-09-02 9:23 ` [PATCH 6.1.y-cip 05/11] irqchip/renesas-rzv2h: Clarify IRQ range definitions and tighten TINT validation Ovidiu Panait
@ 2026-09-02 9:23 ` Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 07/11] irqchip/renesas-rzv2h: Add CA55 software interrupt support Ovidiu Panait
` (6 subsequent siblings)
12 siblings, 0 replies; 16+ messages in thread
From: Ovidiu Panait @ 2026-09-02 9:23 UTC (permalink / raw)
To: cip-dev, pavel, nobuhiro.iwamatsu.x90
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
commit f3ebae6dc025d0e45e9240ed85f9909a5a91e03c upstream.
Replace the single rzv2h_icu_chip and its dispatcher callbacks with
dedicated irq_chip instances for each interrupt region: NMI, IRQ, and
TINT.
Move the irqd_is_level_type() check ahead of the scoped_guard in
rzv2h_icu_tint_eoi() and rzv2h_icu_irq_eoi() to avoid acquiring the
spinlock unnecessarily for level-type interrupts.
Drop the ICU_TINT_START guard from rzv2h_tint_irq_endisable() since it
is now only reachable via the TINT chip path.
[ tglx: Convert to hwirq_within() ]
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Link: https://patch.msgid.link/20260304113317.129339-6-prabhakar.mahadev-lad.rj@bp.renesas.com
[OP: fixed minor context difference]
Signed-off-by: Ovidiu Panait <ovidiu.panait.rb@renesas.com>
---
drivers/irqchip/irq-renesas-rzv2h.c | 174 +++++++++++++++++-----------
1 file changed, 104 insertions(+), 70 deletions(-)
diff --git a/drivers/irqchip/irq-renesas-rzv2h.c b/drivers/irqchip/irq-renesas-rzv2h.c
index b6ca865d9e9b..45b30503f88e 100644
--- a/drivers/irqchip/irq-renesas-rzv2h.c
+++ b/drivers/irqchip/irq-renesas-rzv2h.c
@@ -171,32 +171,47 @@ static inline struct rzv2h_icu_priv *irq_data_to_priv(struct irq_data *data)
return data->domain->host_data;
}
-static void rzv2h_icu_eoi(struct irq_data *d)
+static void rzv2h_icu_tint_eoi(struct irq_data *d)
{
struct rzv2h_icu_priv *priv = irq_data_to_priv(d);
unsigned int hw_irq = irqd_to_hwirq(d);
unsigned int tintirq_nr;
u32 bit;
- scoped_guard(raw_spinlock, &priv->lock) {
- if (hw_irq >= ICU_TINT_START) {
- tintirq_nr = hw_irq - ICU_TINT_START;
- bit = BIT(tintirq_nr);
- if (!irqd_is_level_type(d))
- writel_relaxed(bit, priv->base + priv->info->t_offs + ICU_TSCLR);
- } else if (hw_irq >= ICU_IRQ_START) {
- tintirq_nr = hw_irq - ICU_IRQ_START;
- bit = BIT(tintirq_nr);
- if (!irqd_is_level_type(d))
- writel_relaxed(bit, priv->base + ICU_ISCLR);
- } else {
- writel_relaxed(ICU_NSCLR_NCLR, priv->base + ICU_NSCLR);
- }
+ if (!irqd_is_level_type(d)) {
+ tintirq_nr = hw_irq - ICU_TINT_START;
+ bit = BIT(tintirq_nr);
+ writel_relaxed(bit, priv->base + priv->info->t_offs + ICU_TSCLR);
+ }
+
+ irq_chip_eoi_parent(d);
+}
+
+static void rzv2h_icu_irq_eoi(struct irq_data *d)
+{
+ struct rzv2h_icu_priv *priv = irq_data_to_priv(d);
+ unsigned int hw_irq = irqd_to_hwirq(d);
+ unsigned int tintirq_nr;
+ u32 bit;
+
+ if (!irqd_is_level_type(d)) {
+ tintirq_nr = hw_irq - ICU_IRQ_START;
+ bit = BIT(tintirq_nr);
+ writel_relaxed(bit, priv->base + ICU_ISCLR);
}
irq_chip_eoi_parent(d);
}
+static void rzv2h_icu_nmi_eoi(struct irq_data *d)
+{
+ struct rzv2h_icu_priv *priv = irq_data_to_priv(d);
+
+ writel_relaxed(ICU_NSCLR_NCLR, priv->base + ICU_NSCLR);
+
+ irq_chip_eoi_parent(d);
+}
+
static void rzv2h_tint_irq_endisable(struct irq_data *d, bool enable)
{
struct rzv2h_icu_priv *priv = irq_data_to_priv(d);
@@ -204,9 +219,6 @@ static void rzv2h_tint_irq_endisable(struct irq_data *d, bool enable)
u32 tint_nr, tssel_n, k, tssr;
u8 nr_tint;
- if (hw_irq < ICU_TINT_START)
- return;
-
tint_nr = hw_irq - ICU_TINT_START;
nr_tint = 32 / priv->info->field_width;
k = tint_nr / nr_tint;
@@ -229,13 +241,13 @@ static void rzv2h_tint_irq_endisable(struct irq_data *d, bool enable)
writel_relaxed(BIT(tint_nr), priv->base + priv->info->t_offs + ICU_TSCLR);
}
-static void rzv2h_icu_irq_disable(struct irq_data *d)
+static void rzv2h_icu_tint_disable(struct irq_data *d)
{
irq_chip_disable_parent(d);
rzv2h_tint_irq_endisable(d, false);
}
-static void rzv2h_icu_irq_enable(struct irq_data *d)
+static void rzv2h_icu_tint_enable(struct irq_data *d)
{
rzv2h_tint_irq_endisable(d, true);
irq_chip_enable_parent(d);
@@ -261,7 +273,7 @@ static int rzv2h_nmi_set_type(struct irq_data *d, unsigned int type)
writel_relaxed(sense, priv->base + ICU_NITSR);
- return 0;
+ return irq_chip_set_type_parent(d, IRQ_TYPE_LEVEL_HIGH);
}
static void rzv2h_clear_irq_int(struct rzv2h_icu_priv *priv, unsigned int hwirq)
@@ -311,14 +323,15 @@ static int rzv2h_irq_set_type(struct irq_data *d, unsigned int type)
return -EINVAL;
}
- guard(raw_spinlock)(&priv->lock);
- iitsr = readl_relaxed(priv->base + ICU_IITSR);
- iitsr &= ~ICU_IITSR_IITSEL_MASK(irq_nr);
- iitsr |= ICU_IITSR_IITSEL_PREP(sense, irq_nr);
- rzv2h_clear_irq_int(priv, hwirq);
- writel_relaxed(iitsr, priv->base + ICU_IITSR);
+ scoped_guard(raw_spinlock, &priv->lock) {
+ iitsr = readl_relaxed(priv->base + ICU_IITSR);
+ iitsr &= ~ICU_IITSR_IITSEL_MASK(irq_nr);
+ iitsr |= ICU_IITSR_IITSEL_PREP(sense, irq_nr);
+ rzv2h_clear_irq_int(priv, hwirq);
+ writel_relaxed(iitsr, priv->base + ICU_IITSR);
+ }
- return 0;
+ return irq_chip_set_type_parent(d, IRQ_TYPE_LEVEL_HIGH);
}
static void rzv2h_clear_tint_int(struct rzv2h_icu_priv *priv, unsigned int hwirq)
@@ -393,48 +406,30 @@ static int rzv2h_tint_set_type(struct irq_data *d, unsigned int type)
titsr_k = ICU_TITSR_K(tint_nr);
titsel_n = ICU_TITSR_TITSEL_N(tint_nr);
- guard(raw_spinlock)(&priv->lock);
-
- tssr = readl_relaxed(priv->base + priv->info->t_offs + ICU_TSSR(tssr_k));
- titsr = readl_relaxed(priv->base + priv->info->t_offs + ICU_TITSR(titsr_k));
-
- tssr_cur = field_get(ICU_TSSR_TSSEL_MASK(tssel_n, priv->info->field_width), tssr);
- titsr_cur = field_get(ICU_TITSR_TITSEL_MASK(titsel_n), titsr);
- if (tssr_cur == tint && titsr_cur == sense)
- return 0;
-
- tssr &= ~(ICU_TSSR_TSSEL_MASK(tssel_n, priv->info->field_width) | tien);
- tssr |= ICU_TSSR_TSSEL_PREP(tint, tssel_n, priv->info->field_width);
-
- writel_relaxed(tssr, priv->base + priv->info->t_offs + ICU_TSSR(tssr_k));
-
- titsr &= ~ICU_TITSR_TITSEL_MASK(titsel_n);
- titsr |= ICU_TITSR_TITSEL_PREP(sense, titsel_n);
+ scoped_guard(raw_spinlock, &priv->lock) {
+ tssr = readl_relaxed(priv->base + priv->info->t_offs + ICU_TSSR(tssr_k));
+ titsr = readl_relaxed(priv->base + priv->info->t_offs + ICU_TITSR(titsr_k));
- writel_relaxed(titsr, priv->base + priv->info->t_offs + ICU_TITSR(titsr_k));
+ tssr_cur = field_get(ICU_TSSR_TSSEL_MASK(tssel_n, priv->info->field_width), tssr);
+ titsr_cur = field_get(ICU_TITSR_TITSEL_MASK(titsel_n), titsr);
+ if (tssr_cur == tint && titsr_cur == sense)
+ goto set_parent_type;
- rzv2h_clear_tint_int(priv, hwirq);
+ tssr &= ~(ICU_TSSR_TSSEL_MASK(tssel_n, priv->info->field_width) | tien);
+ tssr |= ICU_TSSR_TSSEL_PREP(tint, tssel_n, priv->info->field_width);
- writel_relaxed(tssr | tien, priv->base + priv->info->t_offs + ICU_TSSR(tssr_k));
+ writel_relaxed(tssr, priv->base + priv->info->t_offs + ICU_TSSR(tssr_k));
- return 0;
-}
+ titsr &= ~ICU_TITSR_TITSEL_MASK(titsel_n);
+ titsr |= ICU_TITSR_TITSEL_PREP(sense, titsel_n);
-static int rzv2h_icu_set_type(struct irq_data *d, unsigned int type)
-{
- unsigned int hw_irq = irqd_to_hwirq(d);
- int ret;
-
- if (hw_irq >= ICU_TINT_START)
- ret = rzv2h_tint_set_type(d, type);
- else if (hw_irq >= ICU_IRQ_START)
- ret = rzv2h_irq_set_type(d, type);
- else
- ret = rzv2h_nmi_set_type(d, type);
+ writel_relaxed(titsr, priv->base + priv->info->t_offs + ICU_TITSR(titsr_k));
- if (ret)
- return ret;
+ rzv2h_clear_tint_int(priv, hwirq);
+ writel_relaxed(tssr | tien, priv->base + priv->info->t_offs + ICU_TSSR(tssr_k));
+ }
+set_parent_type:
return irq_chip_set_type_parent(d, IRQ_TYPE_LEVEL_HIGH);
}
@@ -472,17 +467,51 @@ static struct syscore_ops rzv2h_irqc_syscore_ops = {
.resume = rzv2h_irqc_irq_resume,
};
-static const struct irq_chip rzv2h_icu_chip = {
+static const struct irq_chip rzv2h_icu_tint_chip = {
+ .name = "rzv2h-icu",
+ .irq_eoi = rzv2h_icu_tint_eoi,
+ .irq_mask = irq_chip_mask_parent,
+ .irq_unmask = irq_chip_unmask_parent,
+ .irq_disable = rzv2h_icu_tint_disable,
+ .irq_enable = rzv2h_icu_tint_enable,
+ .irq_get_irqchip_state = irq_chip_get_parent_state,
+ .irq_set_irqchip_state = irq_chip_set_parent_state,
+ .irq_retrigger = irq_chip_retrigger_hierarchy,
+ .irq_set_type = rzv2h_tint_set_type,
+ .irq_set_affinity = irq_chip_set_affinity_parent,
+ .flags = IRQCHIP_MASK_ON_SUSPEND |
+ IRQCHIP_SET_TYPE_MASKED |
+ IRQCHIP_SKIP_SET_WAKE,
+};
+
+static const struct irq_chip rzv2h_icu_irq_chip = {
+ .name = "rzv2h-icu",
+ .irq_eoi = rzv2h_icu_irq_eoi,
+ .irq_mask = irq_chip_mask_parent,
+ .irq_unmask = irq_chip_unmask_parent,
+ .irq_disable = irq_chip_disable_parent,
+ .irq_enable = irq_chip_enable_parent,
+ .irq_get_irqchip_state = irq_chip_get_parent_state,
+ .irq_set_irqchip_state = irq_chip_set_parent_state,
+ .irq_retrigger = irq_chip_retrigger_hierarchy,
+ .irq_set_type = rzv2h_irq_set_type,
+ .irq_set_affinity = irq_chip_set_affinity_parent,
+ .flags = IRQCHIP_MASK_ON_SUSPEND |
+ IRQCHIP_SET_TYPE_MASKED |
+ IRQCHIP_SKIP_SET_WAKE,
+};
+
+static const struct irq_chip rzv2h_icu_nmi_chip = {
.name = "rzv2h-icu",
- .irq_eoi = rzv2h_icu_eoi,
+ .irq_eoi = rzv2h_icu_nmi_eoi,
.irq_mask = irq_chip_mask_parent,
.irq_unmask = irq_chip_unmask_parent,
- .irq_disable = rzv2h_icu_irq_disable,
- .irq_enable = rzv2h_icu_irq_enable,
+ .irq_disable = irq_chip_disable_parent,
+ .irq_enable = irq_chip_enable_parent,
.irq_get_irqchip_state = irq_chip_get_parent_state,
.irq_set_irqchip_state = irq_chip_set_parent_state,
.irq_retrigger = irq_chip_retrigger_hierarchy,
- .irq_set_type = rzv2h_icu_set_type,
+ .irq_set_type = rzv2h_nmi_set_type,
.irq_set_affinity = irq_chip_set_affinity_parent,
.flags = IRQCHIP_MASK_ON_SUSPEND |
IRQCHIP_SET_TYPE_MASKED |
@@ -495,6 +524,7 @@ static int rzv2h_icu_alloc(struct irq_domain *domain, unsigned int virq, unsigne
void *arg)
{
struct rzv2h_icu_priv *priv = domain->host_data;
+ const struct irq_chip *chip;
unsigned long tint = 0;
irq_hw_number_t hwirq;
unsigned int type;
@@ -516,13 +546,17 @@ static int rzv2h_icu_alloc(struct irq_domain *domain, unsigned int virq, unsigne
if (!hwirq_within(hwirq, ICU_TINT))
return -EINVAL;
+ chip = &rzv2h_icu_tint_chip;
+ } else if (hwirq_within(hwirq, ICU_IRQ)) {
+ chip = &rzv2h_icu_irq_chip;
+ } else {
+ chip = &rzv2h_icu_nmi_chip;
}
if (hwirq > (ICU_NUM_IRQ - 1))
return -EINVAL;
- ret = irq_domain_set_hwirq_and_chip(domain, virq, hwirq, &rzv2h_icu_chip,
- (void *)(uintptr_t)tint);
+ ret = irq_domain_set_hwirq_and_chip(domain, virq, hwirq, chip, (void *)(uintptr_t)tint);
if (ret)
return ret;
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 6.1.y-cip 07/11] irqchip/renesas-rzv2h: Add CA55 software interrupt support
2026-09-02 9:23 [PATCH 6.1.y-cip 00/11] Add ICU error and software interrupt support for RZ/V2H and RZ/V2N Ovidiu Panait
` (5 preceding siblings ...)
2026-09-02 9:23 ` [PATCH 6.1.y-cip 06/11] irqchip/renesas-rzv2h: Replace single irq_chip with per-region irq_chip instances Ovidiu Panait
@ 2026-09-02 9:23 ` Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 08/11] irqchip/renesas-rzv2h: Handle ICU error IRQ and add SWPE trigger Ovidiu Panait
` (5 subsequent siblings)
12 siblings, 0 replies; 16+ messages in thread
From: Ovidiu Panait @ 2026-09-02 9:23 UTC (permalink / raw)
To: cip-dev, pavel, nobuhiro.iwamatsu.x90
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
commit 61adc4813d67990f6f9c20ab8c4a57fb3d969322 upstream.
The RZ/V2H ICU exposes four software-triggerable interrupts targeting
the CA55 cores (int-ca55-0 to int-ca55-3). Add support for these
interrupts to enable IRQ injection via the generic IRQ injection
framework.
Add a dedicated rzv2h_icu_swint_chip irq_chip for the CA55 region and
implement rzv2h_icu_irq_set_irqchip_state() to handle software interrupt
injection.
[ tglx: Convert to hwirq_within() ]
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Link: https://patch.msgid.link/20260304113317.129339-7-prabhakar.mahadev-lad.rj@bp.renesas.com
[OP: fixed minor context difference]
Signed-off-by: Ovidiu Panait <ovidiu.panait.rb@renesas.com>
---
drivers/irqchip/irq-renesas-rzv2h.c | 95 ++++++++++++++++++++++++++++-
1 file changed, 94 insertions(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-renesas-rzv2h.c b/drivers/irqchip/irq-renesas-rzv2h.c
index 45b30503f88e..2b5765fefac5 100644
--- a/drivers/irqchip/irq-renesas-rzv2h.c
+++ b/drivers/irqchip/irq-renesas-rzv2h.c
@@ -12,6 +12,7 @@
#include <linux/bitfield.h>
#include <linux/cleanup.h>
#include <linux/err.h>
+#include <linux/interrupt.h>
#include <linux/io.h>
#include <linux/irqchip.h>
#include <linux/irqchip/irq-renesas-rzv2h.h>
@@ -29,7 +30,10 @@
#define ICU_TINT_START (ICU_IRQ_LAST + 1)
#define ICU_TINT_COUNT 32
#define ICU_TINT_LAST (ICU_TINT_START + ICU_TINT_COUNT - 1)
-#define ICU_NUM_IRQ (ICU_TINT_LAST + 1)
+#define ICU_CA55_INT_START (ICU_TINT_LAST + 1)
+#define ICU_CA55_INT_COUNT 4
+#define ICU_CA55_INT_LAST (ICU_CA55_INT_START + ICU_CA55_INT_COUNT - 1)
+#define ICU_NUM_IRQ (ICU_CA55_INT_LAST + 1)
/* Registers */
#define ICU_NSCNT 0x00
@@ -42,6 +46,7 @@
#define ICU_TSCLR 0x24
#define ICU_TITSR(k) (0x28 + (k) * 4)
#define ICU_TSSR(k) (0x30 + (k) * 4)
+#define ICU_SWINT 0x130
#define ICU_DMkSELy(k, y) (0x420 + (k) * 0x20 + (y) * 4)
#define ICU_DMACKSELk(k) (0x500 + (k) * 4)
@@ -433,6 +438,27 @@ static int rzv2h_tint_set_type(struct irq_data *d, unsigned int type)
return irq_chip_set_type_parent(d, IRQ_TYPE_LEVEL_HIGH);
}
+static int rzv2h_icu_swint_set_irqchip_state(struct irq_data *d, enum irqchip_irq_state which,
+ bool state)
+{
+ unsigned int hwirq = irqd_to_hwirq(d);
+ struct rzv2h_icu_priv *priv;
+ unsigned int bit;
+
+ if (which != IRQCHIP_STATE_PENDING)
+ return irq_chip_set_parent_state(d, which, state);
+
+ if (!state)
+ return 0;
+
+ priv = irq_data_to_priv(d);
+ bit = BIT(hwirq - ICU_CA55_INT_START);
+
+ /* Trigger the software interrupt */
+ writel_relaxed(bit, priv->base + ICU_SWINT);
+ return 0;
+}
+
static int rzv2h_irqc_irq_suspend(void)
{
struct rzv2h_irqc_reg_cache *cache = &rzv2h_icu_data->cache;
@@ -518,6 +544,23 @@ static const struct irq_chip rzv2h_icu_nmi_chip = {
IRQCHIP_SKIP_SET_WAKE,
};
+static const struct irq_chip rzv2h_icu_swint_chip = {
+ .name = "rzv2h-icu",
+ .irq_eoi = irq_chip_eoi_parent,
+ .irq_mask = irq_chip_mask_parent,
+ .irq_unmask = irq_chip_unmask_parent,
+ .irq_disable = irq_chip_disable_parent,
+ .irq_enable = irq_chip_enable_parent,
+ .irq_get_irqchip_state = irq_chip_get_parent_state,
+ .irq_set_irqchip_state = rzv2h_icu_swint_set_irqchip_state,
+ .irq_retrigger = irq_chip_retrigger_hierarchy,
+ .irq_set_type = irq_chip_set_type_parent,
+ .irq_set_affinity = irq_chip_set_affinity_parent,
+ .flags = IRQCHIP_MASK_ON_SUSPEND |
+ IRQCHIP_SET_TYPE_MASKED |
+ IRQCHIP_SKIP_SET_WAKE,
+};
+
#define hwirq_within(hwirq, which) ((hwirq) >= which##_START && (hwirq) <= which##_LAST)
static int rzv2h_icu_alloc(struct irq_domain *domain, unsigned int virq, unsigned int nr_irqs,
@@ -549,6 +592,8 @@ static int rzv2h_icu_alloc(struct irq_domain *domain, unsigned int virq, unsigne
chip = &rzv2h_icu_tint_chip;
} else if (hwirq_within(hwirq, ICU_IRQ)) {
chip = &rzv2h_icu_irq_chip;
+ } else if (hwirq_within(hwirq, ICU_CA55_INT)) {
+ chip = &rzv2h_icu_swint_chip;
} else {
chip = &rzv2h_icu_nmi_chip;
}
@@ -591,6 +636,50 @@ static void rzv2h_icu_put_device(void *data)
put_device(data);
}
+static irqreturn_t rzv2h_icu_swint_irq(int irq, void *data)
+{
+ u8 cpu = *(u8 *)data;
+
+ pr_info("SWINT interrupt for CA55 core %u\n", cpu);
+ return IRQ_HANDLED;
+}
+
+static int rzv2h_icu_setup_irqs(struct platform_device *pdev, struct irq_domain *irq_domain)
+{
+ bool irq_inject = IS_ENABLED(CONFIG_GENERIC_IRQ_INJECTION);
+ static const char * const rzv2h_swint_names[] = {
+ "int-ca55-0", "int-ca55-1",
+ "int-ca55-2", "int-ca55-3",
+ };
+ static const u8 swint_idx[] = { 0, 1, 2, 3 };
+ struct device *dev = &pdev->dev;
+ struct irq_fwspec fwspec;
+ unsigned int i, virq;
+ int ret;
+
+ for (i = 0; i < ICU_CA55_INT_COUNT && irq_inject; i++) {
+ fwspec.fwnode = irq_domain->fwnode;
+ fwspec.param_count = 2;
+ fwspec.param[0] = ICU_CA55_INT_START + i;
+ fwspec.param[1] = IRQ_TYPE_EDGE_RISING;
+
+ virq = irq_create_fwspec_mapping(&fwspec);
+ if (!virq) {
+ return dev_err_probe(dev, -EINVAL, "failed to create IRQ mapping for %s\n",
+ rzv2h_swint_names[i]);
+ }
+
+ ret = devm_request_irq(dev, virq, rzv2h_icu_swint_irq, 0, dev_name(dev),
+ (void *)&swint_idx[i]);
+ if (ret) {
+ return dev_err_probe(dev, ret, "Failed to request %s IRQ\n",
+ rzv2h_swint_names[i]);
+ }
+ }
+
+ return 0;
+}
+
static int rzv2h_icu_init_common(struct device_node *node, struct device_node *parent,
const struct rzv2h_hw_info *hw_info)
{
@@ -657,6 +746,10 @@ static int rzv2h_icu_init_common(struct device_node *node, struct device_node *p
register_syscore_ops(&rzv2h_irqc_syscore_ops);
+ ret = rzv2h_icu_setup_irqs(pdev, irq_domain);
+ if (ret)
+ goto pm_put;
+
/*
* coccicheck complains about a missing put_device call before returning, but it's a false
* positive. We still need dev after successfully returning from this function.
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 6.1.y-cip 08/11] irqchip/renesas-rzv2h: Handle ICU error IRQ and add SWPE trigger
2026-09-02 9:23 [PATCH 6.1.y-cip 00/11] Add ICU error and software interrupt support for RZ/V2H and RZ/V2N Ovidiu Panait
` (6 preceding siblings ...)
2026-09-02 9:23 ` [PATCH 6.1.y-cip 07/11] irqchip/renesas-rzv2h: Add CA55 software interrupt support Ovidiu Panait
@ 2026-09-02 9:23 ` Ovidiu Panait
2026-09-02 17:00 ` Pavel Machek
2026-09-02 9:23 ` [PATCH 6.1.y-cip 09/11] irqchip/renesas-rzv2h: Kill swint_idx[] Ovidiu Panait
` (4 subsequent siblings)
12 siblings, 1 reply; 16+ messages in thread
From: Ovidiu Panait @ 2026-09-02 9:23 UTC (permalink / raw)
To: cip-dev, pavel, nobuhiro.iwamatsu.x90
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
commit 7585a27644f338b3e764ceeda4be10e7047331a7 upstream.
Handle the RZ/V2H ICU error interrupt to help diagnose latched bus,
ECC RAM, and CA55/IP error conditions.
Support error injection via ICU_SWPE to allow testing the pseudo error
error interrupts.
Account for SoC differences in ECC RAM error register coverage so the
handler only iterates over valid ECC status/clear banks, and route the
RZ/V2N compatible to a probe path with the correct ECC range while
keeping the existing RZ/V2H and RZ/G3E handling.
[ tglx: Convert to hwirq_within() and upgrade to pr_warn() for those errors ]
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Link: https://patch.msgid.link/20260304113317.129339-8-prabhakar.mahadev-lad.rj@bp.renesas.com
[OP: adjusted rzv2n_icu_probe() to rzv2n_icu_init() for the init path, as
upstream commit 1e3e330c0707 ("irqchip: Pass platform device to platform
drivers") is not present in 6.1 CIP]
Signed-off-by: Ovidiu Panait <ovidiu.panait.rb@renesas.com>
---
drivers/irqchip/irq-renesas-rzv2h.c | 163 +++++++++++++++++++++++++++-
1 file changed, 161 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-renesas-rzv2h.c b/drivers/irqchip/irq-renesas-rzv2h.c
index 2b5765fefac5..ce5773d7ceb0 100644
--- a/drivers/irqchip/irq-renesas-rzv2h.c
+++ b/drivers/irqchip/irq-renesas-rzv2h.c
@@ -33,7 +33,10 @@
#define ICU_CA55_INT_START (ICU_TINT_LAST + 1)
#define ICU_CA55_INT_COUNT 4
#define ICU_CA55_INT_LAST (ICU_CA55_INT_START + ICU_CA55_INT_COUNT - 1)
-#define ICU_NUM_IRQ (ICU_CA55_INT_LAST + 1)
+#define ICU_ERR_INT_START (ICU_CA55_INT_LAST + 1)
+#define ICU_ERR_INT_COUNT 1
+#define ICU_ERR_INT_LAST (ICU_ERR_INT_START + ICU_ERR_INT_COUNT - 1)
+#define ICU_NUM_IRQ (ICU_ERR_INT_LAST + 1)
/* Registers */
#define ICU_NSCNT 0x00
@@ -46,7 +49,15 @@
#define ICU_TSCLR 0x24
#define ICU_TITSR(k) (0x28 + (k) * 4)
#define ICU_TSSR(k) (0x30 + (k) * 4)
+#define ICU_BEISR(k) (0x70 + (k) * 4)
+#define ICU_BECLR(k) (0x80 + (k) * 4)
+#define ICU_EREISR(k) (0x90 + (k) * 4)
+#define ICU_ERCLR(k) (0xE0 + (k) * 4)
#define ICU_SWINT 0x130
+#define ICU_ERINTA55CTL(k) (0x338 + (k) * 4)
+#define ICU_ERINTA55CRL(k) (0x348 + (k) * 4)
+#define ICU_ERINTA55MSK(k) (0x358 + (k) * 4)
+#define ICU_SWPE 0x370
#define ICU_DMkSELy(k, y) (0x420 + (k) * 0x20 + (y) * 4)
#define ICU_DMACKSELk(k) (0x500 + (k) * 4)
@@ -97,6 +108,10 @@
#define ICU_RZG3E_TSSEL_MAX_VAL 0x8c
#define ICU_RZV2H_TSSEL_MAX_VAL 0x55
+#define ICU_SWPE_NUM 16
+#define ICU_NUM_BE 4
+#define ICU_NUM_A55ERR 4
+
#define field_get(_mask, _reg) (((_reg) & (_mask)) >> (ffs(_mask) - 1))
/**
@@ -117,12 +132,16 @@ struct rzv2h_irqc_reg_cache {
* @t_offs: TINT offset
* @max_tssel: TSSEL max value
* @field_width: TSSR field width
+ * @ecc_start: Start index of ECC RAM interrupts
+ * @ecc_end: End index of ECC RAM interrupts
*/
struct rzv2h_hw_info {
const u8 *tssel_lut;
u16 t_offs;
u8 max_tssel;
u8 field_width;
+ u8 ecc_start;
+ u8 ecc_end;
};
/* DMAC */
@@ -456,6 +475,36 @@ static int rzv2h_icu_swint_set_irqchip_state(struct irq_data *d, enum irqchip_ir
/* Trigger the software interrupt */
writel_relaxed(bit, priv->base + ICU_SWINT);
+
+ return 0;
+}
+
+static int rzv2h_icu_swpe_set_irqchip_state(struct irq_data *d, enum irqchip_irq_state which,
+ bool state)
+{
+ struct rzv2h_icu_priv *priv;
+ unsigned int bit;
+ static u8 swpe;
+
+ if (which != IRQCHIP_STATE_PENDING)
+ return irq_chip_set_parent_state(d, which, state);
+
+ if (!state)
+ return 0;
+
+ priv = irq_data_to_priv(d);
+
+ bit = BIT(swpe);
+ /*
+ * SWPE has 16 bits; the bit position is rotated on each trigger
+ * and wraps around once all bits have been used.
+ */
+ if (++swpe >= ICU_SWPE_NUM)
+ swpe = 0;
+
+ /* Trigger the pseudo error interrupt */
+ writel_relaxed(bit, priv->base + ICU_SWPE);
+
return 0;
}
@@ -561,6 +610,23 @@ static const struct irq_chip rzv2h_icu_swint_chip = {
IRQCHIP_SKIP_SET_WAKE,
};
+static const struct irq_chip rzv2h_icu_swpe_err_chip = {
+ .name = "rzv2h-icu",
+ .irq_eoi = irq_chip_eoi_parent,
+ .irq_mask = irq_chip_mask_parent,
+ .irq_unmask = irq_chip_unmask_parent,
+ .irq_disable = irq_chip_disable_parent,
+ .irq_enable = irq_chip_enable_parent,
+ .irq_get_irqchip_state = irq_chip_get_parent_state,
+ .irq_set_irqchip_state = rzv2h_icu_swpe_set_irqchip_state,
+ .irq_retrigger = irq_chip_retrigger_hierarchy,
+ .irq_set_type = irq_chip_set_type_parent,
+ .irq_set_affinity = irq_chip_set_affinity_parent,
+ .flags = IRQCHIP_MASK_ON_SUSPEND |
+ IRQCHIP_SET_TYPE_MASKED |
+ IRQCHIP_SKIP_SET_WAKE,
+};
+
#define hwirq_within(hwirq, which) ((hwirq) >= which##_START && (hwirq) <= which##_LAST)
static int rzv2h_icu_alloc(struct irq_domain *domain, unsigned int virq, unsigned int nr_irqs,
@@ -594,6 +660,8 @@ static int rzv2h_icu_alloc(struct irq_domain *domain, unsigned int virq, unsigne
chip = &rzv2h_icu_irq_chip;
} else if (hwirq_within(hwirq, ICU_CA55_INT)) {
chip = &rzv2h_icu_swint_chip;
+ } else if (hwirq_within(hwirq, ICU_ERR_INT)) {
+ chip = &rzv2h_icu_swpe_err_chip;
} else {
chip = &rzv2h_icu_nmi_chip;
}
@@ -636,6 +704,48 @@ static void rzv2h_icu_put_device(void *data)
put_device(data);
}
+static irqreturn_t rzv2h_icu_error_irq(int irq, void *data)
+{
+ struct rzv2h_icu_priv *priv = data;
+ const struct rzv2h_hw_info *hw_info = priv->info;
+ void __iomem *base = priv->base;
+ unsigned int k;
+ u32 st;
+
+ /* 1) Bus errors (BEISR0..3) */
+ for (k = 0; k < ICU_NUM_BE; k++) {
+ st = readl(base + ICU_BEISR(k));
+ if (!st)
+ continue;
+
+ writel_relaxed(st, base + ICU_BECLR(k));
+ pr_warn("rzv2h-icu: BUS error k=%u status=0x%08x\n", k, st);
+ }
+
+ /* 2) ECC RAM errors (EREISR0..X) */
+ for (k = hw_info->ecc_start; k <= hw_info->ecc_end; k++) {
+ st = readl(base + ICU_EREISR(k));
+ if (!st)
+ continue;
+
+ writel_relaxed(st, base + ICU_ERCLR(k));
+ pr_warn("rzv2h-icu: ECC error k=%u status=0x%08x\n", k, st);
+ }
+
+ /* 3) IP/CA55 error interrupt status (ERINTA55CTL0..3) */
+ for (k = 0; k < ICU_NUM_A55ERR; k++) {
+ st = readl(base + ICU_ERINTA55CTL(k));
+ if (!st)
+ continue;
+
+ /* there is no relation with status bits so clear all the interrupts */
+ writel_relaxed(0xffffffff, base + ICU_ERINTA55CRL(k));
+ pr_warn("rzv2h-icu: IP/CA55 error k=%u status=0x%08x\n", k, st);
+ }
+
+ return IRQ_HANDLED;
+}
+
static irqreturn_t rzv2h_icu_swint_irq(int irq, void *data)
{
u8 cpu = *(u8 *)data;
@@ -646,12 +756,15 @@ static irqreturn_t rzv2h_icu_swint_irq(int irq, void *data)
static int rzv2h_icu_setup_irqs(struct platform_device *pdev, struct irq_domain *irq_domain)
{
+ const struct rzv2h_hw_info *hw_info = rzv2h_icu_data->info;
bool irq_inject = IS_ENABLED(CONFIG_GENERIC_IRQ_INJECTION);
static const char * const rzv2h_swint_names[] = {
"int-ca55-0", "int-ca55-1",
"int-ca55-2", "int-ca55-3",
};
+ static const char *icu_err = "icu-error-ca55";
static const u8 swint_idx[] = { 0, 1, 2, 3 };
+ void __iomem *base = rzv2h_icu_data->base;
struct device *dev = &pdev->dev;
struct irq_fwspec fwspec;
unsigned int i, virq;
@@ -677,6 +790,35 @@ static int rzv2h_icu_setup_irqs(struct platform_device *pdev, struct irq_domain
}
}
+ /* Unmask and clear all IP/CA55 error interrupts */
+ for (i = 0; i < ICU_NUM_A55ERR; i++) {
+ writel_relaxed(0xffffff, base + ICU_ERINTA55CRL(i));
+ writel_relaxed(0x0, base + ICU_ERINTA55MSK(i));
+ }
+
+ /* Clear all Bus errors */
+ for (i = 0; i < ICU_NUM_BE; i++)
+ writel_relaxed(0xffffffff, base + ICU_BECLR(i));
+
+ /* Clear all ECCRAM errors */
+ for (i = hw_info->ecc_start; i <= hw_info->ecc_end; i++)
+ writel_relaxed(0xffffffff, base + ICU_ERCLR(i));
+
+ fwspec.fwnode = irq_domain->fwnode;
+ fwspec.param_count = 2;
+ fwspec.param[0] = ICU_ERR_INT_START;
+ fwspec.param[1] = IRQ_TYPE_LEVEL_HIGH;
+
+ virq = irq_create_fwspec_mapping(&fwspec);
+ if (!virq) {
+ return dev_err_probe(dev, -EINVAL, "failed to create IRQ mapping for %s\n",
+ icu_err);
+ }
+
+ ret = devm_request_irq(dev, virq, rzv2h_icu_error_irq, 0, dev_name(dev), rzv2h_icu_data);
+ if (ret)
+ return dev_err_probe(dev, ret, "Failed to request %s IRQ\n", icu_err);
+
return 0;
}
@@ -796,12 +938,24 @@ static const struct rzv2h_hw_info rzg3e_hw_params = {
.t_offs = ICU_RZG3E_TINT_OFFSET,
.max_tssel = ICU_RZG3E_TSSEL_MAX_VAL,
.field_width = 16,
+ .ecc_start = 1,
+ .ecc_end = 4,
+};
+
+static const struct rzv2h_hw_info rzv2n_hw_params = {
+ .t_offs = 0,
+ .max_tssel = ICU_RZV2H_TSSEL_MAX_VAL,
+ .field_width = 8,
+ .ecc_start = 0,
+ .ecc_end = 2,
};
static const struct rzv2h_hw_info rzv2h_hw_params = {
.t_offs = 0,
.max_tssel = ICU_RZV2H_TSSEL_MAX_VAL,
.field_width = 8,
+ .ecc_start = 0,
+ .ecc_end = 11,
};
static int rzg3e_icu_init(struct device_node *node, struct device_node *parent)
@@ -809,6 +963,11 @@ static int rzg3e_icu_init(struct device_node *node, struct device_node *parent)
return rzv2h_icu_init_common(node, parent, &rzg3e_hw_params);
}
+static int rzv2n_icu_init(struct device_node *node, struct device_node *parent)
+{
+ return rzv2h_icu_init_common(node, parent, &rzv2n_hw_params);
+}
+
static int rzv2h_icu_init(struct device_node *node, struct device_node *parent)
{
return rzv2h_icu_init_common(node, parent, &rzv2h_hw_params);
@@ -816,7 +975,7 @@ static int rzv2h_icu_init(struct device_node *node, struct device_node *parent)
IRQCHIP_PLATFORM_DRIVER_BEGIN(rzv2h_icu)
IRQCHIP_MATCH("renesas,r9a09g047-icu", rzg3e_icu_init)
-IRQCHIP_MATCH("renesas,r9a09g056-icu", rzv2h_icu_init)
+IRQCHIP_MATCH("renesas,r9a09g056-icu", rzv2n_icu_init)
IRQCHIP_MATCH("renesas,r9a09g057-icu", rzv2h_icu_init)
IRQCHIP_PLATFORM_DRIVER_END(rzv2h_icu)
MODULE_AUTHOR("Fabrizio Castro <fabrizio.castro.jz@renesas.com>");
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 6.1.y-cip 08/11] irqchip/renesas-rzv2h: Handle ICU error IRQ and add SWPE trigger
2026-09-02 9:23 ` [PATCH 6.1.y-cip 08/11] irqchip/renesas-rzv2h: Handle ICU error IRQ and add SWPE trigger Ovidiu Panait
@ 2026-09-02 17:00 ` Pavel Machek
0 siblings, 0 replies; 16+ messages in thread
From: Pavel Machek @ 2026-09-02 17:00 UTC (permalink / raw)
To: Ovidiu Panait; +Cc: cip-dev, pavel, nobuhiro.iwamatsu.x90
[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]
Hi!
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> commit 7585a27644f338b3e764ceeda4be10e7047331a7 upstream.
>
> Handle the RZ/V2H ICU error interrupt to help diagnose latched bus,
> ECC RAM, and CA55/IP error conditions.
>
> Support error injection via ICU_SWPE to allow testing the pseudo error
> error interrupts.
>
> Account for SoC differences in ECC RAM error register coverage so the
> handler only iterates over valid ECC status/clear banks, and route the
> RZ/V2N compatible to a probe path with the correct ECC range while
> keeping the existing RZ/V2H and RZ/G3E handling.
>
> +++ b/drivers/irqchip/irq-renesas-rzv2h.c
> + fwspec.param_count = 2;
> + fwspec.param[0] = ICU_ERR_INT_START;
> + fwspec.param[1] = IRQ_TYPE_LEVEL_HIGH;
> +
> + virq = irq_create_fwspec_mapping(&fwspec);
> + if (!virq) {
> + return dev_err_probe(dev, -EINVAL, "failed to create IRQ mapping for %s\n",
> + icu_err);
> + }
> +
> + ret = devm_request_irq(dev, virq, rzv2h_icu_error_irq, 0, dev_name(dev), rzv2h_icu_data);
> + if (ret)
> + return dev_err_probe(dev, ret, "Failed to request %s IRQ\n", icu_err);
> +
> return 0;
It seems to me like the error path and possibly unload path need call
to irq_dispose_mapping()?
Best regards,
Pavel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 6.1.y-cip 09/11] irqchip/renesas-rzv2h: Kill swint_idx[]
2026-09-02 9:23 [PATCH 6.1.y-cip 00/11] Add ICU error and software interrupt support for RZ/V2H and RZ/V2N Ovidiu Panait
` (7 preceding siblings ...)
2026-09-02 9:23 ` [PATCH 6.1.y-cip 08/11] irqchip/renesas-rzv2h: Handle ICU error IRQ and add SWPE trigger Ovidiu Panait
@ 2026-09-02 9:23 ` Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 10/11] irqchip/renesas-rzv2h: Kill swint_names[] Ovidiu Panait
` (3 subsequent siblings)
12 siblings, 0 replies; 16+ messages in thread
From: Ovidiu Panait @ 2026-09-02 9:23 UTC (permalink / raw)
To: cip-dev, pavel, nobuhiro.iwamatsu.x90
From: Geert Uytterhoeven <geert+renesas@glider.be>
commit fc4c926ccd34d4ee75669991693b47a9b8645a6c upstream.
The array swint_idx[] just contains an identity mapping.
Replace it by using the index directly, to simplify the code.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Link: https://patch.msgid.link/0f32ba2a4701311710d02ff4fa2fd472b56745c4.1775205874.git.geert+renesas@glider.be
Signed-off-by: Ovidiu Panait <ovidiu.panait.rb@renesas.com>
---
drivers/irqchip/irq-renesas-rzv2h.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/irqchip/irq-renesas-rzv2h.c b/drivers/irqchip/irq-renesas-rzv2h.c
index ce5773d7ceb0..6c1b17e1ed69 100644
--- a/drivers/irqchip/irq-renesas-rzv2h.c
+++ b/drivers/irqchip/irq-renesas-rzv2h.c
@@ -748,7 +748,7 @@ static irqreturn_t rzv2h_icu_error_irq(int irq, void *data)
static irqreturn_t rzv2h_icu_swint_irq(int irq, void *data)
{
- u8 cpu = *(u8 *)data;
+ unsigned int cpu = (uintptr_t)data;
pr_info("SWINT interrupt for CA55 core %u\n", cpu);
return IRQ_HANDLED;
@@ -763,7 +763,6 @@ static int rzv2h_icu_setup_irqs(struct platform_device *pdev, struct irq_domain
"int-ca55-2", "int-ca55-3",
};
static const char *icu_err = "icu-error-ca55";
- static const u8 swint_idx[] = { 0, 1, 2, 3 };
void __iomem *base = rzv2h_icu_data->base;
struct device *dev = &pdev->dev;
struct irq_fwspec fwspec;
@@ -783,7 +782,7 @@ static int rzv2h_icu_setup_irqs(struct platform_device *pdev, struct irq_domain
}
ret = devm_request_irq(dev, virq, rzv2h_icu_swint_irq, 0, dev_name(dev),
- (void *)&swint_idx[i]);
+ (void *)(uintptr_t)i);
if (ret) {
return dev_err_probe(dev, ret, "Failed to request %s IRQ\n",
rzv2h_swint_names[i]);
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 6.1.y-cip 10/11] irqchip/renesas-rzv2h: Kill swint_names[]
2026-09-02 9:23 [PATCH 6.1.y-cip 00/11] Add ICU error and software interrupt support for RZ/V2H and RZ/V2N Ovidiu Panait
` (8 preceding siblings ...)
2026-09-02 9:23 ` [PATCH 6.1.y-cip 09/11] irqchip/renesas-rzv2h: Kill swint_idx[] Ovidiu Panait
@ 2026-09-02 9:23 ` Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 11/11] irqchip/renesas-rzv2h: Kill icu_err string Ovidiu Panait
` (2 subsequent siblings)
12 siblings, 0 replies; 16+ messages in thread
From: Ovidiu Panait @ 2026-09-02 9:23 UTC (permalink / raw)
To: cip-dev, pavel, nobuhiro.iwamatsu.x90
From: Geert Uytterhoeven <geert+renesas@glider.be>
commit 8c7ffedff0db88837de11cfaf3e5367e0b77bc4c upstream.
The array swint_names[] just contains expansions of "int-ca55-%u".
Replace it by formatting the strings where needed, to improve
readability.
Despite the two error messages can no longer be shared with the ICU
error cases, this reduces generated code size by 56 bytes.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Link: https://patch.msgid.link/aceab3fbc307ef428dfd62d8d846b68704dea012.1775205874.git.geert+renesas@glider.be
Signed-off-by: Ovidiu Panait <ovidiu.panait.rb@renesas.com>
---
drivers/irqchip/irq-renesas-rzv2h.c | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/irqchip/irq-renesas-rzv2h.c b/drivers/irqchip/irq-renesas-rzv2h.c
index 6c1b17e1ed69..e5e1982b2c15 100644
--- a/drivers/irqchip/irq-renesas-rzv2h.c
+++ b/drivers/irqchip/irq-renesas-rzv2h.c
@@ -758,10 +758,6 @@ static int rzv2h_icu_setup_irqs(struct platform_device *pdev, struct irq_domain
{
const struct rzv2h_hw_info *hw_info = rzv2h_icu_data->info;
bool irq_inject = IS_ENABLED(CONFIG_GENERIC_IRQ_INJECTION);
- static const char * const rzv2h_swint_names[] = {
- "int-ca55-0", "int-ca55-1",
- "int-ca55-2", "int-ca55-3",
- };
static const char *icu_err = "icu-error-ca55";
void __iomem *base = rzv2h_icu_data->base;
struct device *dev = &pdev->dev;
@@ -777,16 +773,14 @@ static int rzv2h_icu_setup_irqs(struct platform_device *pdev, struct irq_domain
virq = irq_create_fwspec_mapping(&fwspec);
if (!virq) {
- return dev_err_probe(dev, -EINVAL, "failed to create IRQ mapping for %s\n",
- rzv2h_swint_names[i]);
+ return dev_err_probe(dev, -EINVAL,
+ "failed to create int-ca55-%u IRQ mapping\n", i);
}
ret = devm_request_irq(dev, virq, rzv2h_icu_swint_irq, 0, dev_name(dev),
(void *)(uintptr_t)i);
- if (ret) {
- return dev_err_probe(dev, ret, "Failed to request %s IRQ\n",
- rzv2h_swint_names[i]);
- }
+ if (ret)
+ return dev_err_probe(dev, ret, "Failed to request int-ca55-%u IRQ\n", i);
}
/* Unmask and clear all IP/CA55 error interrupts */
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 6.1.y-cip 11/11] irqchip/renesas-rzv2h: Kill icu_err string
2026-09-02 9:23 [PATCH 6.1.y-cip 00/11] Add ICU error and software interrupt support for RZ/V2H and RZ/V2N Ovidiu Panait
` (9 preceding siblings ...)
2026-09-02 9:23 ` [PATCH 6.1.y-cip 10/11] irqchip/renesas-rzv2h: Kill swint_names[] Ovidiu Panait
@ 2026-09-02 9:23 ` Ovidiu Panait
2026-09-02 17:00 ` [PATCH 6.1.y-cip 00/11] Add ICU error and software interrupt support for RZ/V2H and RZ/V2N Pavel Machek
2026-09-03 19:33 ` Pavel Machek
12 siblings, 0 replies; 16+ messages in thread
From: Ovidiu Panait @ 2026-09-02 9:23 UTC (permalink / raw)
To: cip-dev, pavel, nobuhiro.iwamatsu.x90
From: Geert Uytterhoeven <geert+renesas@glider.be>
commit 669d2067e3d095d525c69e675d8b9c738e3616c6 upstream.
Replace the string variable icu_err by its expanded value where needed,
to improve readability.
This reduces generated code size by 16 bytes.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Link: https://patch.msgid.link/c7472bec20dea2c4d63e390e8e293b7d7003ef39.1775205874.git.geert+renesas@glider.be
Signed-off-by: Ovidiu Panait <ovidiu.panait.rb@renesas.com>
---
drivers/irqchip/irq-renesas-rzv2h.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/irqchip/irq-renesas-rzv2h.c b/drivers/irqchip/irq-renesas-rzv2h.c
index e5e1982b2c15..0e0c3b3e85bd 100644
--- a/drivers/irqchip/irq-renesas-rzv2h.c
+++ b/drivers/irqchip/irq-renesas-rzv2h.c
@@ -758,7 +758,6 @@ static int rzv2h_icu_setup_irqs(struct platform_device *pdev, struct irq_domain
{
const struct rzv2h_hw_info *hw_info = rzv2h_icu_data->info;
bool irq_inject = IS_ENABLED(CONFIG_GENERIC_IRQ_INJECTION);
- static const char *icu_err = "icu-error-ca55";
void __iomem *base = rzv2h_icu_data->base;
struct device *dev = &pdev->dev;
struct irq_fwspec fwspec;
@@ -803,14 +802,12 @@ static int rzv2h_icu_setup_irqs(struct platform_device *pdev, struct irq_domain
fwspec.param[1] = IRQ_TYPE_LEVEL_HIGH;
virq = irq_create_fwspec_mapping(&fwspec);
- if (!virq) {
- return dev_err_probe(dev, -EINVAL, "failed to create IRQ mapping for %s\n",
- icu_err);
- }
+ if (!virq)
+ return dev_err_probe(dev, -EINVAL, "failed to create icu-error-ca55 IRQ mapping\n");
ret = devm_request_irq(dev, virq, rzv2h_icu_error_irq, 0, dev_name(dev), rzv2h_icu_data);
if (ret)
- return dev_err_probe(dev, ret, "Failed to request %s IRQ\n", icu_err);
+ return dev_err_probe(dev, ret, "Failed to request icu-error-ca55 IRQ\n");
return 0;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 6.1.y-cip 00/11] Add ICU error and software interrupt support for RZ/V2H and RZ/V2N
2026-09-02 9:23 [PATCH 6.1.y-cip 00/11] Add ICU error and software interrupt support for RZ/V2H and RZ/V2N Ovidiu Panait
` (10 preceding siblings ...)
2026-09-02 9:23 ` [PATCH 6.1.y-cip 11/11] irqchip/renesas-rzv2h: Kill icu_err string Ovidiu Panait
@ 2026-09-02 17:00 ` Pavel Machek
2026-09-03 19:33 ` Pavel Machek
12 siblings, 0 replies; 16+ messages in thread
From: Pavel Machek @ 2026-09-02 17:00 UTC (permalink / raw)
To: Ovidiu Panait; +Cc: cip-dev, pavel, nobuhiro.iwamatsu.x90
[-- Attachment #1: Type: text/plain, Size: 476 bytes --]
Hi!
> This series adds support for error and software interrupts in the ICU
> driver for the Renesas RZ/V2H and RZ/V2N SoCs.
I had some minor comments here, but those should be fixed in mainline,
first, so they should not block the merge.
This looks okay to me.
Reviewed-by: Pavel Machek <pavel@nabladev.com>
I can apply the series if it passes testing and there are no other
comments.
Best regards,
Pavel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 6.1.y-cip 00/11] Add ICU error and software interrupt support for RZ/V2H and RZ/V2N
2026-09-02 9:23 [PATCH 6.1.y-cip 00/11] Add ICU error and software interrupt support for RZ/V2H and RZ/V2N Ovidiu Panait
` (11 preceding siblings ...)
2026-09-02 17:00 ` [PATCH 6.1.y-cip 00/11] Add ICU error and software interrupt support for RZ/V2H and RZ/V2N Pavel Machek
@ 2026-09-03 19:33 ` Pavel Machek
12 siblings, 0 replies; 16+ messages in thread
From: Pavel Machek @ 2026-09-03 19:33 UTC (permalink / raw)
To: Ovidiu Panait; +Cc: cip-dev, pavel, nobuhiro.iwamatsu.x90
[-- Attachment #1: Type: text/plain, Size: 241 bytes --]
Hi!
> This series adds support for error and software interrupts in the ICU
> driver for the Renesas RZ/V2H and RZ/V2N SoCs.
>
> Patches were cherry-picked from mainline kernel.
Thank you, applied.
Best regards,
Pavel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread