* [Cluster-devel] Re: [PATCH 5/7] gfs2: Remove code handling bio_alloc failure with __GFP_WAIT [not found] <200904151036.35481.knikanth@suse.de> @ 2009-04-15 8:58 ` Steven Whitehouse [not found] ` <20090415090136.GT5178@kernel.dk> 0 siblings, 1 reply; 2+ messages in thread From: Steven Whitehouse @ 2009-04-15 8:58 UTC (permalink / raw) To: cluster-devel.redhat.com Hi, Acked-by: Steven Whitehouse <swhiteho@redhat.com> I could put this in my tree, but I think that Jens is going to push this one to Linus, so I'm holding off, Steve. On Wed, 2009-04-15 at 10:36 +0530, Nikanth Karthikesan wrote: > Remove code handling bio_alloc failure with __GFP_WAIT. > GFP_NOFS implies __GFP_WAIT. > > Signed-off-by: Nikanth Karthikesan <knikanth@suse.de> > > --- > > diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c > index 51883b3..650a730 100644 > --- a/fs/gfs2/ops_fstype.c > +++ b/fs/gfs2/ops_fstype.c > @@ -272,11 +272,6 @@ static int gfs2_read_super(struct gfs2_sbd *sdp, sector_t sector) > lock_page(page); > > bio = bio_alloc(GFP_NOFS, 1); > - if (unlikely(!bio)) { > - __free_page(page); > - return -ENOBUFS; > - } > - > bio->bi_sector = sector * (sb->s_blocksize >> 9); > bio->bi_bdev = sb->s_bdev; > bio_add_page(bio, page, PAGE_SIZE, 0); > ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <20090415090136.GT5178@kernel.dk>]
* [Cluster-devel] Re: [PATCH 5/7] gfs2: Remove code handling bio_alloc failure with __GFP_WAIT [not found] ` <20090415090136.GT5178@kernel.dk> @ 2009-04-15 9:05 ` Steven Whitehouse 0 siblings, 0 replies; 2+ messages in thread From: Steven Whitehouse @ 2009-04-15 9:05 UTC (permalink / raw) To: cluster-devel.redhat.com Hi, On Wed, 2009-04-15 at 11:01 +0200, Jens Axboe wrote: > On Wed, Apr 15 2009, Steven Whitehouse wrote: > > Hi, > > > > Acked-by: Steven Whitehouse <swhiteho@redhat.com> > > > > I could put this in my tree, but I think that Jens is going to push this > > one to Linus, so I'm holding off, > > Not much point in splitting it up for the trivial bits, unless you want > to. I'll add your acked-by. > Yes, I agree. Sounds good to me, Steve. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-15 9:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200904151036.35481.knikanth@suse.de>
2009-04-15 8:58 ` [Cluster-devel] Re: [PATCH 5/7] gfs2: Remove code handling bio_alloc failure with __GFP_WAIT Steven Whitehouse
[not found] ` <20090415090136.GT5178@kernel.dk>
2009-04-15 9:05 ` Steven Whitehouse
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox