* [PATCH 1/1] restore_ipc_ns: set ret=0 if no error
@ 2009-06-15 20:59 Serge E. Hallyn
[not found] ` <20090615205911.GA18820-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Serge E. Hallyn @ 2009-06-15 20:59 UTC (permalink / raw)
To: Oren Laadan; +Cc: Linux Containers
Why pretend there's an error when there isn't?
(Without this, all restarts fail with CONFIG_UTS_NS or CONFIG_IPC_NS
on)
Signed-off-by: Serge E. Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
---
kernel/nsproxy.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/kernel/nsproxy.c b/kernel/nsproxy.c
index e3db0b9..5fae13c 100644
--- a/kernel/nsproxy.c
+++ b/kernel/nsproxy.c
@@ -308,6 +308,7 @@ static struct nsproxy *do_restore_ns(struct ckpt_ctx *ctx)
nsproxy = create_nsproxy();
if (!nsproxy)
goto out;
+ ret = 0;
get_uts_ns(uts_ns);
nsproxy->uts_ns = uts_ns;
--
1.6.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] restore_ipc_ns: set ret=0 if no error
[not found] ` <20090615205911.GA18820-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
@ 2009-06-15 23:02 ` Oren Laadan
0 siblings, 0 replies; 2+ messages in thread
From: Oren Laadan @ 2009-06-15 23:02 UTC (permalink / raw)
To: Serge E. Hallyn; +Cc: Linux Containers
Heh .. I already hit this one and fixed - I am finishing a few more
fixes before pushing them all.
Thanks :)
Serge E. Hallyn wrote:
> Why pretend there's an error when there isn't?
>
> (Without this, all restarts fail with CONFIG_UTS_NS or CONFIG_IPC_NS
> on)
>
> Signed-off-by: Serge E. Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> ---
> kernel/nsproxy.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/nsproxy.c b/kernel/nsproxy.c
> index e3db0b9..5fae13c 100644
> --- a/kernel/nsproxy.c
> +++ b/kernel/nsproxy.c
> @@ -308,6 +308,7 @@ static struct nsproxy *do_restore_ns(struct ckpt_ctx *ctx)
> nsproxy = create_nsproxy();
> if (!nsproxy)
> goto out;
> + ret = 0;
>
> get_uts_ns(uts_ns);
> nsproxy->uts_ns = uts_ns;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-15 23:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-15 20:59 [PATCH 1/1] restore_ipc_ns: set ret=0 if no error Serge E. Hallyn
[not found] ` <20090615205911.GA18820-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-15 23:02 ` Oren Laadan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox