From: Dave Jones <davej@redhat.com>
To: aeriksson@fastmail.fm, Arjan van de Ven <arjanv@redhat.com>,
cpufreq@www.linux.org.uk
Subject: Re: speedstep capability checks
Date: Mon, 15 Mar 2004 21:09:50 +0000 [thread overview]
Message-ID: <20040315210950.GC15243@redhat.com> (raw)
In-Reply-To: <20040315141517.GG8636@dominikbrodowski.de>
On Mon, Mar 15, 2004 at 03:15:17PM +0100, Dominik Brodowski wrote:
> @@ -265,6 +272,12 @@
> ebx = cpuid_ebx(0x00000001);
>
> ebx &= 0x000000FF;
> +
> + /* Arjan reported a strange mobile PIII-M where ebx is
> + 0x07 */
> + if ((ebx == 0x07) && relaxed_check)
> + return SPEEDSTEP_PROCESSOR_PIII_T;
> +
> if (ebx != 0x06)
> return 0;
Any reason we can't just check the ebx==0x07, guarded with appropriate
checks on model/stepping/brand ? The relaxed_check stuff does seem quite ugly to me.
Dave
next prev parent reply other threads:[~2004-03-15 21:09 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-14 15:20 speedstep capability checks aeriksson
2004-03-15 14:15 ` Dominik Brodowski
2004-03-08 11:15 ` add new p3m model Arjan van de Ven
2004-03-08 11:47 ` Bas Mevissen
2004-03-08 11:46 ` Arjan van de Ven
2004-03-08 12:08 ` Bas Mevissen
2004-03-08 13:31 ` Bruno Ducrot
2004-03-14 14:34 ` Dominik Brodowski
2004-03-15 14:21 ` Arjan van de Ven
2004-03-15 14:38 ` Dominik Brodowski
2004-03-15 14:45 ` Arjan van de Ven
2004-03-15 15:46 ` Bruno Ducrot
2004-03-15 15:55 ` Dave Jones
2004-03-15 14:20 ` speedstep capability checks Arjan van de Ven
2004-03-15 15:37 ` Bruno Ducrot
2004-03-15 19:25 ` aeriksson
2004-03-15 19:35 ` Bruno Ducrot
2004-03-15 19:44 ` Arjan van de Ven
2004-03-15 19:50 ` [updated patch] " Dominik Brodowski
2004-03-15 21:09 ` Dave Jones [this message]
2004-03-16 7:38 ` Dominik Brodowski
2004-03-16 13:01 ` Dave Jones
2004-03-16 15:01 ` Bruno Ducrot
2004-03-16 15:58 ` Dominik Brodowski
2004-03-16 16:00 ` Dominik Brodowski
2004-03-16 16:36 ` Bruno Ducrot
2004-03-18 19:57 ` aeriksson
2004-03-19 11:06 ` Bruno Ducrot
2004-03-15 18:36 ` Bruno Ducrot
2004-03-15 19:20 ` aeriksson
2004-03-15 19:36 ` Bruno Ducrot
2004-03-15 19:46 ` Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040315210950.GC15243@redhat.com \
--to=davej@redhat.com \
--cc=aeriksson@fastmail.fm \
--cc=arjanv@redhat.com \
--cc=cpufreq@www.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox