cpufreq Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dominik Brodowski <linux@dominikbrodowski.net>
To: davej@redhat.com, cpufreq@lists.linux.org.uk
Subject: [PATCH 005/007] cpufreq_ondemand: Warn if it cannot run due to too long transition latency
Date: Sun, 26 Mar 2006 11:57:12 +0200	[thread overview]
Message-ID: <20060326095712.GF17358@dominikbrodowski.de> (raw)
In-Reply-To: <20060326095338.GA17358@dominikbrodowski.de>

From: Eric Piel <Eric.Piel@tremplin-utc.net>

Display a warning if the ondemand governor can not be selected due to a
transition latency of the cpufreq driver which is too long.

Signed-off-by: Eric Piel <eric.piel@tremplin-utc.net>
Acked-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>

---

 drivers/cpufreq/cpufreq_ondemand.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

ff8c288d7d1a368b663058cdee1ea0adcdef2fa2
diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c
index 69aa1db..6430489 100644
--- a/drivers/cpufreq/cpufreq_ondemand.c
+++ b/drivers/cpufreq/cpufreq_ondemand.c
@@ -395,8 +395,11 @@ static int cpufreq_governor_dbs(struct c
 			return -EINVAL;
 
 		if (policy->cpuinfo.transition_latency >
-				(TRANSITION_LATENCY_LIMIT * 1000))
+				(TRANSITION_LATENCY_LIMIT * 1000)) {
+			printk(KERN_WARNING "ondemand governor failed to load "
+			       "due to too long transition latency\n");
 			return -EINVAL;
+		}
 		if (this_dbs_info->enable) /* Already enabled */
 			break;
 
-- 
1.2.4

  parent reply	other threads:[~2006-03-26  9:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-26  9:53 [git pull] cpufreq governor updates for 2.6.17 Dominik Brodowski
2006-03-26  9:54 ` [PATCH 001/007] cpufreq_conservative: aligning of codebase with ondemand Dominik Brodowski
2006-03-26  9:55 ` [PATCH 002/007] cpufreq_conservative: alter default responsiveness Dominik Brodowski
2006-03-26  9:55 ` [PATCH 003/007] cpufreq_conservative: make for_each_cpu() safe Dominik Brodowski
2006-03-26  9:56 ` [PATCH 004/007] cpufreq_conservative: alternative initialise approach Dominik Brodowski
2006-03-26  9:57 ` Dominik Brodowski [this message]
2006-03-26  9:57 ` [PATCH 006/007] cpufreq_ondemand: keep ignore_nice_load value when it is reselected Dominik Brodowski
2006-03-26  9:57 ` [PATCH 007/007] cpufreq_ondemand: add range check Dominik Brodowski
2006-03-27 19:53 ` [git pull] cpufreq governor updates for 2.6.17 Dave Jones
2006-03-27 19:58   ` Dave Jones
2006-03-27 21:06     ` Dominik Brodowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060326095712.GF17358@dominikbrodowski.de \
    --to=linux@dominikbrodowski.net \
    --cc=cpufreq@lists.linux.org.uk \
    --cc=davej@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox