DAMON development mailing list
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "SeongJae Park" <sj@kernel.org>
Cc: damon@lists.linux.dev
Subject: Re: [RFC PATCH 2/2] mm/damon/sysfs-schemes: protect path kfree() with damon_sysfs_lock
Date: Wed, 22 Apr 2026 21:02:21 +0000	[thread overview]
Message-ID: <20260422210221.A666EC19425@smtp.kernel.org> (raw)
In-Reply-To: <20260422143503.71357-3-sj@kernel.org>

Sashiko AI review found 1 potential issue(s):
- [Low] The commit message incorrectly references the `memcg_path` file instead of the `path` file.
--

commit 9335b00570732d12b29034fc72a20506fd69fbdd
Author: SeongJae Park <sj@kernel.org>

mm/damon/sysfs-schemes: protect path kfree() with damon_sysfs_lock

This commit adds damon_sysfs_lock protection to the path attribute's sysfs show
and store functions. This prevents a use-after-free race condition during
concurrent user-driven reads and writes.

> damon_sysfs_quot_goal->path can be read and written by users, via DAMON
> sysfs memcg_path file.  It can also be indirectly read, for the

This isn't a bug, but the commit message references the memcg_path sysfs file.
Since the patch actually modifies path_show and path_store, which handle the
path attribute for quota goals, should this say "via DAMON sysfs path file"
instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260422143503.71357-1-sj@kernel.org?part=2

  reply	other threads:[~2026-04-22 21:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-22 14:34 [RFC PATCH 0/2] mm/damon/sysfs-schemes: fix use-after-free for [memcg_]path SeongJae Park
2026-04-22 14:35 ` [RFC PATCH 1/2] mm/damon/sysfs-schemes: protect memcg_path kfree() with damon_sysfs_lock SeongJae Park
2026-04-22 20:30   ` sashiko-bot
2026-04-23  0:41     ` SeongJae Park
2026-04-22 14:35 ` [RFC PATCH 2/2] mm/damon/sysfs-schemes: protect path " SeongJae Park
2026-04-22 21:02   ` sashiko-bot [this message]
2026-04-23  0:46     ` SeongJae Park
2026-04-22 14:40 ` [RFC PATCH 0/2] mm/damon/sysfs-schemes: fix use-after-free for [memcg_]path SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260422210221.A666EC19425@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=damon@lists.linux.dev \
    --cc=sashiko@lists.linux.dev \
    --cc=sj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox