Re: [RFC PATCH 2/2] mm/damon/sysfs-schemes: protect path kfree() with damon_sysfs_lock

[SeongJae Park <sj@kernel.org>]

On Wed, 22 Apr 2026 21:02:21 +0000 sashiko-bot@kernel.org wrote:

> Sashiko AI review found 1 potential issue(s):
> - [Low] The commit message incorrectly references the `memcg_path` file instead of the `path` file.
> --
> 
> commit 9335b00570732d12b29034fc72a20506fd69fbdd
> Author: SeongJae Park <sj@kernel.org>
> 
> mm/damon/sysfs-schemes: protect path kfree() with damon_sysfs_lock
> 
> This commit adds damon_sysfs_lock protection to the path attribute's sysfs show
> and store functions. This prevents a use-after-free race condition during
> concurrent user-driven reads and writes.
> 
> > damon_sysfs_quot_goal->path can be read and written by users, via DAMON
> > sysfs memcg_path file.  It can also be indirectly read, for the
> 
> This isn't a bug, but the commit message references the memcg_path sysfs file.
> Since the patch actually modifies path_show and path_store, which handle the
> path attribute for quota goals, should this say "via DAMON sysfs path file"
> instead?

Good finding.  I will fix this in the next revision.

> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260422143503.71357-1-sj@kernel.org?part=2
> 


Thanks,
SJ