Re: [RFC PATCH v2.2 24/28] mm/damon/sysfs: add filters/<F>/path file

[SeongJae Park <sj@kernel.org>]

On Fri, 15 May 2026 01:35:11 +0000 sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The sysfs file is named 'path', but the commit message body claims it is named 'filter'.
> --
> 
> commit de3638dbf8d1acc9d36bc5e5de54362c9f8fe540
> Author: SeongJae Park <sj@kernel.org>
> 
> mm/damon/sysfs: add filters/<F>/path file
> 
> Introduces a new DAMON sysfs file to allow users to set the target memory
> cgroup for memory cgroup attribute monitoring. Users write the path of the
> memcg to this file.
> 
> > Introduce a new DAMON sysfs file for letting users setup the target
> > memory cgroup of the belonging memory cgroup attribute monitoring.  The
> > file is named 'filter', located under the probe filter directory.  Users
> > can set the target memory cgroup by writing the path to the memory
> > cgroup from the cgroup mount point to the file.
> 
> This isn't a bug, but the commit message states the file is named 'filter',
> while the subject line and the newly added code define the attribute as
> 'path'. Could the commit message be updated to more precisely match the
> actual sysfs file name?

Good finding!  I will fix.


Thanks,
SJ

[...]