Re: [RFC PATCH v1.1 12/13] mm/damon/core: remove damon_moving_sum() and its unit test

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `attrs` parameter in `damon_update_region_access_rate()` is completely unused and should be removed.
--

commit 4c4d26b15dff409f33a357a198fe9f93686b61be
Author: SeongJae Park <sj@kernel.org>

mm/damon/core: remove damon_moving_sum() and its unit test

This commit removes the damon_moving_sum() function and its associated unit
test, as the function is no longer used for any practical purpose.

> diff --git a/mm/damon/core.c b/mm/damon/core.c
> index a41b66b26a472..670cbfdf880ce 100644
> --- a/mm/damon/core.c
> +++ b/mm/damon/core.c

[ ... ]

> -static unsigned int damon_moving_sum(unsigned int mvsum, unsigned int nomvsum,
> -		unsigned int len_window, unsigned int new_value)
> -{
> -	return mvsum - nomvsum / len_window + new_value;
> -}
> -
>  /**
>   * damon_update_region_access_rate() - Update the access rate of a region.
>   * @r:		The DAMON region to update for its access check result.

[Severity: Low]
Are we able to drop the attrs parameter from this function now?

Following the removal of damon_moving_sum(), the attrs parameter is no longer
used in the body of damon_update_region_access_rate():

mm/damon/core.c:damon_update_region_access_rate() {
	if (accessed)
		r->nr_accesses++;
}

Would it make sense to remove the attrs parameter from the prototype in
include/linux/damon.h and from this function definition?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260620172244.90953-1-sj@kernel.org?part=12