From: sashiko-bot@kernel.org
To: "SJ Park" <sj@kernel.org>
Cc: damon@lists.linux.dev
Subject: Re: [PATCH 02/12] mm/damon/core: remove debug messages
Date: Wed, 02 Sep 2026 05:52:09 +0000 [thread overview]
Message-ID: <20260902055210.2D9401F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260902054747.99370-3-sj@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch removed the last usage of `str_high_low()` but did not remove the now-unused `#include <linux/string_choices.h>`.
--
commit 43d661e4f50bbdfb8a2cca56bf761ac52256d5cd
Author: SJ Park <sj@kernel.org>
mm/damon/core: remove debug messages
This patch removes several unused debug messages from the DAMON core to
clean up the code.
> diff --git a/mm/damon/core.c b/mm/damon/core.c
> index bda8e23c10560..3e42f370ea67f 100644
> --- a/mm/damon/core.c
> +++ b/mm/damon/core.c
> @@ -3729,10 +3729,6 @@ static unsigned long damos_wmark_wait_us(struct damos *scheme)
>
> /* higher than high watermark or lower than low watermark */
> if (metric > scheme->wmarks.high || scheme->wmarks.low > metric) {
> - if (scheme->wmarks.activated)
> - pr_debug("deactivate a scheme (%d) for %s wmark\n",
> - scheme->action,
> - str_high_low(metric > scheme->wmarks.high));
[Severity: Low]
Since this removes the last usage of str_high_low() in mm/damon/core.c,
should the include for <linux/string_choices.h> near line 18 also be
removed?
> scheme->wmarks.activated = false;
> return scheme->wmarks.interval;
> }
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260902054747.99370-1-sj@kernel.org?part=2
next prev parent reply other threads:[~2026-09-02 5:52 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 5:47 [PATCH 00/12] mm/damon: cleanup code, add test cases, and update guidances in docs SJ Park
2026-09-02 5:47 ` [PATCH 01/12] mm/damon/core: use damon_nr_samples_per_aggr() for max merge threshold SJ Park
2026-09-02 5:53 ` sashiko-bot
2026-09-03 2:00 ` Kunwu Chan
2026-09-02 5:47 ` [PATCH 02/12] mm/damon/core: remove debug messages SJ Park
2026-09-02 5:52 ` sashiko-bot [this message]
2026-09-02 6:11 ` SJ Park
2026-09-02 6:14 ` SJ Park
2026-09-02 5:47 ` [PATCH 03/12] mm/damon/vaddr: remove a debug message SJ Park
2026-09-02 5:50 ` sashiko-bot
2026-09-03 2:24 ` Kunwu Chan
2026-09-02 5:47 ` [PATCH 04/12] mm/damon/core: validate number of probes in valid_probe_params() SJ Park
2026-09-02 6:02 ` sashiko-bot
2026-09-02 15:32 ` Kunwu Chan
2026-09-02 5:47 ` [PATCH 05/12] mm/damon/sysfs: remove probes number validation SJ Park
2026-09-02 5:59 ` sashiko-bot
2026-09-02 14:07 ` Kunwu Chan
2026-09-02 14:37 ` SJ Park
2026-09-02 15:33 ` Kunwu Chan
2026-09-02 5:47 ` [PATCH 06/12] mm/damon/tests/core-kunit: extend set_regions() test for error case SJ Park
2026-09-02 5:56 ` sashiko-bot
2026-09-02 5:47 ` [PATCH 07/12] mm/damon/tests/core-kunit: test <=0 size damon_set_regions() inputs SJ Park
2026-09-02 5:52 ` sashiko-bot
2026-09-02 5:47 ` [PATCH 08/12] mm/damon/tests/core-kunit: test overlapping ranges for set_regions() SJ Park
2026-09-02 5:56 ` sashiko-bot
2026-09-03 3:04 ` Kunwu Chan
2026-09-02 5:47 ` [PATCH 09/12] mm/damon/tests/core-kunit: test damon_nr_samples_per_aggr() SJ Park
2026-09-02 5:54 ` sashiko-bot
2026-09-02 15:08 ` Kunwu Chan
2026-09-02 15:19 ` SJ Park
2026-09-02 15:49 ` Kunwu Chan
2026-09-03 0:22 ` SJ Park
2026-09-02 5:47 ` [PATCH 10/12] selftests/damon/sysfs.sh: test hugepage_mem_bp quota goal SJ Park
2026-09-02 5:54 ` sashiko-bot
2026-09-03 3:06 ` Kunwu Chan
2026-09-02 5:47 ` [PATCH 11/12] Docs/mm/damon/maintainer-profile: update AI review for Sashiko replies SJ Park
2026-09-02 5:54 ` sashiko-bot
2026-09-02 5:47 ` [PATCH 12/12] Docs/ABI/damon: recommend subsystem doc instead of admin-guide SJ Park
2026-09-02 5:55 ` sashiko-bot
2026-09-03 3:09 ` Kunwu Chan
2026-09-02 6:16 ` [PATCH 00/12] mm/damon: cleanup code, add test cases, and update guidances in docs SJ Park
2026-09-02 22:42 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902055210.2D9401F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=damon@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox