Re: [PATCH 02/12] mm/damon/core: remove debug messages

[SJ Park <sj@kernel.org>]

On Wed, 02 Sep 2026 05:52:09 +0000 sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The patch removed the last usage of `str_high_low()` but did not remove the now-unused `#include <linux/string_choices.h>`.
> --
> 
> commit 43d661e4f50bbdfb8a2cca56bf761ac52256d5cd
> Author: SJ Park <sj@kernel.org>
> 
> mm/damon/core: remove debug messages
> 
> This patch removes several unused debug messages from the DAMON core to
> clean up the code.
> 
> > diff --git a/mm/damon/core.c b/mm/damon/core.c
> > index bda8e23c10560..3e42f370ea67f 100644
> > --- a/mm/damon/core.c
> > +++ b/mm/damon/core.c
> > @@ -3729,10 +3729,6 @@ static unsigned long damos_wmark_wait_us(struct damos *scheme)
> >  
> >  	/* higher than high watermark or lower than low watermark */
> >  	if (metric > scheme->wmarks.high || scheme->wmarks.low > metric) {
> > -		if (scheme->wmarks.activated)
> > -			pr_debug("deactivate a scheme (%d) for %s wmark\n",
> > -				 scheme->action,
> > -				 str_high_low(metric > scheme->wmarks.high));
> 
> [Severity: Low]
> Since this removes the last usage of str_high_low() in mm/damon/core.c,
> should the include for <linux/string_choices.h> near line 18 also be
> removed?

Good catch.  And this is the only finding on this version of this series.
Maybe reposting entire series for this small change is too much.  I will ask
Andrew's help.

> 
> >  		scheme->wmarks.activated = false;
> >  		return scheme->wmarks.interval;
> >  	}
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260902054747.99370-1-sj@kernel.org?part=2


Thanks,
SJ