Re: [RFC PATCH v2.2 3/7] mm/damon/core: support probe_hits_wsum damos core filter

[SJ Park <sj@kernel.org>]

On Fri, 11 Sep 2026 01:22:48 +0000 sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] Missing test coverage for new DAMOS_FILTER_TYPE_PROBE_HITS_WSUM filter type.
> --
> 
> commit 6772f4f420525d4fa844eff78fb5f202b6550013
> Author: SJ Park <sj@kernel.org>
> 
> mm/damon/core: support probe_hits_wsum damos core filter
> 
> Implement probe_hits_wsum DAMOS core filter support in the core layer
> by updating filter operations, argument commits, and match handlers.
> 
> > diff --git a/mm/damon/core.c b/mm/damon/core.c
> > index e9630f41e51fe..d9d56f4be1a97 100644
> > --- a/mm/damon/core.c
> > +++ b/mm/damon/core.c
> [ ... ]
> > @@ -1332,6 +1333,10 @@ static void damos_commit_filter_arg(
> >  	case DAMOS_FILTER_TYPE_HUGEPAGE_SIZE:
> >  		dst->sz_range = src->sz_range;
> >  		break;
> > +	case DAMOS_FILTER_TYPE_PROBE_HITS_WSUM:
> > +		dst->range_min = src->range_min;
> > +		dst->range_max = src->range_max;
> > +		break;
> 
> [Severity: Medium]
> Should this new filter type also be added to the kunit tests in
> mm/damon/tests/core-kunit.h?
> 
> Looking at mm/damon/tests/core-kunit.h, damos_test_commit_filter_for() has a
> switch statement verifying that filter arguments are copied, but it lacks a
> case to verify range_min and range_max for DAMOS_FILTER_TYPE_PROBE_HITS_WSUM.
> 
> Similarly, damos_test_commit_filter() invokes tests for all other filter types
> but seems to omit the newly added DAMOS_FILTER_TYPE_PROBE_HITS_WSUM.
> 
> Could test coverage be added for this new filter type to prevent future
> regressions?

We could improve the test coverage, but it is not a blocker of this patch.  I
will consider adding the test in future.

> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260911011330.93678-1-sj@kernel.org?part=3


Thanks,
SJ