From: SJ Park <sj@kernel.org>
To: Aveline Noir <jm5905938@gmail.com>
Cc: SJ Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, linux-mm@kvack.org
Subject: Re: [PATCH 03/27] mm/damon/core: introduce damon_submit_report()
Date: Sun, 22 Nov 2026 09:15:24 -0800 [thread overview]
Message-ID: <20261122171525.153150-1-sj@kernel.org> (raw)
In-Reply-To: <CANOyQmH5FX18LmMW+QwAcvOiATgUqx5VH02S5DyfTg+qPMSX+A@mail.gmail.com>
On Mon, 23 Nov 2026 03:06:16 +1100 Aveline Noir <jm5905938@gmail.com> wrote:
> Hi SJ
>
> On Sun, Nov 22, 2026 at 8:00 AM SJ Park <sj@kernel.org> wrote:
>
> > + queue = &damon_report_queue;
> > + report->jiffies = jiffies;
> > + lock_old_val = atomic_cmpxchg(&queue->lock, 0, 1);
>
> If a submitter is preempted between these lines, it can enqueue its
> report after one with a newer timestamp. A lookup scanning backwards
> can then stop at the older report if it's outside the window and miss
> the newer one that's still in it.
Will that frequently happen enough to be a real problem? I think missing a few
reports is no problem.
>
> Could we move the jiffies assignment after a successful cmpxchg()?
> That would keep timestamps in enqueue order and better fit the
> meaning of "when this report is generated".
I agree this could reduce races little bit. But it's too little bit to expect
meaningful change, in my opinion.
I find a few downsides of your suggestion, too. It will increase the critical
section. Also the jiffies becomes little bit late than when the user made the
report. These would be negligible in the real world, though.
So both the advantage and the risks of your suggestion looks not big to me. If
you don't mind, I'd keep this as is. What do you think?
Thanks,
SJ
[...]
next prev parent reply other threads:[~2026-11-22 17:15 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 20:59 [PATCH 00/27] mm/damon: let users report their data attribute findings SJ Park
2026-11-21 20:59 ` [PATCH 01/27] mm/damon/api: introduce struct damon_report SJ Park
2026-11-22 13:22 ` Lian Wang
2026-11-22 15:08 ` Aveline Noir
2026-11-21 20:59 ` [PATCH 02/27] mm/damon/core: implement data attribute report queue SJ Park
2026-11-22 13:49 ` Lian Wang
2026-11-22 15:43 ` Aveline Noir
2026-11-22 17:21 ` SJ Park
2026-11-21 20:59 ` [PATCH 03/27] mm/damon/core: introduce damon_submit_report() SJ Park
2026-11-22 16:06 ` Aveline Noir
2026-11-22 17:15 ` SJ Park [this message]
2026-11-22 17:30 ` Aveline Noir
2026-11-21 20:59 ` [PATCH 04/27] mm/damon/sysfs: add admin/reports/ directory SJ Park
2026-11-22 13:59 ` Lian Wang
2026-11-21 20:59 ` [PATCH 05/27] mm/damon/sysfs: add reports/producers/ directory SJ Park
2026-11-21 20:59 ` [PATCH 06/27] mm/damon/sysfs: add producers/nr_producers file SJ Park
2026-11-21 20:59 ` [PATCH 07/27] mm/damon/sysfs: implement report producer directory SJ Park
2026-11-21 20:59 ` [PATCH 08/27] mm/damon/sysfs: implement report producer type and state files SJ Park
2026-11-21 20:59 ` [PATCH 09/27] Docs/mm/damon/design: update for report system SJ Park
2026-11-21 20:59 ` [PATCH 10/27] Docs/admin-guide/mm/damon/usage: update for report producer sysfs SJ Park
2026-11-21 20:59 ` [PATCH 11/27] Docs/ABI/damon: update for report producer sysfs files SJ Park
2026-11-21 20:59 ` [PATCH 12/27] mm/damon/core: introduce DAMON_FILTER_TYPE_REPORT_MADE SJ Park
2026-11-21 20:59 ` [PATCH 13/27] mm/damon/core: introduce damon_report_exist() SJ Park
2026-11-22 13:16 ` Lian Wang
2026-11-22 17:18 ` SJ Park
2026-11-21 20:59 ` [PATCH 14/27] mm/damon/paddr: support REPORT_MADE type probe filter SJ Park
2026-11-21 21:11 ` sashiko-bot
2026-11-21 21:19 ` SJ Park
2026-11-21 20:59 ` [PATCH 15/27] mm/damon/sysfs: add filter_report_type file under probe filter directory SJ Park
2026-11-21 21:00 ` [PATCH 16/27] mm/damon/sysfs: support REPORT_MADE type probe filter setup SJ Park
2026-11-21 21:00 ` [PATCH 17/27] Docs/mm/damon/design: update for report_made probe filter type SJ Park
2026-11-21 21:00 ` [PATCH 18/27] Docs/admin-guide/mm/damon/usage: update for REPORT_MADE probe filter SJ Park
2026-11-21 21:00 ` [PATCH 19/27] Docs/ABI/damon: " SJ Park
2026-11-21 21:00 ` [PATCH 20/27] mm/damon/api: introduce user_report report type SJ Park
2026-11-21 21:00 ` [PATCH 21/27] mm/damon/sysfs: add user_report support for report type input SJ Park
2026-11-21 21:00 ` [PATCH 22/27] mm/damon/sysfs: implement report producer addr_{start,end} files SJ Park
2026-11-21 21:00 ` [PATCH 23/27] mm/damon/sysfs: implement submit command for report producer SJ Park
2026-11-21 21:00 ` [PATCH 24/27] selftests/damon/sysfs.sh: add basic tests for admin/reports/ SJ Park
2026-11-21 21:00 ` [PATCH 25/27] Docs/mm/damon/design: update for user report support SJ Park
2026-11-21 21:00 ` [PATCH 26/27] Docs/admin-guide/mm/damon/usage: update for user_report " SJ Park
2026-11-21 21:00 ` [PATCH 27/27] Docs/ABI/damon: " SJ Park
2026-11-21 21:12 ` [PATCH 00/27] mm/damon: let users report their data attribute findings sashiko-bot
2026-11-21 21:22 ` SJ Park
2026-11-22 14:29 ` Lian Wang
2026-11-22 17:06 ` SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261122171525.153150-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=jm5905938@gmail.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox