From: SJ Park <sj@kernel.org>
To: Aveline Noir <jm5905938@gmail.com>
Cc: SJ Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, linux-mm@kvack.org
Subject: Re: [PATCH 02/27] mm/damon/core: implement data attribute report queue
Date: Sun, 22 Nov 2026 09:21:14 -0800 [thread overview]
Message-ID: <20261122172119.153755-1-sj@kernel.org> (raw)
In-Reply-To: <CANOyQmE9kM_WgOneXhQ29HTFDLYJwdzWjVKj4e11ESTtT7K2Rg@mail.gmail.com>
On Mon, 23 Nov 2026 02:43:18 +1100 Aveline Noir <jm5905938@gmail.com> wrote:
> Hi SJ,
>
> On Sun, Nov 22, 2026 at 8:00 AM SJ Park <sj@kernel.org> wrote:
> >
> > Implement DAMON core internal data structure for queuing received
> > data attribute reports. Initialize the queue for up to 1,000 reports,
> > inside the DAMON init routine. Destroy damon_region_cache and reset the
> > pointer for the queue setup failures.
> >
>
> Looks good to me.
>
> BTW, while reviewing this, I noticed a pre-existing issue in DAMON
> sysfs. If the core fails to initialize, sysfs still registers the
> interface, and trying to start monitoring with an initial region can
> hit a NULL pointer dereference.Maybe I'll send a separate patch
> to fix it.
Thank you for reporting it, looking forward to the patch!
>
> Reviewed-by: Aveline Noir <jm5905938@gmail.com>
Thank you for reviewing!
Thanks,
SJ
[...]
next prev parent reply other threads:[~2026-11-22 17:21 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 20:59 [PATCH 00/27] mm/damon: let users report their data attribute findings SJ Park
2026-11-21 20:59 ` [PATCH 01/27] mm/damon/api: introduce struct damon_report SJ Park
2026-11-22 13:22 ` Lian Wang
2026-11-22 15:08 ` Aveline Noir
2026-11-21 20:59 ` [PATCH 02/27] mm/damon/core: implement data attribute report queue SJ Park
2026-11-22 13:49 ` Lian Wang
2026-11-22 15:43 ` Aveline Noir
2026-11-22 17:21 ` SJ Park [this message]
2026-11-21 20:59 ` [PATCH 03/27] mm/damon/core: introduce damon_submit_report() SJ Park
2026-11-22 16:06 ` Aveline Noir
2026-11-22 17:15 ` SJ Park
2026-11-22 17:30 ` Aveline Noir
2026-11-21 20:59 ` [PATCH 04/27] mm/damon/sysfs: add admin/reports/ directory SJ Park
2026-11-22 13:59 ` Lian Wang
2026-11-21 20:59 ` [PATCH 05/27] mm/damon/sysfs: add reports/producers/ directory SJ Park
2026-11-21 20:59 ` [PATCH 06/27] mm/damon/sysfs: add producers/nr_producers file SJ Park
2026-11-21 20:59 ` [PATCH 07/27] mm/damon/sysfs: implement report producer directory SJ Park
2026-11-21 20:59 ` [PATCH 08/27] mm/damon/sysfs: implement report producer type and state files SJ Park
2026-11-21 20:59 ` [PATCH 09/27] Docs/mm/damon/design: update for report system SJ Park
2026-11-21 20:59 ` [PATCH 10/27] Docs/admin-guide/mm/damon/usage: update for report producer sysfs SJ Park
2026-11-21 20:59 ` [PATCH 11/27] Docs/ABI/damon: update for report producer sysfs files SJ Park
2026-11-21 20:59 ` [PATCH 12/27] mm/damon/core: introduce DAMON_FILTER_TYPE_REPORT_MADE SJ Park
2026-11-21 20:59 ` [PATCH 13/27] mm/damon/core: introduce damon_report_exist() SJ Park
2026-11-22 13:16 ` Lian Wang
2026-11-22 17:18 ` SJ Park
2026-11-21 20:59 ` [PATCH 14/27] mm/damon/paddr: support REPORT_MADE type probe filter SJ Park
2026-11-21 21:11 ` sashiko-bot
2026-11-21 21:19 ` SJ Park
2026-11-21 20:59 ` [PATCH 15/27] mm/damon/sysfs: add filter_report_type file under probe filter directory SJ Park
2026-11-21 21:00 ` [PATCH 16/27] mm/damon/sysfs: support REPORT_MADE type probe filter setup SJ Park
2026-11-21 21:00 ` [PATCH 17/27] Docs/mm/damon/design: update for report_made probe filter type SJ Park
2026-11-21 21:00 ` [PATCH 18/27] Docs/admin-guide/mm/damon/usage: update for REPORT_MADE probe filter SJ Park
2026-11-21 21:00 ` [PATCH 19/27] Docs/ABI/damon: " SJ Park
2026-11-21 21:00 ` [PATCH 20/27] mm/damon/api: introduce user_report report type SJ Park
2026-11-21 21:00 ` [PATCH 21/27] mm/damon/sysfs: add user_report support for report type input SJ Park
2026-11-21 21:00 ` [PATCH 22/27] mm/damon/sysfs: implement report producer addr_{start,end} files SJ Park
2026-11-21 21:00 ` [PATCH 23/27] mm/damon/sysfs: implement submit command for report producer SJ Park
2026-11-21 21:00 ` [PATCH 24/27] selftests/damon/sysfs.sh: add basic tests for admin/reports/ SJ Park
2026-11-21 21:00 ` [PATCH 25/27] Docs/mm/damon/design: update for user report support SJ Park
2026-11-21 21:00 ` [PATCH 26/27] Docs/admin-guide/mm/damon/usage: update for user_report " SJ Park
2026-11-21 21:00 ` [PATCH 27/27] Docs/ABI/damon: " SJ Park
2026-11-21 21:12 ` [PATCH 00/27] mm/damon: let users report their data attribute findings sashiko-bot
2026-11-21 21:22 ` SJ Park
2026-11-22 14:29 ` Lian Wang
2026-11-22 17:06 ` SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261122172119.153755-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=jm5905938@gmail.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox