DASH Shell discussions
 help / color / mirror / Atom feed
* DASH regression
@ 2010-06-16  2:14 Brian Koropoff
  2010-07-05  8:55 ` Herbert Xu
  0 siblings, 1 reply; 2+ messages in thread
From: Brian Koropoff @ 2010-06-16  2:14 UTC (permalink / raw)
  To: dash

Hello,
    I encountered a regression in DASH from git while attempting to get
it working on Solaris.  I got it to build and run, but my scripts were
mysteriously failing.  I tracked it down to a logic bug in setvareq()
that caused it to assign through the wrong pointer when attempting to
remove a variable from its hash bucket.  The following test case
reproduces the bug for me:

--

#!/bin/dash
GDM_LANG="bar"
OPTION="foo"
unset GDM_LANG
# OPTION has mysteriously become unset
echo "$OPTION"

--

I'll follow up with a patch.

Regards,
Brian Koropoff


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: DASH regression
  2010-06-16  2:14 DASH regression Brian Koropoff
@ 2010-07-05  8:55 ` Herbert Xu
  0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2010-07-05  8:55 UTC (permalink / raw)
  To: Brian Koropoff; +Cc: dash

Brian Koropoff <bkoropoff@gmail.com> wrote:
> Hello,
>    I encountered a regression in DASH from git while attempting to get
> it working on Solaris.  I got it to build and run, but my scripts were
> mysteriously failing.  I tracked it down to a logic bug in setvareq()
> that caused it to assign through the wrong pointer when attempting to
> remove a variable from its hash bucket.  The following test case
> reproduces the bug for me:

Thanks for the report.  I'll apply your patch.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-07-05  8:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-16  2:14 DASH regression Brian Koropoff
2010-07-05  8:55 ` Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox