DASH regression

DASH regression

[Brian Koropoff]

Hello,
    I encountered a regression in DASH from git while attempting to get
it working on Solaris.  I got it to build and run, but my scripts were
mysteriously failing.  I tracked it down to a logic bug in setvareq()
that caused it to assign through the wrong pointer when attempting to
remove a variable from its hash bucket.  The following test case
reproduces the bug for me:

--

#!/bin/dash
GDM_LANG="bar"
OPTION="foo"
unset GDM_LANG
# OPTION has mysteriously become unset
echo "$OPTION"

--

I'll follow up with a patch.

Regards,
Brian Koropoff

Re: DASH regression

[Herbert Xu]

Brian Koropoff <bkoropoff@gmail.com> wrote:
> Hello,
>    I encountered a regression in DASH from git while attempting to get
> it working on Solaris.  I got it to build and run, but my scripts were
> mysteriously failing.  I tracked it down to a logic bug in setvareq()
> that caused it to assign through the wrong pointer when attempting to
> remove a variable from its hash bucket.  The following test case
> reproduces the bug for me:

Thanks for the report.  I'll apply your patch.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt