Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

[Bob Peterson]

----- Original Message -----
| Drop newline at the end of a message string when the printing function adds
| a newline.

Hi Julia,

NACK.

As much as it's a pain when searching the source code for output strings,
this patch set goes against the accepted Linux coding style document. See:

https://www.kernel.org/doc/html/v4.10/process/coding-style.html#breaking-long-lines-and-strings

Regards,

Bob Peterson

Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

[Julia Lawall]

On Tue, 2 Jan 2018, Bob Peterson wrote:

> ----- Original Message -----
> | Drop newline at the end of a message string when the printing function adds
> | a newline.
>
> Hi Julia,
>
> NACK.
>
> As much as it's a pain when searching the source code for output strings,
> this patch set goes against the accepted Linux coding style document. See:
>
> https://www.kernel.org/doc/html/v4.10/process/coding-style.html#breaking-long-lines-and-strings

I don't think that's the case:

"However, never break user-visible strings such as printk messages,
because that breaks the ability to grep for them."

julia

>
> Regards,
>
> Bob Peterson
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

[Bob Peterson]

----- Original Message -----
| ----- Original Message -----
| | Drop newline at the end of a message string when the printing function adds
| | a newline.
| 
| Hi Julia,
| 
| NACK.
| 
| As much as it's a pain when searching the source code for output strings,
| this patch set goes against the accepted Linux coding style document. See:
| 
| https://www.kernel.org/doc/html/v4.10/process/coding-style.html#breaking-long-lines-and-strings
| 
| Regards,
| 
| Bob Peterson
| 
| 
Hm. I guess I stand corrected. The document reads:

"However, never break user-visible strings such as printk messages, because that breaks the ability to grep for them."

Still, the GFS2 and DLM code has a plethora of broken-up printk messages,
and I don't like the thought of re-combining them all.

Regards,

Bob Peterson

Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

[Julia Lawall]

On Tue, 2 Jan 2018, Bob Peterson wrote:

> ----- Original Message -----
> | ----- Original Message -----
> | | Drop newline at the end of a message string when the printing function adds
> | | a newline.
> |
> | Hi Julia,
> |
> | NACK.
> |
> | As much as it's a pain when searching the source code for output strings,
> | this patch set goes against the accepted Linux coding style document. See:
> |
> | https://www.kernel.org/doc/html/v4.10/process/coding-style.html#breaking-long-lines-and-strings
> |
> | Regards,
> |
> | Bob Peterson
> |
> |
> Hm. I guess I stand corrected. The document reads:
>
> "However, never break user-visible strings such as printk messages, because that breaks the ability to grep for them."
>
> Still, the GFS2 and DLM code has a plethora of broken-up printk messages,
> and I don't like the thought of re-combining them all.

Actually, the point of the patch was to remove the unnecessary \n at the
end of the string, because log_print will add another one.  If you prefer
to keep the string broken up, I can resend the patch in that form, but
without the unnecessary \n.

julia

Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

[Bart Van Assche]

T24gVHVlLCAyMDE4LTAxLTAyIGF0IDE1OjAwICswMTAwLCBKdWxpYSBMYXdhbGwgd3JvdGU6DQo+
IE9uIFR1ZSwgMiBKYW4gMjAxOCwgQm9iIFBldGVyc29uIHdyb3RlOg0KPiA+IC0tLS0tIE9yaWdp
bmFsIE1lc3NhZ2UgLS0tLS0NCj4gPiA+IC0tLS0tIE9yaWdpbmFsIE1lc3NhZ2UgLS0tLS0NCj4g
PiA+DQo+ID4gU3RpbGwsIHRoZSBHRlMyIGFuZCBETE0gY29kZSBoYXMgYSBwbGV0aG9yYSBvZiBi
cm9rZW4tdXAgcHJpbnRrIG1lc3NhZ2VzLA0KPiA+IGFuZCBJIGRvbid0IGxpa2UgdGhlIHRob3Vn
aHQgb2YgcmUtY29tYmluaW5nIHRoZW0gYWxsLg0KPiANCj4gQWN0dWFsbHksIHRoZSBwb2ludCBv
ZiB0aGUgcGF0Y2ggd2FzIHRvIHJlbW92ZSB0aGUgdW5uZWNlc3NhcnkgXG4gYXQgdGhlDQo+IGVu
ZCBvZiB0aGUgc3RyaW5nLCBiZWNhdXNlIGxvZ19wcmludCB3aWxsIGFkZCBhbm90aGVyIG9uZS4g
IElmIHlvdSBwcmVmZXINCj4gdG8ga2VlcCB0aGUgc3RyaW5nIGJyb2tlbiB1cCwgSSBjYW4gcmVz
ZW5kIHRoZSBwYXRjaCBpbiB0aGF0IGZvcm0sIGJ1dA0KPiB3aXRob3V0IHRoZSB1bm5lY2Vzc2Fy
eSBcbi4NCg0KUGxlYXNlIGNvbWJpbmUgYW55IHVzZXItdmlzaWJsZSBzdHJpbmdzIGludG8gYSBz
aW5nbGUgbGluZSBmb3Igd2hpY2ggdGhlDQp1bm5lZWRlZCBuZXdsaW5lIGlzIGRyb3BwZWQgc2lu
Y2UgdGhlc2Ugc3RyaW5ncyBhcmUgbW9kaWZpZWQgYW55d2F5IGJ5DQp5b3VyIHBhdGNoLg0KDQpU
aGFua3MsDQoNCkJhcnQu

Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

[Julia Lawall]

On Tue, 2 Jan 2018, Bart Van Assche wrote:

> On Tue, 2018-01-02 at 15:00 +0100, Julia Lawall wrote:
> > On Tue, 2 Jan 2018, Bob Peterson wrote:
> > > ----- Original Message -----
> > > > ----- Original Message -----
> > > >
> > > Still, the GFS2 and DLM code has a plethora of broken-up printk messages,
> > > and I don't like the thought of re-combining them all.
> >
> > Actually, the point of the patch was to remove the unnecessary \n at the
> > end of the string, because log_print will add another one.  If you prefer
> > to keep the string broken up, I can resend the patch in that form, but
> > without the unnecessary \n.
>
> Please combine any user-visible strings into a single line for which the
> unneeded newline is dropped since these strings are modified anyway by
> your patch.

That is what the submitted patch (2/12 specifically) did.

julia