[PATCH 2/4] CCID4: Provides organization to the initial entries for CCID 4 to net/dccp/ccids/Makefil

[PATCH 2/4] CCID4: Provides organization to the initial entries for CCID 4 to net/dccp/ccids/Makefil

[@ 2007-09-20 17:54 UTC (permalink / raw)]

Signed-off-by: Leandro Sales <leandro@embedded.ufcg.edu.br>

Just to maintain the order or declarion 4, 3, 2 instead of 3 4 2, which can
facilitate either future identification and addition of new ccids on top of the
Makefile.

diff -uprN dccp-ccid4.base/net/dccp/ccids/Makefile
dccp-ccid4/net/dccp/ccids/Makefile
--- dccp-ccid4.base/net/dccp/ccids/Makefile	2007-09-20 11:45:30.000000000 -0300
+++ dccp-ccid4/net/dccp/ccids/Makefile	2007-09-20 11:55:23.000000000 -0300
@@ -1,3 +1,7 @@
+obj-$(CONFIG_IP_DCCP_CCID4) += dccp_ccid4.o
+
+dccp_ccid4-y := ccid4.o
+
 obj-$(CONFIG_IP_DCCP_CCID3) += dccp_ccid3.o

 dccp_ccid3-y := ccid3.o
@@ -6,8 +10,4 @@ obj-$(CONFIG_IP_DCCP_CCID2) += dccp_ccid

 dccp_ccid2-y := ccid2.o

-obj-$(CONFIG_IP_DCCP_CCID4) += dccp_ccid4.o
-
-dccp_ccid4-y := ccid4.o
-
 obj-y += lib/

Re: [PATCH 2/4] CCID4: Provides organization to the initial

[Tommi Saviranta]

On Thu, Sep 20, 2007 at 14:54:32 -0300, ツ Leandro Sales wrote:
> diff -uprN dccp-ccid4.base/net/dccp/ccids/Makefile
> dccp-ccid4/net/dccp/ccids/Makefile
> --- dccp-ccid4.base/net/dccp/ccids/Makefile	2007-09-20 11:45:30.000000000 -0300
> +++ dccp-ccid4/net/dccp/ccids/Makefile	2007-09-20 11:55:23.000000000 -0300

Signed-off-by: Tommi Saviranta <wnd@iki.fi>

By the way one more question about acking/signing patches. When talking
about trivial patches such as this, is there a consensus on if simple
patches need to be (or should be) acked or signed in the first place?

Personally I was a little reluctant to sign this one, but signed it
anyway as requested.

Re: [PATCH 2/4] CCID4: Provides organization to the initial

[Arnaldo Carvalho de Melo]

Em Fri, Sep 21, 2007 at 05:02:40PM +0300, Tommi Saviranta escreveu:
> On Thu, Sep 20, 2007 at 14:54:32 -0300, ツ Leandro Sales wrote:
> > diff -uprN dccp-ccid4.base/net/dccp/ccids/Makefile
> > dccp-ccid4/net/dccp/ccids/Makefile
> > --- dccp-ccid4.base/net/dccp/ccids/Makefile	2007-09-20 11:45:30.000000000 -0300
> > +++ dccp-ccid4/net/dccp/ccids/Makefile	2007-09-20 11:55:23.000000000 -0300
> 
> Signed-off-by: Tommi Saviranta <wnd@iki.fi>
> 
> By the way one more question about acking/signing patches. When talking
> about trivial patches such as this, is there a consensus on if simple
> patches need to be (or should be) acked or signed in the first place?
> 
> Personally I was a little reluctant to sign this one, but signed it
> anyway as requested.

It is always good to show that you agree with the change, read
Documentation/SubmittingPatches to get more food for thought.

I'll try to harvest the signatures when I get to review/merge the
patches.

And keep up the good work, I'm really happy with how healthy the DCCP on
Linux developer community is getting, thank you all!

- Arnaldo

Re: [PATCH 2/4] CCID4: Provides organization to the initial entries for CCID 4 to net/dccp/ccids/Mak

[@ 2007-09-21 19:47 UTC (permalink / raw)]

2007/9/21, Arnaldo Carvalho de Melo <acme@ghostprotocols.net>:
> Em Fri, Sep 21, 2007 at 05:02:40PM +0300, Tommi Saviranta escreveu:
> > On Thu, Sep 20, 2007 at 14:54:32 -0300, ツ Leandro Sales wrote:
> > > diff -uprN dccp-ccid4.base/net/dccp/ccids/Makefile
> > > dccp-ccid4/net/dccp/ccids/Makefile
> > > --- dccp-ccid4.base/net/dccp/ccids/Makefile 2007-09-20 11:45:30.000000000 -0300
> > > +++ dccp-ccid4/net/dccp/ccids/Makefile      2007-09-20 11:55:23.000000000 -0300
> >
> > Signed-off-by: Tommi Saviranta <wnd@iki.fi>
> >
> > By the way one more question about acking/signing patches. When talking
> > about trivial patches such as this, is there a consensus on if simple
> > patches need to be (or should be) acked or signed in the first place?
> >
> > Personally I was a little reluctant to sign this one, but signed it
> > anyway as requested.
>
> It is always good to show that you agree with the change, read
> Documentation/SubmittingPatches to get more food for thought.
>
> I'll try to harvest the signatures when I get to review/merge the
> patches.
>
> And keep up the good work, I'm really happy with how healthy the DCCP on
> Linux developer community is getting, thank you all!
>
> - Arnaldo
>

I just update the file thinking about the future changes to the DCCP
implementation, for instance, adding new CCIDs. Since I have other
patches to apply, I decided to submit this one too. Since we were
submit initial patches for CCID-4, I considerer that this initial
process will require some adjusts like that. Besides, our patches (the
mine and Tommi's ones) was very similar, and them I just sent the
remains patches.

Tommi, when you agree with some patch, you can send a NAK ("no ack"),
as Gerrit said.

Arnaldo, it is good to know from you that our works are welcomed.

Leandro.

Re: [PATCH 2/4] CCID4: Provides organization to the initial entries for CCID 4 to net/dccp/ccids/Mak

[@ 2007-09-21 19:49 UTC (permalink / raw)]

2007/9/21, ツ Leandro Sales <leandroal@gmail.com>:
> 2007/9/21, Arnaldo Carvalho de Melo <acme@ghostprotocols.net>:
> > Em Fri, Sep 21, 2007 at 05:02:40PM +0300, Tommi Saviranta escreveu:
> > > On Thu, Sep 20, 2007 at 14:54:32 -0300, ツ Leandro Sales wrote:
> > > > diff -uprN dccp-ccid4.base/net/dccp/ccids/Makefile
> > > > dccp-ccid4/net/dccp/ccids/Makefile
> > > > --- dccp-ccid4.base/net/dccp/ccids/Makefile 2007-09-20 11:45:30.000000000 -0300
> > > > +++ dccp-ccid4/net/dccp/ccids/Makefile      2007-09-20 11:55:23.000000000 -0300
> > >
> > > Signed-off-by: Tommi Saviranta <wnd@iki.fi>
> > >
> > > By the way one more question about acking/signing patches. When talking
> > > about trivial patches such as this, is there a consensus on if simple
> > > patches need to be (or should be) acked or signed in the first place?
> > >
> > > Personally I was a little reluctant to sign this one, but signed it
> > > anyway as requested.
> >
> > It is always good to show that you agree with the change, read
> > Documentation/SubmittingPatches to get more food for thought.
> >
> > I'll try to harvest the signatures when I get to review/merge the
> > patches.
> >
> > And keep up the good work, I'm really happy with how healthy the DCCP on
> > Linux developer community is getting, thank you all!
> >
> > - Arnaldo
> >
>
> I just update the file thinking about the future changes to the DCCP
> implementation, for instance, adding new CCIDs. Since I have other
> patches to apply, I decided to submit this one too. Since we were
> submit initial patches for CCID-4, I considerer that this initial
> process will require some adjusts like that. Besides, our patches (the
> mine and Tommi's ones) was very similar, and them I just sent the
> remains patches.
>
> Tommi, when you agree with some patch, you can send a NAK ("no ack"),
> as Gerrit said.
>
> Arnaldo, it is good to know from you that our works are welcomed.
>
> Leandro.
>

ERRATA: when you don't agree, you can send a NAK.

Re: [PATCH 2/4] CCID4: Provides organization to the initial entries for CCID 4 to net/dccp/ccids/Mak

[Ian McDonald]

On 9/21/07, ツ Leandro Sales <leandroal@gmail.com> wrote:
> Signed-off-by: Leandro Sales <leandro@embedded.ufcg.edu.br>
>
> Just to maintain the order or declarion 4, 3, 2 instead of 3 4 2, which can
> facilitate either future identification and addition of new ccids on top of the
> Makefile.
>

I don't think it actually matters the order as it is just a makefile
and not user facing.

Still the patch is OK
Signed-off-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
-- 
Web1: http://wand.net.nz/~iam4/
Web2: http://www.jandi.co.nz
Blog: http://iansblog.jandi.co.nz