* [dm-crypt] crypt_load() crash when 3 argument is NULL
@ 2012-12-08 0:06 .. ink ..
2012-12-08 0:35 ` Milan Broz
0 siblings, 1 reply; 2+ messages in thread
From: .. ink .. @ 2012-12-08 0:06 UTC (permalink / raw)
To: dm-crypt
[-- Attachment #1: Type: text/plain, Size: 357 bytes --]
This is something i noticed last night but forgot to mention in my previous
email.
Just updated from git to test and the behavior is still there.
calling crypt_load() with the third argument as NULL segfaults.
API docs says nothing about the third argument not being NULL but
"action_isLuks" function has it at NULL so the version in git must have a
bug
[-- Attachment #2: Type: text/html, Size: 399 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dm-crypt] crypt_load() crash when 3 argument is NULL
2012-12-08 0:06 [dm-crypt] crypt_load() crash when 3 argument is NULL .. ink ..
@ 2012-12-08 0:35 ` Milan Broz
0 siblings, 0 replies; 2+ messages in thread
From: Milan Broz @ 2012-12-08 0:35 UTC (permalink / raw)
To: .. ink ..; +Cc: dm-crypt
On 12/08/2012 01:06 AM, .. ink .. wrote:
> This is something i noticed last night but forgot to mention in my previous email.
>
> Just updated from git to test and the behavior is still there.
>
> calling crypt_load() with the third argument as NULL segfaults.
params is required for TCRYPT type (you need to provide password/keyfiles here).
Should be fixed in git to return EINVAL instead, thanks.
(I'll revisit docs later, still a lot of other changes ahead.)
Milan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-08 0:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-08 0:06 [dm-crypt] crypt_load() crash when 3 argument is NULL .. ink ..
2012-12-08 0:35 ` Milan Broz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox