Linux Device Mapper development
 help / color / mirror / Atom feed
From: malahal@us.ibm.com
To: device-mapper development <dm-devel@redhat.com>
Cc: mpatocka@redhat.com
Subject: Re: [RFC][PATCH] dm-mirror: fix data corruption
Date: Sun, 30 Aug 2009 12:24:41 -0700	[thread overview]
Message-ID: <20090830192441.GA641@us.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0907130547530.27968@hs20-bc2-1.build.redhat.com>

Mikulas Patocka [mpatocka@redhat.com] wrote:
> 
> > How do bios queued in ms->failures are processed later? It seems that
> > the bios stay in ms->failures forever, and the upper layer can not
> > receive "success" for those bios. Don't we need a mechanism to block/unblock
> > write bios to fix this issue?
> 
> They are resubmitted with DM_ENDIO_REQUEUE on noflush suspend. My patch 
> has a bug that they aren't --- but I will provide a better patch, also 
> without this periodic polling of ms->failures queue.

Trying to verify this patch. Mikulas, did you provide a better patch
yet? Does this patch work at all?

I would like to verify if this patch works with devices that fail
temporarily. I will plan on using dm-flakey devices for testing purposes.

Thanks, Malahal.

  reply	other threads:[~2009-08-30 19:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-09 23:54 [RFC][PATCH] dm-mirror: fix data corruption Takahiro Yasui
2009-07-10 11:16 ` Jun'ichi Nomura
2009-07-10 19:14   ` Takahiro Yasui
2009-07-10 13:44 ` Mikulas Patocka
2009-07-10 13:49   ` Mikulas Patocka
2009-07-10 19:04     ` Takahiro Yasui
2009-07-10 19:45       ` malahal
2009-07-13  1:07         ` Takahiro Yasui
2009-07-13  9:50       ` Mikulas Patocka
2009-08-30 19:24         ` malahal [this message]
2009-08-31 21:39           ` Mikulas Patocka
2009-09-09 20:18             ` Takahiro Yasui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090830192441.GA641@us.ibm.com \
    --to=malahal@us.ibm.com \
    --cc=dm-devel@redhat.com \
    --cc=mpatocka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox