From: Takahiro Yasui <tyasui@redhat.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: device-mapper development <dm-devel@redhat.com>
Subject: Re: Re: [RFC][PATCH] dm-mirror: fix data corruption
Date: Wed, 09 Sep 2009 16:18:45 -0400 [thread overview]
Message-ID: <4AA80DA5.7080709@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0908311737090.16318@hs20-bc2-1.build.redhat.com>
Hi Mikulas,
On 08/31/09 17:39, Mikulas Patocka wrote:
> I uploaded patches for this bug at:
> http://people.redhat.com/mpatocka/patches/kernel/mirror-race/
>
> But note! They were never tried. When I wanted to try them, I found out
> that dmeventd is totally nonworking in upstream code (it doesn't pass
> "handle_errors" argument and has some crashes and signal errors), so I
> didn't test them with dmeventd. Dmeventd must be fixed first, then we can
> work on this bug.
Thank you for posting the patch set. I roughly looked at your patch and
have several comments.
- The flag, "handle_errors," won't be passed to dm-raid1 by dmeventd. lvm
commands (e.g. vgchange) or dmsetup pass "handle_errors" when new mirror
mapping is created.
- As I mentioned before, bios which are sent to out-of-sync regions also
need to be blocked because bios to out-of-sync regions are processed by
generic_make_request() and would return the "success" to upper layer
without dm-raid1 notices it. This might cause data corruption.
https://www.redhat.com/archives/dm-devel/2009-July/msg00118.html
- The modification of write_callback() looks a little confusing to me.
Do all bios need to be blocked? When all legs returns error, the bio
should be returned with -EIO to upper layer without being blocked as
original code using uptodate flag.
I appreciate your comments.
Thanks,
Taka
--
Takahiro Yasui
Hitachi Computer Products (America), Inc.
prev parent reply other threads:[~2009-09-09 20:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-09 23:54 [RFC][PATCH] dm-mirror: fix data corruption Takahiro Yasui
2009-07-10 11:16 ` Jun'ichi Nomura
2009-07-10 19:14 ` Takahiro Yasui
2009-07-10 13:44 ` Mikulas Patocka
2009-07-10 13:49 ` Mikulas Patocka
2009-07-10 19:04 ` Takahiro Yasui
2009-07-10 19:45 ` malahal
2009-07-13 1:07 ` Takahiro Yasui
2009-07-13 9:50 ` Mikulas Patocka
2009-08-30 19:24 ` malahal
2009-08-31 21:39 ` Mikulas Patocka
2009-09-09 20:18 ` Takahiro Yasui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA80DA5.7080709@redhat.com \
--to=tyasui@redhat.com \
--cc=dm-devel@redhat.com \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox