Linux Device Mapper development
 help / color / mirror / Atom feed
From: Takahiro Yasui <tyasui@redhat.com>
To: j-nomura@ce.jp.nec.com
Cc: device-mapper development <dm-devel@redhat.com>,
	Mikulas Patocka <mpatocka@redhat.com>,
	Alasdair G Kergon <agk@redhat.com>
Subject: Re: [RFC][PATCH] dm-mirror: fix data corruption
Date: Fri, 10 Jul 2009 15:14:40 -0400	[thread overview]
Message-ID: <4A579320.1040709@redhat.com> (raw)
In-Reply-To: <4A572313.1050402@ce.jp.nec.com>

Hi Nomura-san,

On 07/10/09 07:16, Jun'ichi Nomura wrote:
> Hi Yasui-san,
> 
> Takahiro Yasui wrote:
>> This is a prototype patch to fix data corruption issue on dm-raid1.
>> It is just a draft patch and is not tested well, but let me post it
>> to review and discuss this in-kernel superblock approach.
>>
>> I appreciate your comments and suggestions.
> <snip>
>>   * Introduce superblock area
>>
>>     A superblock area is related to a mirror leg on a one-to-one basis and
>>     keeps a sequential number to decide the default mirror when the mirror
>>     is resumed.
> 
> If you are to introduce kernel-managed RAID1 superblock,
> isn't it possible to use the on-disk format compatible to md's?
> Then the kernel code to handle the superblock may be shared between
> md and dm in future, which I think is even better and would help
> dm/md convergence.

Thank you for the comment. You are right and sharing the kernel code to
handle superblock between md and dm would be better toward merging dm/md.
I would like to introduce this in-kernel superblock approach, but userspace
approach handled by dmeventd seems to be preferred. I try to check the
possibility to reduce overhead of error handling in userspace.

Thanks,
Taka

  reply	other threads:[~2009-07-10 19:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-09 23:54 [RFC][PATCH] dm-mirror: fix data corruption Takahiro Yasui
2009-07-10 11:16 ` Jun'ichi Nomura
2009-07-10 19:14   ` Takahiro Yasui [this message]
2009-07-10 13:44 ` Mikulas Patocka
2009-07-10 13:49   ` Mikulas Patocka
2009-07-10 19:04     ` Takahiro Yasui
2009-07-10 19:45       ` malahal
2009-07-13  1:07         ` Takahiro Yasui
2009-07-13  9:50       ` Mikulas Patocka
2009-08-30 19:24         ` malahal
2009-08-31 21:39           ` Mikulas Patocka
2009-09-09 20:18             ` Takahiro Yasui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A579320.1040709@redhat.com \
    --to=tyasui@redhat.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=j-nomura@ce.jp.nec.com \
    --cc=mpatocka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox