Linux Device Mapper development
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: John Utz <John.Utz@wdc.com>
Cc: device-mapper development <dm-devel@redhat.com>,
	Bryn Reeves <breeves@redhat.com>,
	"Stewart, Sean" <Sean.Stewart@netapp.com>,
	Alasdair Kergon <agk@redhat.com>
Subject: Re: dm-multipath: Accept failed paths for multipath maps
Date: Thu, 17 Jul 2014 22:18:06 -0400	[thread overview]
Message-ID: <20140718021806.GA1143@redhat.com> (raw)
In-Reply-To: <8A51900D08212F40B3DE22453052F69839C46AF4@wdscexmb02>

On Thu, Jul 17 2014 at  8:29pm -0400,
John Utz <John.Utz@wdc.com> wrote:

> What are the release testing criteria for things like this? From a
> hand wavy perspective i am sure that the meta-requirement is 'don't
> break anything'. but how is a new release proven to not break
> anything?

Red Hat and other vendors have their own testbeds and harnesses for
testing dm-multipath.  But we really could benefit from more open
exchange and collaboration of a multipath test harness.

Had I actually tested the patches I pointed to it'd have blown up
pretty solidly, I realized something like this was needed:
http://git.kernel.org/cgit/linux/kernel/git/snitzer/linux.git/commit/?h=throwaway-dm-mpath-placeholder-devs&id=77d1130e602a399ed1451edd7e91044fe9225fb6

Anyway, I really don't like that 'place-holder device' approach.. way
too hackish (both my code and Hannes').  It is an elaborate workaround
rather than a proper solution.  I'm hopeful Bryn takes this multipath
problem under his wing and fixes it for real ;)

> fer instance, does anybody create dm devices, format them with XFS and
> then run xfstests against them?

We routinely use XFS and ext4 with git to generate load.  But not
xfstests... that may be useful.

> or some other formalized regimen?
> 
> or is it all kinda ad-hoc?

We have the device-mapper-test-suite (dmts) for testing various DM
targets (mainly dm-thinp and dm-cache), see:
https://github.com/jthornber/device-mapper-test-suite

I added basic support for dm-crypt to dmts; but it needs serious
expanding for it to be useful.. luckily the cryptsetup userspace code
has dm-crypt tests.

Also, the lvm2 testsuite is another major resource that is used for
testing the wide range of DM targets.

  reply	other threads:[~2014-07-18  2:18 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-18  7:52 [PATCHv2] dm-multipath: Accept failed paths for multipath maps Hannes Reinecke
2013-12-18 14:08 ` Mike Snitzer
2013-12-18 14:25   ` Hannes Reinecke
2013-12-18 15:28     ` Stewart, Sean
2013-12-19  8:21       ` Bart Van Assche
2014-02-19  1:14         ` Mike Snitzer
2014-02-19  8:11           ` Bart Van Assche
2014-07-18  0:04       ` Mike Snitzer
2014-07-18  0:23         ` Mike Snitzer
2014-07-18  6:00           ` Hannes Reinecke
2014-07-18 16:04             ` Mike Snitzer
2014-07-18 16:15               ` Mike Snitzer
2014-07-21  6:05                 ` Hannes Reinecke
2014-07-18  0:29         ` John Utz
2014-07-18  2:18           ` Mike Snitzer [this message]
2014-07-18  3:31             ` John Utz
2014-07-18  5:57               ` Hannes Reinecke
2014-07-18 14:38                 ` Mike Snitzer
2014-07-18 17:04                   ` John Utz
2014-07-21 14:23                     ` ZAC target (Was: Re: dm-multipath: Accept failed paths for multipath maps) Hannes Reinecke
2014-07-21 19:28                       ` Kent Overstreet
2014-07-22  5:46                         ` Hannes Reinecke
2014-07-22  8:08                           ` Matias Bjorling
2014-07-18 16:51                 ` dm-multipath: Accept failed paths for multipath maps John Utz
2014-07-18  6:12         ` Hannes Reinecke
2013-12-18 15:28     ` Merla, ShivaKrishna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140718021806.GA1143@redhat.com \
    --to=snitzer@redhat.com \
    --cc=John.Utz@wdc.com \
    --cc=Sean.Stewart@netapp.com \
    --cc=agk@redhat.com \
    --cc=breeves@redhat.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox