[PATCH 0/1] Fix kpart -d regression where matching devices not found

[PATCH 0/1] Fix kpart -d regression where matching devices not found

[Stef Walter]

The Lorax project found a regression in kpartx -d behavior introduced
by the following commit: 9bdfa3eb8e24b668e6c2bb882cddb0ccfe23ed5b

This patch should fix the problem. It's easy to reproduce this problem
(I did it on Fedora 28) with the following commands:

        # kpartx -av disk.img
        ...
        # kpartx -dv disk.img

Notice that the loop devices and partition mappings created by the first
command are not cleaned up by the second command.

Stef Walter (1):
  kpartx: Use absolute paths to create mappings

 kpartx/kpartx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.17.1

[PATCH 1/1] kpartx: Use absolute paths to create mappings

[Stef Walter]

kpartx -d now uses absolute paths to delete mappings, since the
commit 9bdfa3eb8e24b668e6c2bb882cddb0ccfe23ed5b. We should use
those same absolute paths to create the mappings.

Without this patch, the following workflow (as seen in the
manual page for kpartx) fails to actually remove the devices:

    # kpartx -av disk.img
    ...
    # kpartx -d disk.img
---
 kpartx/kpartx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kpartx/kpartx.c b/kpartx/kpartx.c
index 442b6bd9..d4fb53be 100644
--- a/kpartx/kpartx.c
+++ b/kpartx/kpartx.c
@@ -341,7 +341,7 @@ main(int argc, char **argv){
 		if (!loopdev) {
 			loopdev = find_unused_loop_device();
 
-			if (set_loop(loopdev, device, 0, &ro)) {
+			if (set_loop(loopdev, rpath, 0, &ro)) {
 				fprintf(stderr, "can't set up loop\n");
 				exit (1);
 			}
-- 
2.17.1

Re: [PATCH 1/1] kpartx: Use absolute paths to create mappings

[Benjamin Marzinski]

On Sat, Oct 06, 2018 at 09:38:56AM +0200, Stef Walter wrote:
> kpartx -d now uses absolute paths to delete mappings, since the
> commit 9bdfa3eb8e24b668e6c2bb882cddb0ccfe23ed5b. We should use
> those same absolute paths to create the mappings.
> 
> Without this patch, the following workflow (as seen in the
> manual page for kpartx) fails to actually remove the devices:
> 
>     # kpartx -av disk.img
>     ...
>     # kpartx -d disk.img

Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>

> ---
>  kpartx/kpartx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kpartx/kpartx.c b/kpartx/kpartx.c
> index 442b6bd9..d4fb53be 100644
> --- a/kpartx/kpartx.c
> +++ b/kpartx/kpartx.c
> @@ -341,7 +341,7 @@ main(int argc, char **argv){
>  		if (!loopdev) {
>  			loopdev = find_unused_loop_device();
>  
> -			if (set_loop(loopdev, device, 0, &ro)) {
> +			if (set_loop(loopdev, rpath, 0, &ro)) {
>  				fprintf(stderr, "can't set up loop\n");
>  				exit (1);
>  			}
> -- 
> 2.17.1
> 
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel

Re: [PATCH 0/1] Fix kpart -d regression where matching devices not found

[Xose Vazquez Perez]

Stef Walter wrote:

You should send(CC:) it also to Christophe.

> The Lorax project found a regression in kpartx -d behavior introduced
> by the following commit: 9bdfa3eb8e24b668e6c2bb882cddb0ccfe23ed5b
> 
> This patch should fix the problem. It's easy to reproduce this problem
> (I did it on Fedora 28) with the following commands:
> 
>         # kpartx -av disk.img
>         ...
>         # kpartx -dv disk.img
> 
> Notice that the loop devices and partition mappings created by the first
> command are not cleaned up by the second command.
> 
> Stef Walter (1):
>   kpartx: Use absolute paths to create mappings
> 
>  kpartx/kpartx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH 0/1] Fix kpart -d regression where matching devices not found

[Christophe Varoqui]

[-- Attachment #1.1: Type: text/plain, Size: 940 bytes --]

Hi Steph, Xose,

I have this patch in the queue, no worry.
pending a "reviewed-by" though.

Best regards,
Christophe.

On Tue, Oct 9, 2018 at 2:38 PM Xose Vazquez Perez <xose.vazquez@gmail.com>
wrote:

> Stef Walter wrote:
>
> You should send(CC:) it also to Christophe.
>
> > The Lorax project found a regression in kpartx -d behavior introduced
> > by the following commit: 9bdfa3eb8e24b668e6c2bb882cddb0ccfe23ed5b
> >
> > This patch should fix the problem. It's easy to reproduce this problem
> > (I did it on Fedora 28) with the following commands:
> >
> >         # kpartx -av disk.img
> >         ...
> >         # kpartx -dv disk.img
> >
> > Notice that the loop devices and partition mappings created by the first
> > command are not cleaned up by the second command.
> >
> > Stef Walter (1):
> >   kpartx: Use absolute paths to create mappings
> >
> >  kpartx/kpartx.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
>

[-- Attachment #1.2: Type: text/html, Size: 1414 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]