Linux Device Mapper development
 help / color / mirror / Atom feed
* [PATCH 0/1] Fix kpart -d regression where matching devices not found
@ 2018-10-06  7:38 Stef Walter
  0 siblings, 0 replies; 3+ messages in thread
From: Stef Walter @ 2018-10-06  7:38 UTC (permalink / raw)
  To: dm-devel; +Cc: Stef Walter

The Lorax project found a regression in kpartx -d behavior introduced
by the following commit: 9bdfa3eb8e24b668e6c2bb882cddb0ccfe23ed5b

This patch should fix the problem. It's easy to reproduce this problem
(I did it on Fedora 28) with the following commands:

        # kpartx -av disk.img
        ...
        # kpartx -dv disk.img

Notice that the loop devices and partition mappings created by the first
command are not cleaned up by the second command.

Stef Walter (1):
  kpartx: Use absolute paths to create mappings

 kpartx/kpartx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.17.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 0/1] Fix kpart -d regression where matching devices not found
@ 2018-10-09 12:38 Xose Vazquez Perez
  2018-10-09 13:35 ` Christophe Varoqui
  0 siblings, 1 reply; 3+ messages in thread
From: Xose Vazquez Perez @ 2018-10-09 12:38 UTC (permalink / raw)
  To: Stef Walter; +Cc: device-mapper development

Stef Walter wrote:

You should send(CC:) it also to Christophe.

> The Lorax project found a regression in kpartx -d behavior introduced
> by the following commit: 9bdfa3eb8e24b668e6c2bb882cddb0ccfe23ed5b
> 
> This patch should fix the problem. It's easy to reproduce this problem
> (I did it on Fedora 28) with the following commands:
> 
>         # kpartx -av disk.img
>         ...
>         # kpartx -dv disk.img
> 
> Notice that the loop devices and partition mappings created by the first
> command are not cleaned up by the second command.
> 
> Stef Walter (1):
>   kpartx: Use absolute paths to create mappings
> 
>  kpartx/kpartx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 0/1] Fix kpart -d regression where matching devices not found
  2018-10-09 12:38 [PATCH 0/1] Fix kpart -d regression where matching devices not found Xose Vazquez Perez
@ 2018-10-09 13:35 ` Christophe Varoqui
  0 siblings, 0 replies; 3+ messages in thread
From: Christophe Varoqui @ 2018-10-09 13:35 UTC (permalink / raw)
  To: Xose Vazquez Perez; +Cc: stefw, device-mapper development


[-- Attachment #1.1: Type: text/plain, Size: 940 bytes --]

Hi Steph, Xose,

I have this patch in the queue, no worry.
pending a "reviewed-by" though.

Best regards,
Christophe.

On Tue, Oct 9, 2018 at 2:38 PM Xose Vazquez Perez <xose.vazquez@gmail.com>
wrote:

> Stef Walter wrote:
>
> You should send(CC:) it also to Christophe.
>
> > The Lorax project found a regression in kpartx -d behavior introduced
> > by the following commit: 9bdfa3eb8e24b668e6c2bb882cddb0ccfe23ed5b
> >
> > This patch should fix the problem. It's easy to reproduce this problem
> > (I did it on Fedora 28) with the following commands:
> >
> >         # kpartx -av disk.img
> >         ...
> >         # kpartx -dv disk.img
> >
> > Notice that the loop devices and partition mappings created by the first
> > command are not cleaned up by the second command.
> >
> > Stef Walter (1):
> >   kpartx: Use absolute paths to create mappings
> >
> >  kpartx/kpartx.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
>

[-- Attachment #1.2: Type: text/html, Size: 1414 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-10-09 13:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-09 12:38 [PATCH 0/1] Fix kpart -d regression where matching devices not found Xose Vazquez Perez
2018-10-09 13:35 ` Christophe Varoqui
  -- strict thread matches above, loose matches on Subject: below --
2018-10-06  7:38 Stef Walter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox