Linux Device Mapper development
 help / color / mirror / Atom feed
From: "Benjamin Marzinski" <bmarzins@redhat.com>
To: Martin Wilck <mwilck@suse.com>
Cc: dm-devel@redhat.com
Subject: Re: [PATCH 08/19] libmultipath: decrease log level of word splitting
Date: Thu, 29 Nov 2018 14:49:45 -0600	[thread overview]
Message-ID: <20181129204944.GK5077@octiron.msp.redhat.com> (raw)
In-Reply-To: <20181121101839.30784-9-mwilck@suse.com>

On Wed, Nov 21, 2018 at 11:18:28AM +0100, Martin Wilck wrote:
> This will make log level 4 actually usable.

condlog doesn't actually handle verbosity levels gerater than 4
correctly when logging to syslog (there is no loglevel 8).  I didn't
even realize that there were any condlog(5, ...) calls.  I am all for
using them to make log level 4 usable, but we should cap prio at 7 in
log_safe(), to make syslog happy (not that syslog is used much
anymore).

Otherwise, I'm fine with this

-Ben
 
> Signed-off-by: Martin Wilck <mwilck@suse.com>
> ---
>  libmultipath/util.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libmultipath/util.c b/libmultipath/util.c
> index 66c47611..b5d2e706 100644
> --- a/libmultipath/util.c
> +++ b/libmultipath/util.c
> @@ -104,7 +104,7 @@ get_word (char * sentence, char ** word)
>  	}
>  	strncpy(*word, sentence, len);
>  	strchop(*word);
> -	condlog(4, "*word = %s, len = %i", *word, len);
> +	condlog(5, "*word = %s, len = %i", *word, len);
>  
>  	if (*p == '\0')
>  		return 0;
> -- 
> 2.19.1

  reply	other threads:[~2018-11-29 20:49 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-21 10:18 [PATCH 00/19] multipath-tools: improve logging at -v3 Martin Wilck
2018-11-21 10:18 ` [PATCH 01/19] tests/hwtable: set multipath_dir in local configuration Martin Wilck
2018-11-21 10:18 ` [PATCH 02/19] tests/hwtable: adjust to new checker API Martin Wilck
2018-11-21 10:18 ` [PATCH 03/19] multipath-tools: decrease verbosity of state messages Martin Wilck
2018-11-21 10:18 ` [PATCH 04/19] libmultipath: decrease verbosity of pathinfo messages Martin Wilck
2018-11-21 10:18 ` [PATCH 05/19] libmultipath: decrease verbosity of TUR checker messages Martin Wilck
2018-11-21 10:18 ` [PATCH 06/19] libmultipath: avoid frequent messages from filter_property() Martin Wilck
2018-11-21 10:18 ` [PATCH 07/19] libmultipath: decrease log level of "disassembled" messages Martin Wilck
2018-11-21 10:18 ` [PATCH 08/19] libmultipath: decrease log level of word splitting Martin Wilck
2018-11-29 20:49   ` Benjamin Marzinski [this message]
2018-12-03 23:53   ` Benjamin Marzinski
2018-11-21 10:18 ` [PATCH 09/19] libmultipath: increase log level of map removal Martin Wilck
2018-11-21 10:18 ` [PATCH 10/19] multipathd: decrease log level of checker timing Martin Wilck
2018-11-21 10:18 ` [PATCH 11/19] libmultipath: decrease log level of "prioritizer refcount" message Martin Wilck
2018-11-21 10:18 ` [PATCH 12/19] libmpathpersist/update_map_pr: decrease log level for nop Martin Wilck
2018-11-21 10:18 ` [PATCH 13/19] libmultipath: simplify devt2devname() Martin Wilck
2018-11-21 10:18 ` [PATCH 14/19] libmultipath: decrease log level for failed VPD c9 Martin Wilck
2018-11-21 10:18 ` [PATCH 15/19] libmultipath: adopt_paths: check for size match Martin Wilck
2018-11-21 10:18 ` [PATCH 16/19] libmultipath: coalesce_paths: fix size mismatch handling Martin Wilck
2018-11-29 20:53   ` Benjamin Marzinski
2018-12-03 10:34     ` Martin Wilck
2018-11-21 10:18 ` [PATCH 17/19] tests: add unit tests for bitmask functions Martin Wilck
2018-11-21 10:18 ` [PATCH 18/19] multipathd: uev_remove_path: remove redundant orphan_paths call Martin Wilck
2018-11-21 10:18 ` [PATCH 19/19] libmultipath: improve logging from orphan_paths Martin Wilck
2018-11-29 20:54 ` [PATCH 00/19] multipath-tools: improve logging at -v3 Benjamin Marzinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181129204944.GK5077@octiron.msp.redhat.com \
    --to=bmarzins@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=mwilck@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox