Linux Device Mapper development
 help / color / mirror / Atom feed
From: Martin Wilck <mwilck@suse.com>
To: Benjamin Marzinski <bmarzins@redhat.com>, mwilck+gmail@suse.de
Cc: dm-devel@redhat.com
Subject: Re: [PATCH 16/19] libmultipath: coalesce_paths: fix size mismatch handling
Date: Mon, 03 Dec 2018 11:34:25 +0100	[thread overview]
Message-ID: <ea4c95305c6fb3e6b5bf97f97b13671abcf77ba0.camel@suse.com> (raw)
In-Reply-To: <20181129205320.GL5077@octiron.msp.redhat.com>

On Thu, 2018-11-29 at 14:53 -0600,  Benjamin Marzinski  wrote:
> On Wed, Nov 21, 2018 at 11:18:36AM +0100, Martin Wilck wrote:
> > When there are paths with the same WWID but different sizes, and
> > coalesce_paths() walks the pathvec, it checks paths _after_
> > the current one for size mismatch and sets ACT_REJECT. However,
> > these paths will be reached in the main loop later, and this time
> > the already handled paths will not be checked for size mismatch;
> > thus a map could be created, possibly even with mismatching
> > devices.
> > 
> > Fix that by tracking which paths were already discarded, and
> > skipping them in the main loop later.
> 
> Previously, multipath would retry if coalesce_paths returned
> DOMAP_RETRY. With this patch, DOMAP_RETRY isn't returned, so that no
> longer happens. Is this intentional?

No, it was an oversight. Thanks for spotting it. Note: it's only
relevant for the case where lock_multipath() fails, which should hardly
ever happen any more since we are using shared locks (5ec07b3).
Whether we still need lock_multipath() is an open question. I
personally think we don't.

> 
> Also, I would prefer if coalesce_paths always used named constants
> for
> the return values, instead of converting them to numbers.

OK, I'll send an extra patch for that.

Martin

-- 
Dr. Martin Wilck <mwilck@suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)


--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

  reply	other threads:[~2018-12-03 10:34 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-21 10:18 [PATCH 00/19] multipath-tools: improve logging at -v3 Martin Wilck
2018-11-21 10:18 ` [PATCH 01/19] tests/hwtable: set multipath_dir in local configuration Martin Wilck
2018-11-21 10:18 ` [PATCH 02/19] tests/hwtable: adjust to new checker API Martin Wilck
2018-11-21 10:18 ` [PATCH 03/19] multipath-tools: decrease verbosity of state messages Martin Wilck
2018-11-21 10:18 ` [PATCH 04/19] libmultipath: decrease verbosity of pathinfo messages Martin Wilck
2018-11-21 10:18 ` [PATCH 05/19] libmultipath: decrease verbosity of TUR checker messages Martin Wilck
2018-11-21 10:18 ` [PATCH 06/19] libmultipath: avoid frequent messages from filter_property() Martin Wilck
2018-11-21 10:18 ` [PATCH 07/19] libmultipath: decrease log level of "disassembled" messages Martin Wilck
2018-11-21 10:18 ` [PATCH 08/19] libmultipath: decrease log level of word splitting Martin Wilck
2018-11-29 20:49   ` Benjamin Marzinski
2018-12-03 23:53   ` Benjamin Marzinski
2018-11-21 10:18 ` [PATCH 09/19] libmultipath: increase log level of map removal Martin Wilck
2018-11-21 10:18 ` [PATCH 10/19] multipathd: decrease log level of checker timing Martin Wilck
2018-11-21 10:18 ` [PATCH 11/19] libmultipath: decrease log level of "prioritizer refcount" message Martin Wilck
2018-11-21 10:18 ` [PATCH 12/19] libmpathpersist/update_map_pr: decrease log level for nop Martin Wilck
2018-11-21 10:18 ` [PATCH 13/19] libmultipath: simplify devt2devname() Martin Wilck
2018-11-21 10:18 ` [PATCH 14/19] libmultipath: decrease log level for failed VPD c9 Martin Wilck
2018-11-21 10:18 ` [PATCH 15/19] libmultipath: adopt_paths: check for size match Martin Wilck
2018-11-21 10:18 ` [PATCH 16/19] libmultipath: coalesce_paths: fix size mismatch handling Martin Wilck
2018-11-29 20:53   ` Benjamin Marzinski
2018-12-03 10:34     ` Martin Wilck [this message]
2018-11-21 10:18 ` [PATCH 17/19] tests: add unit tests for bitmask functions Martin Wilck
2018-11-21 10:18 ` [PATCH 18/19] multipathd: uev_remove_path: remove redundant orphan_paths call Martin Wilck
2018-11-21 10:18 ` [PATCH 19/19] libmultipath: improve logging from orphan_paths Martin Wilck
2018-11-29 20:54 ` [PATCH 00/19] multipath-tools: improve logging at -v3 Benjamin Marzinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea4c95305c6fb3e6b5bf97f97b13671abcf77ba0.camel@suse.com \
    --to=mwilck@suse.com \
    --cc=bmarzins@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=mwilck+gmail@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox