Re: [PATCH 00/19] multipath-tools: improve logging at -v3

["Benjamin Marzinski" <bmarzins@redhat.com>]

On Wed, Nov 21, 2018 at 11:18:20AM +0100, Martin Wilck wrote:
> Hi Christophe,
> 
> most of the patches in this series reduce log levels of frequently
> printed messages at verbosity level 3. My goal was to limit the
> output of multipathd to one line per path per checker invocation,
> which is sufficient to track multipathd's view of path health in
> the logs.
> 
> The standard setting of -v2 is not enough for post-mortem analysis of many
> failures. With this series, running multipathd with verbosity 3 becomes a
> realistic option even in production environments. So far the amount of output
> from multipathd with -v3 pretty much made this impossible, at least over
> longer time periods, and also made reading these logs very cumbersome due to
> the amount of redundant partly superfluos verbosity. I've taken care not
> to loose important information in the logs.
> 
> Apart from that, the series fixes errors in the unit tests introduced by my
> last "checker overhaul" patch series (proving that I forgot to run the
> tests before submitting :-( ), and fixes a problem that I found while testing
> handling of a bad configuration (paths with size mismatch).
> 

ACK for all patches except 8 and 16.

-Ben

> Regards,
> Martin
> 
> Martin Wilck (19):
>   tests/hwtable: set multipath_dir in local configuration
>   tests/hwtable: adjust to new checker API
>   multipath-tools: decrease verbosity of state messages
>   libmultipath: decrease verbosity of pathinfo messages
>   libmultipath: decrease verbosity of TUR checker messages
>   libmultipath: avoid frequent messages from filter_property()
>   libmultipath: decrease log level of "disassembled" messages
>   libmultipath: decrease log level of word splitting
>   libmultipath: increase log level of map removal
>   multipathd: decrease log level of checker timing
>   libmultipath: decrease log level of "prioritizer refcount" message
>   libmpathpersist/update_map_pr: decrease log level for nop
>   libmultipath: simplify devt2devname()
>   libmultipath: decrease log level for failed VPD c9
>   libmultipath: adopt_paths: check for size match
>   libmultipath: coalesce_paths: fix size mismatch handling
>   tests: add unit tests for bitmask functions
>   multipathd: uev_remove_path: remove redundant orphan_paths call
>   libmultipath: improve logging from orphan_paths
> 
>  libmpathpersist/mpath_persist.c |  3 +-
>  libmultipath/blacklist.c        | 54 +++++++++---------
>  libmultipath/blacklist.h        |  2 +-
>  libmultipath/checkers/tur.c     |  6 +-
>  libmultipath/configure.c        | 39 +++++++++----
>  libmultipath/discovery.c        | 20 ++++---
>  libmultipath/dmparser.c         |  6 +-
>  libmultipath/prio.c             |  2 +-
>  libmultipath/structs_vec.c      | 18 ++++--
>  libmultipath/structs_vec.h      |  3 +-
>  libmultipath/util.c             |  7 ++-
>  libmultipath/util.h             | 16 ++++++
>  multipathd/main.c               | 24 ++++----
>  tests/Makefile                  |  7 ++-
>  tests/blacklist.c               |  7 ++-
>  tests/hwtable.c                 | 89 ++++++++++++++++--------------
>  tests/util.c                    | 98 +++++++++++++++++++++++++++++++++
>  17 files changed, 278 insertions(+), 123 deletions(-)
> 
> -- 
> 2.19.1