From: Martin Wilck <mwilck@suse.com>
To: Christophe Varoqui <christophe.varoqui@opensvc.com>,
Benjamin Marzinski <bmarzins@redhat.com>
Cc: dm-devel@redhat.com, Martin Wilck <mwilck@suse.com>
Subject: [PATCH v2 0/9] multipath-tools: avoid I/O during uevent processing
Date: Fri, 15 Mar 2019 18:19:21 +0100 [thread overview]
Message-ID: <20190315171930.28335-1-mwilck@suse.com> (raw)
Hi Christophe, hi Ben,
the bulk of this series attempts to avoid unnecessary I/O for "multipath -u"
calls from udev rules. I came up with it in a recent attempt to debug
avoid "multipath -u" hangups during boot. I found that the detect_alua()
call in the get_refwwid->pathinfo->scsi_ioctl_pathinfo call sequence would
cause an sg ioctl to be sent for every "multipath -u" invocation. That's
obvious nonsense, we don't need to detect ALUA capabilities to find out
if a device is a potential multipath member.
So, rather than setting pp->tpgs in pathinfo, I resorted to a "lazy"
approach where ALUA capabilities are probed when they are needed, no
sooner. I also cleaned up the ALUA code a bit (still some more to go),
and made it attempt to read INQUIRY data from sysfs.
Regards,
Martin
Changes wrt v1:
- 6/9: remove one remaining direct access to pp->tpgs
- 9/9: use non-personal email address for maintainer
Martin Wilck (9):
libmultipath: add sysfs_get_inquiry()
libmultipath: alua: make API more consistent
libmultipath: alua: try to retrieve inquiry data from sysfs
libmultipath: constify sysfs_get_timeout()
libmultipath: detect_alua(): use system timeout
libmultipath: lazy tpgs probing
libmultipath: don't link alua_rtpg.o twice
libmultipath: check_rdac(): pre-check in hwtable
libmultipath: hwtable: add Lenovo DE series
libmultipath/discovery.c | 46 +++++++++++++++++++--------
libmultipath/discovery.h | 10 +++---
libmultipath/hwtable.c | 20 ++++++++++++
libmultipath/prioritizers/Makefile | 3 --
libmultipath/prioritizers/alua.c | 4 +--
libmultipath/prioritizers/alua_rtpg.c | 45 ++++++++++++++++++++------
libmultipath/prioritizers/alua_rtpg.h | 7 ++--
libmultipath/propsel.c | 33 +++++++++++++------
multipathd/main.c | 7 ++--
9 files changed, 127 insertions(+), 48 deletions(-)
--
2.21.0
next reply other threads:[~2019-03-15 17:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 17:19 Martin Wilck [this message]
2019-03-15 17:19 ` [PATCH v2 1/9] libmultipath: add sysfs_get_inquiry() Martin Wilck
2019-03-15 17:19 ` [PATCH v2 2/9] libmultipath: alua: make API more consistent Martin Wilck
2019-03-15 17:19 ` [PATCH v2 3/9] libmultipath: alua: try to retrieve inquiry data from sysfs Martin Wilck
2019-03-18 7:08 ` Hannes Reinecke
2019-03-18 9:47 ` Martin Wilck
2019-03-15 17:19 ` [PATCH v2 4/9] libmultipath: constify sysfs_get_timeout() Martin Wilck
2019-03-15 17:19 ` [PATCH v2 5/9] libmultipath: detect_alua(): use system timeout Martin Wilck
2019-03-15 17:19 ` [PATCH v2 6/9] libmultipath: lazy tpgs probing Martin Wilck
2019-03-15 17:19 ` [PATCH v2 7/9] libmultipath: don't link alua_rtpg.o twice Martin Wilck
2019-03-15 17:19 ` [PATCH v2 8/9] libmultipath: check_rdac(): pre-check in hwtable Martin Wilck
2019-03-18 7:10 ` Hannes Reinecke
2019-03-18 9:52 ` Martin Wilck
2019-03-18 10:06 ` Martin Wilck
2019-03-15 17:19 ` [PATCH v2 9/9] libmultipath: hwtable: add Lenovo DE series Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190315171930.28335-1-mwilck@suse.com \
--to=mwilck@suse.com \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox