From: Martin Wilck <mwilck@suse.de>
To: Martin Wilck <Martin.Wilck@suse.com>,
Christophe Varoqui <christophe.varoqui@opensvc.com>,
Benjamin Marzinski <bmarzins@redhat.com>,
Hannes Reinecke <hare@suse.com>,
mwilck+gmail@suse.de
Cc: NetApp RDAC team <ng-eseries-upstream-maintainers@netapp.com>,
dm-devel@redhat.com, Steve.Schremmer@netapp.com
Subject: Re: [PATCH v2 8/9] libmultipath: check_rdac(): pre-check in hwtable
Date: Mon, 18 Mar 2019 11:06:22 +0100 [thread overview]
Message-ID: <2a0f49b46a2aebebce517b69e9304611964df417.camel@suse.de> (raw)
In-Reply-To: <8aca1a5b7bdb79f369ac3ec395b3f81c4987e488.camel@suse.com>
On Mon, 2019-03-18 at 10:52 +0100, Martin Wilck wrote:
> On Mon, 2019-03-18 at 08:10 +0100, Hannes Reinecke w
> > *origin? dummy for do_set_from_hwe()?
> > What funky interface is that?
> >
> > Please redesign do_set_from_hwe() so as _not_ to require 'magic'
> > variables.
>
> It's the truly "funky" way the macros are written in dict.c :-/
> (Admittedly I wrote that one myself, but I was following the style of
> the file).
>
> But you're right, I don't like this "dummy" stuff either. As this
> patch
> set is meant as a bug fix and not a major redesign of dict.c, I guess
> I'll rather not use the do_set_from_hwe() macro there. And put the
> redesign on my to-do list.
... I meant propsel.c, of course. Sorry.
Martin
next prev parent reply other threads:[~2019-03-18 10:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 17:19 [PATCH v2 0/9] multipath-tools: avoid I/O during uevent processing Martin Wilck
2019-03-15 17:19 ` [PATCH v2 1/9] libmultipath: add sysfs_get_inquiry() Martin Wilck
2019-03-15 17:19 ` [PATCH v2 2/9] libmultipath: alua: make API more consistent Martin Wilck
2019-03-15 17:19 ` [PATCH v2 3/9] libmultipath: alua: try to retrieve inquiry data from sysfs Martin Wilck
2019-03-18 7:08 ` Hannes Reinecke
2019-03-18 9:47 ` Martin Wilck
2019-03-15 17:19 ` [PATCH v2 4/9] libmultipath: constify sysfs_get_timeout() Martin Wilck
2019-03-15 17:19 ` [PATCH v2 5/9] libmultipath: detect_alua(): use system timeout Martin Wilck
2019-03-15 17:19 ` [PATCH v2 6/9] libmultipath: lazy tpgs probing Martin Wilck
2019-03-15 17:19 ` [PATCH v2 7/9] libmultipath: don't link alua_rtpg.o twice Martin Wilck
2019-03-15 17:19 ` [PATCH v2 8/9] libmultipath: check_rdac(): pre-check in hwtable Martin Wilck
2019-03-18 7:10 ` Hannes Reinecke
2019-03-18 9:52 ` Martin Wilck
2019-03-18 10:06 ` Martin Wilck [this message]
2019-03-15 17:19 ` [PATCH v2 9/9] libmultipath: hwtable: add Lenovo DE series Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a0f49b46a2aebebce517b69e9304611964df417.camel@suse.de \
--to=mwilck@suse.de \
--cc=Martin.Wilck@suse.com \
--cc=Steve.Schremmer@netapp.com \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
--cc=hare@suse.com \
--cc=mwilck+gmail@suse.de \
--cc=ng-eseries-upstream-maintainers@netapp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox