From: Hannes Reinecke <hare@suse.com>
To: Martin Wilck <mwilck@suse.com>,
Christophe Varoqui <christophe.varoqui@opensvc.com>,
Benjamin Marzinski <bmarzins@redhat.com>
Cc: NetApp RDAC team <ng-eseries-upstream-maintainers@netapp.com>,
dm-devel@redhat.com, Steve.Schremmer@netapp.com
Subject: Re: [PATCH v2 3/9] libmultipath: alua: try to retrieve inquiry data from sysfs
Date: Mon, 18 Mar 2019 08:08:34 +0100 [thread overview]
Message-ID: <c2b2bdde-36aa-5ad9-aa5a-2722f9a22fd8@suse.com> (raw)
In-Reply-To: <20190315171930.28335-4-mwilck@suse.com>
On 3/15/19 6:19 PM, Martin Wilck wrote:
> This can avoid IO while configuring the path prioritizer.
> The alua prioritizer avoids reading from sysfs for a reason
> (see commit 7e2f46d3), but this applies only to RTPG / STPG,
> not to INQUIRY calls.
>
> Cc: Steve.Schremmer@netapp.com
> Cc: NetApp RDAC team <ng-eseries-upstream-maintainers@netapp.com>
> Cc: Hannes Reinecke <hare@suse.com>
> Signed-off-by: Martin Wilck <mwilck@suse.com>
> ---
> libmultipath/prioritizers/alua_rtpg.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/libmultipath/prioritizers/alua_rtpg.c b/libmultipath/prioritizers/alua_rtpg.c
> index d9215a88..271a019d 100644
> --- a/libmultipath/prioritizers/alua_rtpg.c
> +++ b/libmultipath/prioritizers/alua_rtpg.c
> @@ -188,6 +188,23 @@ retry:
> int do_inquiry(const struct path *pp, int evpd, unsigned int codepage,
> void *resp, int resplen, unsigned int timeout)
> {
> + struct udev_device *ud;
> +
> + ud = udev_device_get_parent_with_subsystem_devtype(pp->udev, "scsi",
> + "scsi_device");
> + if (ud != NULL) {
> + int rc;
> +
> + if (!evpd)
> + rc = sysfs_get_inquiry(ud, resp, resplen);
> + else
> + rc = sysfs_get_vpd(ud, codepage, resp, resplen);
> +
> + if (rc >= 0) {
> + PRINT_HEX((unsigned char *) resp, resplen);
> + return 0;
> + }
> + }
> return do_inquiry_sg(pp->fd, evpd, codepage, resp, resplen, timeout);
> }
>
>
Don't you need to do a udev_device_put() or somesuch?
Other than that:
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.com +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2019-03-18 7:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 17:19 [PATCH v2 0/9] multipath-tools: avoid I/O during uevent processing Martin Wilck
2019-03-15 17:19 ` [PATCH v2 1/9] libmultipath: add sysfs_get_inquiry() Martin Wilck
2019-03-15 17:19 ` [PATCH v2 2/9] libmultipath: alua: make API more consistent Martin Wilck
2019-03-15 17:19 ` [PATCH v2 3/9] libmultipath: alua: try to retrieve inquiry data from sysfs Martin Wilck
2019-03-18 7:08 ` Hannes Reinecke [this message]
2019-03-18 9:47 ` Martin Wilck
2019-03-15 17:19 ` [PATCH v2 4/9] libmultipath: constify sysfs_get_timeout() Martin Wilck
2019-03-15 17:19 ` [PATCH v2 5/9] libmultipath: detect_alua(): use system timeout Martin Wilck
2019-03-15 17:19 ` [PATCH v2 6/9] libmultipath: lazy tpgs probing Martin Wilck
2019-03-15 17:19 ` [PATCH v2 7/9] libmultipath: don't link alua_rtpg.o twice Martin Wilck
2019-03-15 17:19 ` [PATCH v2 8/9] libmultipath: check_rdac(): pre-check in hwtable Martin Wilck
2019-03-18 7:10 ` Hannes Reinecke
2019-03-18 9:52 ` Martin Wilck
2019-03-18 10:06 ` Martin Wilck
2019-03-15 17:19 ` [PATCH v2 9/9] libmultipath: hwtable: add Lenovo DE series Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2b2bdde-36aa-5ad9-aa5a-2722f9a22fd8@suse.com \
--to=hare@suse.com \
--cc=Steve.Schremmer@netapp.com \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
--cc=mwilck@suse.com \
--cc=ng-eseries-upstream-maintainers@netapp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox