* [2/2] dma: axi-dmac: report DMA_INTERLEAVE capability
@ 2019-02-15 9:17 Alexandru Ardelean
0 siblings, 0 replies; 4+ messages in thread
From: Alexandru Ardelean @ 2019-02-15 9:17 UTC (permalink / raw)
To: dmaengine, vkoul; +Cc: Dragos Bogdan, Alexandru Ardelean
From: Dragos Bogdan <dragos.bogdan@analog.com>
Fixes commit 0e3b67b348b8 ("dmaengine: Add support for the Analog Devices
AXI-DMAC DMA controller")
The `device_prep_interleaved_dma()` callback is already present since the
driver was submitted initially.
This change adds the DMA_INTERLEAVE capability to the capability mask of
the DMA engine.
Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---
drivers/dma/dma-axi-dmac.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
index 2c999113b989..b2039e60ae04 100644
--- a/drivers/dma/dma-axi-dmac.c
+++ b/drivers/dma/dma-axi-dmac.c
@@ -652,6 +652,7 @@ static int axi_dmac_probe(struct platform_device *pdev)
dma_dev = &dmac->dma_dev;
dma_cap_set(DMA_SLAVE, dma_dev->cap_mask);
dma_cap_set(DMA_CYCLIC, dma_dev->cap_mask);
+ dma_cap_set(DMA_INTERLEAVE, dma_dev->cap_mask);
dma_dev->device_free_chan_resources = axi_dmac_free_chan_resources;
dma_dev->device_tx_status = dma_cookie_status;
dma_dev->device_issue_pending = axi_dmac_issue_pending;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [2/2] dma: axi-dmac: report DMA_INTERLEAVE capability
@ 2019-02-25 6:53 Vinod Koul
0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2019-02-25 6:53 UTC (permalink / raw)
To: Alexandru Ardelean; +Cc: dmaengine, Dragos Bogdan
On 15-02-19, 11:17, Alexandru Ardelean wrote:
> From: Dragos Bogdan <dragos.bogdan@analog.com>
>
> Fixes commit 0e3b67b348b8 ("dmaengine: Add support for the Analog Devices
> AXI-DMAC DMA controller")
Am not sire this is appropriate here..
>
> The `device_prep_interleaved_dma()` callback is already present since the
> driver was submitted initially.
> This change adds the DMA_INTERLEAVE capability to the capability mask of
> the DMA engine.
>
> Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> ---
> drivers/dma/dma-axi-dmac.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
> index 2c999113b989..b2039e60ae04 100644
> --- a/drivers/dma/dma-axi-dmac.c
> +++ b/drivers/dma/dma-axi-dmac.c
> @@ -652,6 +652,7 @@ static int axi_dmac_probe(struct platform_device *pdev)
> dma_dev = &dmac->dma_dev;
> dma_cap_set(DMA_SLAVE, dma_dev->cap_mask);
> dma_cap_set(DMA_CYCLIC, dma_dev->cap_mask);
> + dma_cap_set(DMA_INTERLEAVE, dma_dev->cap_mask);
> dma_dev->device_free_chan_resources = axi_dmac_free_chan_resources;
> dma_dev->device_tx_status = dma_cookie_status;
> dma_dev->device_issue_pending = axi_dmac_issue_pending;
> --
> 2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [2/2] dma: axi-dmac: report DMA_INTERLEAVE capability
@ 2019-02-26 7:15 Ardelean, Alexandru
0 siblings, 0 replies; 4+ messages in thread
From: Ardelean, Alexandru @ 2019-02-26 7:15 UTC (permalink / raw)
To: vkoul@kernel.org; +Cc: dmaengine@vger.kernel.org, Bogdan, Dragos
On Mon, 2019-02-25 at 12:23 +0530, Vinod Koul wrote:
> [External]
>
>
> On 15-02-19, 11:17, Alexandru Ardelean wrote:
> > From: Dragos Bogdan <dragos.bogdan@analog.com>
> >
> > Fixes commit 0e3b67b348b8 ("dmaengine: Add support for the Analog
> > Devices
> > AXI-DMAC DMA controller")
>
> Am not sire this is appropriate here..
>
Hmm, probably.
I'm a bit vague if a device_prep_interleaved_dma() callback works fine [or
is fine to have] without a DMA_INTERLEAVE flag in the caps. I did not dig
too deep into the dmaengine.
I can re-spin this without the Fixes stuff
> >
> > The `device_prep_interleaved_dma()` callback is already present since
> > the
> > driver was submitted initially.
> > This change adds the DMA_INTERLEAVE capability to the capability mask
> > of
> > the DMA engine.
> >
> > Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> > ---
> > drivers/dma/dma-axi-dmac.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
> > index 2c999113b989..b2039e60ae04 100644
> > --- a/drivers/dma/dma-axi-dmac.c
> > +++ b/drivers/dma/dma-axi-dmac.c
> > @@ -652,6 +652,7 @@ static int axi_dmac_probe(struct platform_device
> > *pdev)
> > dma_dev = &dmac->dma_dev;
> > dma_cap_set(DMA_SLAVE, dma_dev->cap_mask);
> > dma_cap_set(DMA_CYCLIC, dma_dev->cap_mask);
> > + dma_cap_set(DMA_INTERLEAVE, dma_dev->cap_mask);
> > dma_dev->device_free_chan_resources =
> > axi_dmac_free_chan_resources;
> > dma_dev->device_tx_status = dma_cookie_status;
> > dma_dev->device_issue_pending = axi_dmac_issue_pending;
> > --
> > 2.17.1
>
> --
> ~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
* [2/2] dma: axi-dmac: report DMA_INTERLEAVE capability
@ 2019-02-26 8:02 Vinod Koul
0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2019-02-26 8:02 UTC (permalink / raw)
To: Ardelean, Alexandru; +Cc: dmaengine@vger.kernel.org, Bogdan, Dragos
On 26-02-19, 07:15, Ardelean, Alexandru wrote:
> On Mon, 2019-02-25 at 12:23 +0530, Vinod Koul wrote:
> > [External]
> >
> >
> > On 15-02-19, 11:17, Alexandru Ardelean wrote:
> > > From: Dragos Bogdan <dragos.bogdan@analog.com>
> > >
> > > Fixes commit 0e3b67b348b8 ("dmaengine: Add support for the Analog
> > > Devices
> > > AXI-DMAC DMA controller")
> >
> > Am not sire this is appropriate here..
> >
>
> Hmm, probably.
> I'm a bit vague if a device_prep_interleaved_dma() callback works fine [or
> is fine to have] without a DMA_INTERLEAVE flag in the caps. I did not dig
> too deep into the dmaengine.
>
> I can re-spin this without the Fixes stuff
Yes please and rebase on dmaengine-next
Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-26 8:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-26 8:02 [2/2] dma: axi-dmac: report DMA_INTERLEAVE capability Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2019-02-26 7:15 Ardelean, Alexandru
2019-02-25 6:53 Vinod Koul
2019-02-15 9:17 Alexandru Ardelean
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox