[PATCH v2 0/2] Add JH8100 support for snps,dw-axi-dmac

[PATCH v2 0/2] Add JH8100 support for snps,dw-axi-dmac

[Tan Chun Hau]

Add StarFive JH8100 DMA support.

Changes in v2:
- Amended commit message according to feedback.

Tan Chun Hau (2):
  dt-bindings: dma: snps,dw-axi-dmac: Add JH8100 support
  dmaengine: dw-axi-dmac: Add support for StarFive JH8100 DMA

 Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 1 +
 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c              | 3 +++
 2 files changed, 4 insertions(+)

-- 
2.25.1

[PATCH v2 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add JH8100 support

[Tan Chun Hau]

Add support for StarFive JH8100 SoC in Sysnopsys Designware AXI DMA
controller.

Both JH8100 and JH7110 require reset operation in device probe.
However, JH8100 doesn't need to apply different configuration on
CH_CFG registers.

Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com>
---
 Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
index 363cf8bd150d..525f5f3932f5 100644
--- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
+++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
@@ -21,6 +21,7 @@ properties:
       - snps,axi-dma-1.01a
       - intel,kmb-axi-dma
       - starfive,jh7110-axi-dma
+      - starfive,jh8100-axi-dma
 
   reg:
     minItems: 1
-- 
2.25.1

Re: [PATCH v2 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add JH8100 support

[Krzysztof Kozlowski]

On 27/03/2024 03:51, Tan Chun Hau wrote:
> Add support for StarFive JH8100 SoC in Sysnopsys Designware AXI DMA
> controller.
> 
> Both JH8100 and JH7110 require reset operation in device probe.
> However, JH8100 doesn't need to apply different configuration on
> CH_CFG registers.

This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.

Best regards,
Krzysztof

RE: [PATCH v2 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add JH8100 support

[ChunHau Tan]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Wednesday, 27 March, 2024 3:50 PM
> To: ChunHau Tan <chunhau.tan@starfivetech.com>; Eugeniy Paltsev
> <Eugeniy.Paltsev@synopsys.com>; Vinod Koul <vkoul@kernel.org>; Rob Herring
> <robh@kernel.org>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>;
> Conor Dooley <conor+dt@kernel.org>
> Cc: Leyfoon Tan <leyfoon.tan@starfivetech.com>; JeeHeng Sia
> <jeeheng.sia@starfivetech.com>; dmaengine@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add JH8100
> support
> 
> On 27/03/2024 03:51, Tan Chun Hau wrote:
> > Add support for StarFive JH8100 SoC in Sysnopsys Designware AXI DMA
> > controller.
> >
> > Both JH8100 and JH7110 require reset operation in device probe.
> > However, JH8100 doesn't need to apply different configuration on
> > CH_CFG registers.
> 
> This is a friendly reminder during the review process.
> 
> It looks like you received a tag and forgot to add it.
> 
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions,
> under or above your Signed-off-by tag. Tag is "received", when provided in a
> message replied to you on the mailing list. Tools like b4 can help here. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for tags received on the version they apply.
> 
> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitt
> ing-patches.rst#L577
> 
> If a tag was not added on purpose, please state why and what changed.

Hi Krzysztof, thank you very much for the feedback,
Sorry I overlooked it.
Do you prefer I resend V2 patch or send a V3 patch to include the Acked-by ?
Thank you.

> 
> Best regards,
> Krzysztof

Re: [PATCH v2 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add JH8100 support

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2122 bytes --]

On Wed, Mar 27, 2024 at 08:24:01AM +0000, ChunHau Tan wrote:
> 
> 
> > -----Original Message-----
> > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Sent: Wednesday, 27 March, 2024 3:50 PM
> > To: ChunHau Tan <chunhau.tan@starfivetech.com>; Eugeniy Paltsev
> > <Eugeniy.Paltsev@synopsys.com>; Vinod Koul <vkoul@kernel.org>; Rob Herring
> > <robh@kernel.org>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>;
> > Conor Dooley <conor+dt@kernel.org>
> > Cc: Leyfoon Tan <leyfoon.tan@starfivetech.com>; JeeHeng Sia
> > <jeeheng.sia@starfivetech.com>; dmaengine@vger.kernel.org;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH v2 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add JH8100
> > support
> > 
> > On 27/03/2024 03:51, Tan Chun Hau wrote:
> > > Add support for StarFive JH8100 SoC in Sysnopsys Designware AXI DMA
> > > controller.
> > >
> > > Both JH8100 and JH7110 require reset operation in device probe.
> > > However, JH8100 doesn't need to apply different configuration on
> > > CH_CFG registers.
> > 
> > This is a friendly reminder during the review process.
> > 
> > It looks like you received a tag and forgot to add it.
> > 
> > If you do not know the process, here is a short explanation:
> > Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions,
> > under or above your Signed-off-by tag. Tag is "received", when provided in a
> > message replied to you on the mailing list. Tools like b4 can help here. However,
> > there's no need to repost patches *only* to add the tags. The upstream
> > maintainer will do that for tags received on the version they apply.
> > 
> > https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitt
> > ing-patches.rst#L577
> > 
> > If a tag was not added on purpose, please state why and what changed.
> 
> Hi Krzysztof, thank you very much for the feedback,
> Sorry I overlooked it.
> Do you prefer I resend V2 patch or send a V3 patch to include the Acked-by ?

I resent the tag, you do not need to do anything.

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add JH8100 support

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

On Tue, Mar 26, 2024 at 07:51:25PM -0700, Tan Chun Hau wrote:
> Add support for StarFive JH8100 SoC in Sysnopsys Designware AXI DMA
> controller.
> 
> Both JH8100 and JH7110 require reset operation in device probe.
> However, JH8100 doesn't need to apply different configuration on
> CH_CFG registers.
> 
> Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[PATCH v2 2/2] dmaengine: dw-axi-dmac: Add support for StarFive JH8100 DMA

[Tan Chun Hau]

JH8100 requires reset operation only in device probe.

Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com>
---
 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
index a86a81ff0caa..abb3523ba8ab 100644
--- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
+++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
@@ -1653,6 +1653,9 @@ static const struct of_device_id dw_dma_of_id_table[] = {
 	}, {
 		.compatible = "starfive,jh7110-axi-dma",
 		.data = (void *)(AXI_DMA_FLAG_HAS_RESETS | AXI_DMA_FLAG_USE_CFG2),
+	}, {
+		.compatible = "starfive,jh8100-axi-dma",
+		.data = (void *)AXI_DMA_FLAG_HAS_RESETS,
 	},
 	{}
 };
-- 
2.25.1

Re: [PATCH v2 0/2] Add JH8100 support for snps,dw-axi-dmac

[Vinod Koul]

On Tue, 26 Mar 2024 19:51:24 -0700, Tan Chun Hau wrote:
> Add StarFive JH8100 DMA support.
> 
> Changes in v2:
> - Amended commit message according to feedback.
> 
> Tan Chun Hau (2):
>   dt-bindings: dma: snps,dw-axi-dmac: Add JH8100 support
>   dmaengine: dw-axi-dmac: Add support for StarFive JH8100 DMA
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: dma: snps,dw-axi-dmac: Add JH8100 support
      commit: 9bcf929ba1879887e0464d06cbf9b33839572af7
[2/2] dmaengine: dw-axi-dmac: Add support for StarFive JH8100 DMA
      commit: 559a6690187ee0ab7875f7c560d3d19e35423fb3

Best regards,
-- 
~Vinod