Re: [PATCH 10/12] riscv: dts: ultrarisc: Add initial device tree for UltraRISC DP1000

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing clock header and device tree binding for the clock controller.
--

--- Patch [10]: [PATCH 10/12] riscv: dts: ultrarisc: Add initial device tree for UltraRISC DP1000 ---
commit 5358a00c38b708f59bdaeb5f8358a7078053a24a
Author: Jia Wang <wangjia@ultrarisc.com>

riscv: dts: ultrarisc: Add initial device tree for UltraRISC DP1000
    
Add the base device tree for the UltraRISC DP1000 SoC. It describes
eight CP100 CPU cores, their cache topology, and essential peripherals
including CLINT, PLIC, the clock controller, pinctrl, GPIO, UART, SPI,
I2C, PCIe, GMAC, and the DMA controller.

> diff --git a/arch/riscv/boot/dts/ultrarisc/dp1000.dtsi b/arch/riscv/boot/dts/ultrarisc/dp1000.dtsi
> new file mode 100644
> index 0000000000000..470ab01e33b8a
> --- /dev/null
> +++ b/arch/riscv/boot/dts/ultrarisc/dp1000.dtsi
> @@ -0,0 +1,899 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright(C) 2026 UltraRISC Technology (Shanghai) Co., Ltd.
> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/clock/ultrarisc,dp1000-clk.h>

[Severity: Low]
Does this header exist in the tree or this patch series?

Without this header file, compiling the device tree using make dtbs will
result in a preprocessor build failure.

[ ... ]

> +		clkc: clock-controller@11080000 {
> +			compatible = "ultrarisc,dp1000-clk";

[Severity: Low]
Is there a corresponding YAML binding schema for this compatible string?

Validating the device tree using make dtbs_check will fail due to the missing
schema for the clock controller.

> +			reg = <0x0 0x11080000 0x0 0x1000>;
> +			clocks = <&osc_24m>;
> +			#clock-cells = <1>;
> +		};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260824-ultrarisc-dts-v1-0-61ab7aebe9e5@ultrarisc.com?part=10