Re: [PATCH 11/12] riscv: dts: ultrarisc: Add Shenzhen Rongda M0 board device tree

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Device tree binding header is placed in the local architecture directory instead of the standard include/dt-bindings/ path.
--

--- Patch [11]: [PATCH 11/12] riscv: dts: ultrarisc: Add Shenzhen Rongda M0 board device tree ---
commit 67b0db49374b5791844e1a3b66fc62faab120bb7
Author: Jia Wang <wangjia@ultrarisc.com>

riscv: dts: ultrarisc: Add Shenzhen Rongda M0 board device tree

Adds the device tree and pinctrl configurations for the Shenzhen Rongda M0
mATX motherboard, which is based on the UltraRISC DP1000 SoC.

> diff --git a/arch/riscv/boot/dts/ultrarisc/dp1000-pinctrl.h b/arch/riscv/boot/dts/ultrarisc/dp1000-pinctrl.h
> new file mode 100644
> index 0000000000000..4668e45d2335d
> --- /dev/null
> +++ b/arch/riscv/boot/dts/ultrarisc/dp1000-pinctrl.h
> @@ -0,0 +1,63 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Copyright (C) 2026 UltraRISC Technology (Shanghai) Co., Ltd.
> + */
> +
> +#ifndef _DP1000_PINCTRL_H
> +#define _DP1000_PINCTRL_H
> +
> +#define PA0		0
> +#define PA1		1

[Severity: Low]
Should this device tree binding header be placed in the standard
include/dt-bindings/pinctrl/ directory instead of the local architecture
directory?

Keeping it here might prevent the pinctrl driver from naturally sharing these
hardware ABI constants without violating include paths or duplicating
definitions.

[ ... ]

> diff --git a/arch/riscv/boot/dts/ultrarisc/dp1000-shenrongda-m0-pinctrl.dtsi b/arch/riscv/boot/dts/ultrarisc/dp1000-shenrongda-m0-pinctrl.dtsi
> new file mode 100644
> index 0000000000000..ab927c6cd6146
> --- /dev/null
> +++ b/arch/riscv/boot/dts/ultrarisc/dp1000-shenrongda-m0-pinctrl.dtsi
> @@ -0,0 +1,79 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright(C) 2026 UltraRISC Technology (Shanghai) Co., Ltd.
> + */
> +
> +#include "dp1000.dtsi"
> +#include "dp1000-pinctrl.h"

[Severity: Low]
If the header is moved to the standard include/dt-bindings/ path, would this
inclusion need to be updated to use the standard <dt-bindings/...> format?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260824-ultrarisc-dts-v1-0-61ab7aebe9e5@ultrarisc.com?part=11