Re: [PATCH] dmaengine: zynqmp_dma: drop redundant label

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Removing the `err_disable_pm` label causes a compilation failure because a `goto err_disable_pm;` statement remains in `zynqmp_dma_probe()`.
--

commit b231b06f7a09316d1f0854b835d97d063a04395f
Author: Vinod Koul <vkoul@kernel.org>

dmaengine: zynqmp_dma: drop redundant label

This commit removes the err_disable_pm label from zynqmp_dma_probe() to fix
an unused label warning reported after an earlier runtime PM update.

> diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c
> index 2b03584102acf..71a310d50ee33 100644
> --- a/drivers/dma/xilinx/zynqmp_dma.c
> +++ b/drivers/dma/xilinx/zynqmp_dma.c
> @@ -1149,7 +1149,6 @@ static int zynqmp_dma_probe(struct platform_device *pdev)
>  
>  free_chan_resources:
>  	zynqmp_dma_chan_remove(zdev->chan);
> -err_disable_pm:

[Severity: Low]
Does this change cause a build failure?

Looking at zynqmp_dma_probe(), it appears there is still a jump to this
label earlier in the function:

	ret = zynqmp_dma_chan_probe(zdev, pdev);
	if (ret) {
		dev_err_probe(&pdev->dev, ret, "Probing channel failed\n");
		goto err_disable_pm;
	}

If the label is removed, won't the compiler fail with an undeclared label
error during compilation?

>  	if (!pm_runtime_enabled(zdev->dev))
>  		zynqmp_dma_runtime_suspend(zdev->dev);
>  	pm_runtime_disable(zdev->dev);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260903170357.1711462-1-vkoul@kernel.org?part=1