Re: [PATCH] dmaengine: zynqmp_dma: drop redundant label

["Pandey, Radhey Shyam" <radheys@amd.com>]

On 9/3/2026 10:33 PM, Vinod Koul wrote:
> Commit 64c6f7da8c2c ("dmaengine: zynqmp_dma: Add runtime pm support")
> dropped the use of err_disable_pm label causing warning:
> 
> drivers/dma/xilinx/zynqmp_dma.c: In function ‘zynqmp_dma_probe’:
> drivers/dma/xilinx/zynqmp_dma.c:1171:1: error: label ‘err_disable_pm’ defined but not used [-Werror=unused-label]
>   1171 | err_disable_pm:
> 
> Drop it
> 
> Fixes: 64c6f7da8c2c ("dmaengine: zynqmp_dma: Add runtime pm support")

Seems Fixes tag is incorrect.
Fixes: 3f30db282c28 ("dmaengine: zynqmp_dma: Fix chan probe/remove error 
handling")

Rest looks fine to me.
Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Thanks!
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
>   drivers/dma/xilinx/zynqmp_dma.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c
> index d1ee51dde3d1..3b7dfa53f972 100644
> --- a/drivers/dma/xilinx/zynqmp_dma.c
> +++ b/drivers/dma/xilinx/zynqmp_dma.c
> @@ -1168,7 +1168,6 @@ static int zynqmp_dma_probe(struct platform_device *pdev)
>   
>   free_chan_resources:
>   	zynqmp_dma_chan_remove(zdev->chan);
> -err_disable_pm:
>   	if (!pm_runtime_enabled(zdev->dev))
>   		zynqmp_dma_runtime_suspend(zdev->dev);
>   	pm_runtime_disable(zdev->dev);