DMA Engine development
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@oss.nxp.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: dmaengine@vger.kernel.org, Frank Li <Frank.Li@kernel.org>
Subject: Re: [PATCH] dmaengine: zynqmp_dma: drop redundant label
Date: Thu, 3 Sep 2026 14:01:29 -0500	[thread overview]
Message-ID: <apnECT9Mz6ncrS8W@SMW015318> (raw)
In-Reply-To: <20260903170357.1711462-1-vkoul@kernel.org>

On Thu, Sep 03, 2026 at 10:33:57PM +0530, Vinod Koul wrote:
> Commit 64c6f7da8c2c ("dmaengine: zynqmp_dma: Add runtime pm support")
> dropped the use of err_disable_pm label causing warning:
>
> drivers/dma/xilinx/zynqmp_dma.c: In function ‘zynqmp_dma_probe’:
> drivers/dma/xilinx/zynqmp_dma.c:1171:1: error: label ‘err_disable_pm’ defined but not used [-Werror=unused-label]
>  1171 | err_disable_pm:
>
> Drop it
>
> Fixes: 64c6f7da8c2c ("dmaengine: zynqmp_dma: Add runtime pm support")
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/dma/xilinx/zynqmp_dma.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c
> index d1ee51dde3d1..3b7dfa53f972 100644
> --- a/drivers/dma/xilinx/zynqmp_dma.c
> +++ b/drivers/dma/xilinx/zynqmp_dma.c
> @@ -1168,7 +1168,6 @@ static int zynqmp_dma_probe(struct platform_device *pdev)
>
>  free_chan_resources:
>  	zynqmp_dma_chan_remove(zdev->chan);
> -err_disable_pm:
>  	if (!pm_runtime_enabled(zdev->dev))
>  		zynqmp_dma_runtime_suspend(zdev->dev);
>  	pm_runtime_disable(zdev->dev);
> --
> 2.43.0
>

  parent reply	other threads:[~2026-09-03 19:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03 17:03 [PATCH] dmaengine: zynqmp_dma: drop redundant label Vinod Koul
2026-09-03 17:11 ` sashiko-bot
2026-09-03 19:01 ` Frank Li [this message]
2026-09-05 15:31 ` Pandey, Radhey Shyam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apnECT9Mz6ncrS8W@SMW015318 \
    --to=frank.li@oss.nxp.com \
    --cc=Frank.Li@kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox