* [PATCH] dmaengine: idxd: clear block on fault flag when clear wq
@ 2021-08-03 22:37 Dave Jiang
2021-08-06 13:53 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jiang @ 2021-08-03 22:37 UTC (permalink / raw)
To: vkoul; +Cc: dmaengine
The block on fault flag is not cleared when we disable or reset wq. This
causes it to remain set if the user does not clear it on the next
configuration load. Add clear of flag in dxd_wq_disable_cleanup()
routine.
Fixes: da32b28c95a7 ("dmaengine: idxd: cleanup workqueue config after disabling")
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
drivers/dma/idxd/device.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
index 420b93fe5feb..d0b5222da0d9 100644
--- a/drivers/dma/idxd/device.c
+++ b/drivers/dma/idxd/device.c
@@ -396,6 +396,7 @@ void idxd_wq_disable_cleanup(struct idxd_wq *wq)
wq->priority = 0;
wq->ats_dis = 0;
clear_bit(WQ_FLAG_DEDICATED, &wq->flags);
+ clear_bit(WQ_FLAG_BLOCK_ON_FAULT, &wq->flags);
memset(wq->name, 0, WQ_NAME_SIZE);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: idxd: clear block on fault flag when clear wq
2021-08-03 22:37 [PATCH] dmaengine: idxd: clear block on fault flag when clear wq Dave Jiang
@ 2021-08-06 13:53 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2021-08-06 13:53 UTC (permalink / raw)
To: Dave Jiang; +Cc: dmaengine
On 03-08-21, 15:37, Dave Jiang wrote:
> The block on fault flag is not cleared when we disable or reset wq. This
> causes it to remain set if the user does not clear it on the next
> configuration load. Add clear of flag in dxd_wq_disable_cleanup()
> routine.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-06 13:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-03 22:37 [PATCH] dmaengine: idxd: clear block on fault flag when clear wq Dave Jiang
2021-08-06 13:53 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox